Fix #3939 - update firefox specific code in renderAd function #3980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
approved these changes
Jul 9, 2019
mkendall07
reviewed
Jul 9, 2019
src/prebid.js
Outdated
| doc.open('text/html', 'replace'); | ||
| // will check if browser is firefox and below version 67, if so execute special doc.open() | ||
| // for details see: https://github.com/prebid/Prebid.js/pull/3524 | ||
| // TODO remove this browser specific code at later date |
There was a problem hiding this comment.
I would just add here ...later date when Firefox < 67 usage is mostly gone
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
…rebid#3980) * update browser specific code in renderAd function * update TODO comment
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
…rebid#3980) * update browser specific code in renderAd function * update TODO comment
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
…rebid#3980) * update browser specific code in renderAd function * update TODO comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This change updates the firefox specific logic in the
renderAdfunction to only run if the user is using a version of Firefox below 67 (since Mozilla fixed the original bug in 67.0).Additional references relevant to this overall change: