Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump querystringify from 0.0.3 to 2.0.0 #4392

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 28, 2019

Bumps querystringify from 0.0.3 to 2.0.0.

Commits
  • 020c30f [dist] 2.0.0
  • 422eb4f [security] Prevent overriding of build-in properties by default (#19)
  • 0b65759 chore(package): update mocha to version 3.5.0 (#12)
  • 5e79e6e chore(package): update mocha to version 3.4.0 (#11)
  • 4cad3ab chore(package): update mocha to version 3.3.0 (#10)
  • 1e41231 Merge pull request #9 from unshiftio/greenkeeper/assume-1.5.0
  • 7cdb42e chore(package): update assume to version 1.5.0
  • 027cfb1 [dist] 1.0.0
  • 0f3e729 [fix] Convert plus signs to spaces (#8)
  • ca090ae Merge pull request #6 from unshiftio/greenkeeper/pre-commit-1.2.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [querystringify](https://github.com/unshiftio/querystringify) from 0.0.3 to 2.0.0.
- [Release notes](https://github.com/unshiftio/querystringify/releases)
- [Commits](unshiftio/querystringify@0.0.3...2.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 28, 2019
@jsnellbaker
Copy link
Collaborator

jsnellbaker commented Nov 4, 2019

Just a note from a quick look I did - the only place in the project we directly use this package is here

There is an alternative that they could use via that url-parse package that's included in the same script. If they use the parse feature of that package like below on the original parsedUrl, it will return the same type of result they're checking overall (including the query).
const parsedUrl = URL('https'+ request.url, true);

Maybe we should have this test updated and remove the querystringify package.

@jaiminpanchal27
Copy link
Collaborator

Created a PR #4422 to remove this package. We will close this PR once my PR is merged

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 5, 2019

Looks like querystringify is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Nov 5, 2019
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/querystringify-2.0.0 branch November 5, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file needs review on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants