Emit initial auction event #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matthewlane
commented
Jul 8, 2016
matthewlane
commented
- Generate a random auction id
- Return id as string to match expected schema type
- Remove redundant param from BID_RESPONSE event
|
|
||
| const auctionInit = { | ||
| timestamp: Date.now(), | ||
| refererUrl: document.referrer, |
There was a problem hiding this comment.
We don't need to pass around referrer here. Let's remove that.
There was a problem hiding this comment.
Removed. referrer is listed in the schema though, do we need to pass that from somewhere else?
* Generate random v4 UUID for auction id * Remove redundant param from BID_RESPONSE event * Send all configuration options * Remove referrer
matthewlane
force-pushed
the
auction-events
branch
from
effd5bd
to
0750135
Compare
|
LGTM |
|
@mkendall07 It doesn't look to me like this change affects user-facing, documented things. Is that correct? |
|
Correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.