Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trion interactive query param additions #4522

Merged
merged 18 commits into from
Dec 9, 2019
Merged

Trion interactive query param additions #4522

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
21bab6b
Adding files associated with the trion adapter update to the newest p…
Oct 17, 2017
fae1208
Merge branch 'master' into master
grohm33 Oct 17, 2017
3abcf64
Updating pull request with safer checks for user sync and general cle…
Oct 18, 2017
0c040fc
removing a call to bidder code for pull request review. also removin…
Nov 13, 2017
40444f7
Merge remote-tracking branch 'upstream/master'
Nov 13, 2017
324d157
there were some changes to the bid factory after our initial release …
Dec 5, 2017
bb5f8c7
Revert "there were some changes to the bid factory after our initial …
Dec 5, 2017
8d40681
Merge remote-tracking branch 'upstream/master'
Dec 5, 2017
8d67f63
there were some changes to the bid factory after our initial release …
Dec 5, 2017
6f213fb
Merge remote-tracking branch 'upstream/master'
Feb 8, 2019
c734aff
adding safety checks to Trion adapter
Feb 8, 2019
2bc52cf
Merge remote-tracking branch 'upstream/master'
Nov 26, 2019
29320de
Sending up to trion endpoint if there is bot traffic or the browser t…
Dec 2, 2019
f0c2028
sending the wrong param in the test.
Dec 2, 2019
2e4b257
Merge remote-tracking branch 'upstream/master'
Dec 2, 2019
5546465
Merge remote-tracking branch 'upstream/master'
Dec 3, 2019
3322fd4
Trion test cleanup. returning document and window states to their or…
Dec 9, 2019
4521bf0
Trion test cleanup. using before and after to alter window and docum…
Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions modules/trionBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ function buildTrionUrlParams(bid) {
var re = utils.getBidIdParameter('re', bid.params);
var url = utils.getTopWindowUrl();
var sizes = utils.parseSizesInput(bid.sizes).join(',');
var isAutomated = (navigator && navigator.webdriver) ? 1 : 0;
var isHidden = (document.hidden) ? 1 : 0;
var visibilityState = encodeURIComponent(document.visibilityState);

var intT = window.TR_INT_T && window.TR_INT_T != -1 ? window.TR_INT_T : null;
if (!intT) {
Expand All @@ -108,6 +111,9 @@ function buildTrionUrlParams(bid) {
if (intT) {
trionUrl = utils.tryAppendQueryString(trionUrl, 'int_t', encodeURIComponent(intT));
}
trionUrl = utils.tryAppendQueryString(trionUrl, 'tr_wd', isAutomated);
trionUrl = utils.tryAppendQueryString(trionUrl, 'tr_hd', isHidden);
trionUrl = utils.tryAppendQueryString(trionUrl, 'tr_vs', visibilityState);

// remove the trailing "&"
if (trionUrl.lastIndexOf('&') === trionUrl.length - 1) {
Expand Down
22 changes: 22 additions & 0 deletions test/spec/modules/trionBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,28 @@ describe('Trion adapter tests', function () {
expect(bidUrlParams).to.include(utils.getTopWindowUrl());
delete params.re;
});

it('should send the correct state when there is non human traffic', function () {
window.navigator['__defineGetter__']('webdriver', function () {
return 1;
});
let bidRequests = spec.buildRequests(TRION_BID_REQUEST);
let bidUrlParams = bidRequests[0].data;
expect(bidUrlParams).to.include('tr_wd=1');
});

it('should send the correct states when the document is not visible', function () {
document['__defineGetter__']('hidden', function () {
return 1;
});
document['__defineGetter__']('visibilityState', function () {
return 'hidden';
});
let bidRequests = spec.buildRequests(TRION_BID_REQUEST);
let bidUrlParams = bidRequests[0].data;
expect(bidUrlParams).to.include('tr_hd=1');
expect(bidUrlParams).to.include('tr_vs=hidden');
});
});

describe('interpretResponse', function () {
Expand Down