Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency update to support node12 #4820

Closed
wants to merge 1 commit into from

Conversation

renebaudisch
Copy link
Contributor

@renebaudisch renebaudisch commented Feb 4, 2020

Type of change

  • Build related changes

Description of change

changes dependencies to support node v12

Other information

related to already closed issue
#3878

but problem still exists for node12 and maybe > 8.9 in general

@stale
Copy link

stale bot commented Feb 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 19, 2020
@jsnellbaker jsnellbaker removed the stale label Feb 19, 2020
@jsnellbaker
Copy link
Collaborator

Hi @renebaudisch

Thanks for submitting this PR.

While I was digging into it, I found there are a number of other changes that will need to be made to our implementation of wdio and our e2e tests in order to use wdio 5.x (as they appear to have made a few breaking changes between 4 & 5).

So we won't be able to implement this PR as is. However, I think the overall update still has value, so I will start to work on putting together the necessary changes for our tests and will open a new PR with the combined updates.

@renebaudisch
Copy link
Contributor Author

THX for the information, the rest works pretty well under node v12, I builded and released a local 3.5.0 version without problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants