Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prebid adapter for windtalker #4935

Closed
wants to merge 5 commits into from
Closed

Prebid adapter for windtalker #4935

wants to merge 5 commits into from

Conversation

degroat
Copy link
Contributor

@degroat degroat commented Mar 5, 2020 •
edited by idettman
Loading

Type of change

  • [ X] New bidder adapter

Description of change

Prebid adapter for Windtalker.

  • test parameters for validating bids
{
  bidder: 'windtalker',
  params: {
           "pubId":"187046"
           ,"siteId":"10"
           ,"size":"300x250"
           ,"placementId":"456"
  }
}
  • contact email of the adapter’s maintainer: corbin@windtalker.io
  • [X ] official adapter submission

PR Docs: prebid/prebid.github.io#1788

@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2020

This pull request introduces 1 alert when merging 61b37d9 into fc770a3 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2020

This pull request introduces 1 alert when merging 0e4ca6f into ae1fe8f - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@harpere harpere requested a review from idettman March 5, 2020 22:18
@degroat
Copy link
Contributor Author

degroat commented Mar 6, 2020

@harpere Here are the docs prebid/prebid.github.io#1788

idettman
idettman suggested changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@idettman idettman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update branch to resolve the LGTM errors

@idettman idettman changed the title Prebid adatper for windtalker Prebid adapter for windtalker Mar 6, 2020
@idettman idettman added the docs label Mar 6, 2020
@degroat
Copy link
Contributor Author

degroat commented Mar 10, 2020

@idettman Fixed the LGTM issue, docs are posted above and the build test failure is on another adapter. Anything else you need?

@degroat degroat requested a review from idettman March 13, 2020 01:40
@degroat
Copy link
Contributor Author

degroat commented Mar 17, 2020

@idettman Can you please let me know what else is needed for this to be accepted. I fixed the LGTM issue.

degroat
degroat commented Mar 23, 2020
View reviewed changes
Copy link
Contributor Author

@degroat degroat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes have been completed

@degroat degroat closed this Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idettman idettman Awaiting requested review from idettman

Assignees

@idettman idettman

Labels
docs needs update reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@degroat @idettman @harpere