allows multiple bids to be registered per a slot, related to #496 #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please implement the bid ID matching strategy provided for with #498 on #L62 and #L125 by passing the bid requested to The changes in this PR will result in multiple Rubicon bid objects per slot, so we need to match the bid request/response pair IDs. |
snapwich
force-pushed
the
multiple-rubicon-bids-per-slot
branch
from
ba63284
to
df10b79
Compare
|
this has been updated as you suggested |
|
Verified the scenario with multi sizes per bidder request and it appears to be working correctly. LGTM. Thanks for fixing! |
protonate
pushed a commit
that referenced
this pull request
Aug 20, 2016
marian-r
added a commit
to aol/Prebid.js
that referenced
this pull request
Sep 23, 2016
…2.0 to master * commit '40fdbed10c218a993df9e6665797b36f402ded18': (52 commits) Added new adapter for AOL analytics Fixed ES6 features which require a polyfill Updated CHANGELOG Fixed per-adapter timeouts Fixed sorting of per-adapter timeouts Added horizontal rule to delimit the original README part Link to the AOL documentation made more visible Fixed unit tests for AOL analytics Made changes required due to pull from Prebid official Updated README Updated LICENSE Reverted AOL branding restore url.js and modifcations to ajax.js (prebid#551) Log unsupported ad type only for good bids (prebid#547) use var ad instead of incorrect ads in rubicon adapter (prebid#546) Karma opens debug.html by default (prebid#540) Prebid 0.12.0 release Add tests for triplelift adapter. (prebid#531) allows multiple bids to be registered per a slot, related to prebid#496 (prebid#503) Add tests for aardvark adapter. (prebid#529) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is for the rubicon adapter