SpotX: Set ad_mute correctly. #5486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the SpotX Prebid adapter, data-spotx_ad_mute was being set to '0' isntead of '1', in scenarios where the user passed in 'ad_mute'.
|
@nathan-lapinski -- Please add a unit test for this scenario |
|
once unit tests are added, we can approve and merge this |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Sorry I missed the last commit. This is good to go now that there's a test. |
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
* Set ad_mute correctly. In the SpotX Prebid adapter, data-spotx_ad_mute was being set to '0' isntead of '1', in scenarios where the user passed in 'ad_mute'. * Updates unit test to ensure ad_mute is set correctly Co-authored-by: Nate Lapinski <nlapinski@spotx.tv>
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
This reverts commit 5199955.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the SpotX Prebid adapter,
data-spotx_ad_mutewas being set to'0' instead of '1', in scenarios where the user passed in 'ad_mute'.
Type of change
Description of change
In the SpotX Prebid adapter, data-spotx_ad_mute was being set to
'0' instead of '1', in scenarios where the user passed in 'ad_mute'.
Other information