Audigent HaloID User Id System Module #5524
Conversation
|
Hello @anthonylauzon , Also we will need to add entry in https://github.com/prebid/Prebid.js/blob/master/modules/.submodules.json to auto-select the parent module at build time. |
|
there are no unit tests added to the user id module unit tests as all other prs have done |
There was a problem hiding this comment.
A few comments about how you're retrieving and storing your ID from cache:
Your code is manually retrieving your ID only from localStorage and only from one of two names: haloId or auHaloId. However, are using the userId module to handle writing the ID to cache, which relies on the storage configuration settings, which you allow the publisher to configure (both the storage type and name). It's entirely possible that neither of the locations you hardcoded in your IdSystem contains the ID that was stored by the userId module.
I would suggest you either read the parameters from the publisher configuration to read the ID (or better yet, just add a third parameter to your getId() method which contains the cached ID, if any; or you need to write the ID to cache yourself so you know where it is located, and if you do, you should drop any storage config from the docs so publishers aren't confused.
|
Appears to be missing changes to eids spec |
|
i don't see any docs PRs for this, which are required before merging |
|
@anthonylauzon Looks like another merge created conflicts, fyi |
|
@anthonylauzon have you also raised PR for the related documentation? |
|
|
@smenzer @pm-harshad-mane this is ready to go. can we please merge this so that we can begin integration with our RTD module? |
|
Hello @jsnellbaker , @bretg , @idettman |
Type of change
Description of change
This changeset adds support for the Audigent HaloID.
ant@audigent.com
Other information
Audigent Segmentation Real-time Data Provider #4834
#4834