remove cmpuishown event for tcf2 logic #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harpere
reviewed
Aug 27, 2020
jsnellbaker
added
needs 2nd review
smenzer
reviewed
Sep 1, 2020
|
This pull request introduces 1 alert and fixes 2 when merging d4103b1 into c4c060e - view on LGTM.com new alerts:
fixed alerts:
|
smenzer
requested changes
Sep 1, 2020
smenzer
approved these changes
Sep 1, 2020
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
* remove cmpuishown event for tcf2 logic * store consent on "cmpuishown" event * reverted last consnetManagement cmpuishown commit * combine if statements * fix typo Co-authored-by: Eric Harper <eharper@rubiconproject.com>
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
This reverts commit 547093e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
A follow-up from #5564 - this change removes the event logic for
cmpuishownas further review determined it's not really needed for Prebid.js.Please see this comment from the previous ticket for additional context.