Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed running of single spec file #5648

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

monis0395
Copy link
Contributor

Type of change

  • Bugfix

Description of change

@monis0395
Copy link
Contributor Author

Hi @pm-harshad-mane, can you please review this PR?

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

config.preprocessors[file] = ['webpack', 'sourcemap'];
});
delete config.preprocessors['test/test_index.js'];
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the only thing we needed to fix!? haha thank you a bunch!

On my local:

27 seconds to test one file

82 seconds to test all files

So definitely worth it!

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for putting this together.

@jsnellbaker jsnellbaker merged commit d38b5d0 into prebid:master Aug 26, 2020
@monis0395 monis0395 deleted the run-single-spec branch August 26, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants