fix GPT Pre-Auction PBS path

[idettman]

Type of change

• Bugfix

Description of change

The implementation of #5216 has a problem:

The spec said:

pass fpd.context.adserver.name in the OpenRTB as imp[].ext.context.data.adserver.name
pass fpd.context.adserver.adSlot in the OpenRTB as imp[].ext.context.data.adserver.adslot
Both pbsBidAdapter and the rubiconBidAdapter were implemented incorrectly:

      const gamAdUnit = utils.deepAccess(adUnit, 'fpd.context.adServer.adSlot');
      if (typeof gamAdUnit === 'string' && gamAdUnit) {
        utils.deepSetValue(imp, 'ext.context.data.adslot', gamAdUnit);  // missing the 'adserver' level and not passing adserver name at all.
      }

[patmmccann]

fyi @gpolaert

[gpolaert]

Thanks @patmmccann @idettman

FYI, last week, I've had an issue with the bid.imp[].ext.context field with the latest version of the prebid server (golang edition).
The error message was: context is not a bidder, did you add the corresponding an alias? (or something like that)

In the source code, it seems the key of extra data/meta should be "below" bid.imp[].ext.prebid, not directly context.

Where I can find the definition of the request send to the Prebid Server? Is there documentation somewhere?

[robertrmartinez]

Looks good to me

[robertrmartinez]

Thanks @patmmccann @idettman

FYI, last week, I've had an issue with the bid.imp[].ext.context field with the latest version of the prebid server (golang edition).
The error message was: context is not a bidder, did you add the corresponding an alias? (or something like that)

In the source code, it seems the key of extra data/meta should be "below" bid.imp[].ext.prebid, not directly context.

Where I can find the definition of the request send to the Prebid Server? Is there documentation somewhere?

@bretg @idettman

This seems to be correct, right?

imp.ext are usually where bidders go, besides the reserved word "prebid".

Maybe this does need to go under imp.ext.prebid.???

[robertrmartinez]

Actually, I just tested this using Rubicon's Prebid Server (Java) and it does not throw the error.

Seems context WAS added to the PBS code as a reserved word.

And I can see the Rubicon PBS adapter picking up these attributes and passing them to the exchange.

@gpolaert It is possible the required change for context in the ext object are not yet in the PBS you are testing.

Please provide more context (no pun intended)

[gpolaert]

@robertrmartinez
The prebid server (Go) checks if the bidder names are valid.

Check here: https://github.com/prebid/prebid-server/blob/master/endpoints/openrtb2/auction.go#L759-L777

Note: openrtb_ext.PrebidExtKey = "prebid"

As context is not excluded from the condition, the server returns an error.

[robertrmartinez]

@bretg

Is the change to not validate the context object going to be ported to PBS GO?

[bretg]

Is the change to not validate the context object going to be ported to PBS GO?

I've put it on the list to discuss at Friday's PBS meeting.

[robertrmartinez]

@gpolaert

Looks like a PR has been submitted to update the PBS GO to handle this. (thanks @bretg for pointing it out)

prebid/prebid-server#1479

I am merging this PR now.