-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new version for DecenterAds #5711
Conversation
Hello. How long waits to merge my commits into the Master branch? |
typically reviews are done within a week. |
Thank you |
Will this commit be included in version 4.0 and higher or only in the latest 4.6? And how to add adapters for versions 3.17 and higher? |
We don't do merges to old branches except near the time of major version releases. 3.27.1 was the last 3.x release and there are no more planned. There are not separate branches for each minor version change that you can commit against and that are maintained independently. If you make commits now, your existing adapter would be in 4.5 and your changes would likely be in 4.7 or 4.8. The version that is in 4.5 now will never change. Every week the number increments, with any change to 4.x Please take a look at the conversation in this PR, it has more details: #5680 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vlaktion You bidder will be available from pbjs 4.8.0 (next release) |
Hello. Can you add this commits to 4.5 or 4.6, please? |
@vlaktion please see my previous comments...we do not merge to old branches or versions. this will go out in the next prebid release, scheduled for next week. |
* add new version decenteradsBidAdapter.js * add new version decenteradsBidAdapter_spec.js * add .js to import * replace method getWindowLocation * replace urls Co-authored-by: vlad <vlaktionov@decenterads.com>
This reverts commit 41100b9.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information