Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new version for DecenterAds #5711

Merged
merged 5 commits into from
Sep 8, 2020
Merged

add new version for DecenterAds #5711

merged 5 commits into from
Sep 8, 2020

Conversation

vlaktion
Copy link
Contributor

@vlaktion vlaktion commented Sep 8, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@vlaktion
Copy link
Contributor Author

vlaktion commented Sep 8, 2020

Hello. How long waits to merge my commits into the Master branch?

@vlaktion vlaktion closed this Sep 8, 2020
@vlaktion vlaktion reopened this Sep 8, 2020
@smenzer
Copy link
Collaborator

smenzer commented Sep 8, 2020

typically reviews are done within a week.

@vlaktion
Copy link
Contributor Author

vlaktion commented Sep 8, 2020

Thank you

@vlaktion
Copy link
Contributor Author

vlaktion commented Sep 8, 2020

Will this commit be included in version 4.0 and higher or only in the latest 4.6? And how to add adapters for versions 3.17 and higher?

@smenzer
Copy link
Collaborator

smenzer commented Sep 8, 2020

Will this commit be included in version 4.0 and higher or only in the latest 4.6? And how to add adapters for versions 3.17 and higher?

We don't do merges to old branches except near the time of major version releases. 3.27.1 was the last 3.x release and there are no more planned.

There are not separate branches for each minor version change that you can commit against and that are maintained independently. If you make commits now, your existing adapter would be in 4.5 and your changes would likely be in 4.7 or 4.8. The version that is in 4.5 now will never change. Every week the number increments, with any change to 4.x

Please take a look at the conversation in this PR, it has more details: #5680 (comment)

Copy link
Contributor

@FilipStamenkovic FilipStamenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FilipStamenkovic FilipStamenkovic merged commit 44a3797 into prebid:master Sep 8, 2020
@FilipStamenkovic
Copy link
Contributor

@vlaktion You bidder will be available from pbjs 4.8.0 (next release)

@vlaktion
Copy link
Contributor Author

vlaktion commented Sep 9, 2020

Hello. Can you add this commits to 4.5 or 4.6, please?

@smenzer
Copy link
Collaborator

smenzer commented Sep 9, 2020

@vlaktion please see my previous comments...we do not merge to old branches or versions. this will go out in the next prebid release, scheduled for next week.

BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
* add new version decenteradsBidAdapter.js

* add new version decenteradsBidAdapter_spec.js

* add .js to import

* replace method getWindowLocation

* replace urls

Co-authored-by: vlad <vlaktionov@decenterads.com>
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants