Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triplelift: fpd and advertiser name support #5731

Merged
merged 23 commits into from
Sep 14, 2020

Conversation

colbertk
Copy link
Contributor

Type of change

  • Feature

Description of change

  • Adds a meta field for advertiser name

  • Adds fpd to ext

  • Added unit tests.

  • contact email of the adapter’s maintainer prebid@triplelift.com

willchapin and others added 23 commits September 16, 2019 15:15
It appears we've been looking for UnifiedId userIds
on the bidderRequest object, when they are found on bidRequests.
This commit fixes that error, and adds support for IdentityLink.
* Sending schain

* null -> undefined
…iser-info

TL-17254 expose advertiser name in meta field
* Triplelift: Add support for global fpd

* don't filter fpd
@Fawke Fawke self-requested a review September 14, 2020 08:00
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fawke Fawke added the LGTM label Sep 14, 2020
@Fawke Fawke merged commit 0bd72ab into prebid:master Sep 14, 2020
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
* Add IdentityLink support and fix UnifiedId.

It appears we've been looking for UnifiedId userIds
on the bidderRequest object, when they are found on bidRequests.
This commit fixes that error, and adds support for IdentityLink.

* change maintainer email to group

* TripleLift: Sending schain (#1)

* Sending schain

* null -> undefined

* Hardcode sync endpoint protocol

* Switch to EB2 sync endpoint

* Add support for image based user syncing

* Rename endpoint variable

* Add assertion

* Add CCPA query param

* Simplify check for usPrivacy argument

* put advertiser name in the bid.meta field if it exists

* update unit tests with meta.advertiserName field

* Triplelift: FPD key value pair support (prebid#5)

* Triplelift: Add support for global fpd

* don't filter fpd

* adds coppa support back in

Co-authored-by: Will Chapin <wrchapin@gmail.com>
Co-authored-by: David Andersen <davidwoodsandersen@gmail.com>
Co-authored-by: Brandon Ling <bling@triplelift.com>
Co-authored-by: Kevin Zhou <kzhou@triplelift.com>
Co-authored-by: kzhouTL <43545828+kzhouTL@users.noreply.github.com>
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants