Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sonobi adapter for: config settings, floor, deals, unit tests #591

Merged
merged 1 commit into from
Sep 2, 2016

Conversation

Studnicky
Copy link
Member

@Studnicky Studnicky commented Aug 31, 2016

Significant update for Sonobi Adapter

  • Associates request bid object with returned bid object (Set bid response ID to bid request ID #509)
  • Allows deals (Launching Deals #404)
  • Allows optional floor setting
  • Creates fail bids for improper configs
  • Accomodates for inconsitent adunit codes
  • No longer errors when users confuse Sonobi placement id with DFP ad unit code
  • No longer requires dom_id for unique identifier
  • Backwards compatible with previous config settings

You will be unable to test deals without an internal tool that has been shared previously
(@mkendall07)

@Studnicky
Copy link
Member Author

Example Configs for quick testing:

placement_id config style
https://gist.github.com/Studnicky/cfe80a0695621a0ca62996a82c6c6490
ad_unit config style
https://gist.github.com/Studnicky/d6f00d293173fe875ff46ca165ef6e8a

@jaiminpanchal27
Copy link
Collaborator

Verified. Looks good. Thanks @Studnicky

@jaiminpanchal27 jaiminpanchal27 merged commit d6ef3a6 into prebid:master Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants