Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added user sync support into adapter #5934

Merged
merged 16 commits into from
Nov 12, 2020
Merged

Added user sync support into adapter #5934

merged 16 commits into from
Nov 12, 2020

Conversation

lm-abhijit
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

We have added user sync support into our adapter.

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Added lemma bid adapter file
Added lemma bid adapter md file
Added lemma bid adapter test spec file
Fixed automated code review alert comparison between inconvertible types
Fixed review changes
Correct parameter value.
Lemma Bid Adapter - v3.0 compliance
Lemma Bid Adapter - v3.0 compliance
Lemma Bid Adapter - v3.0 compliance
Added user sync support into bid adapter.
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add associated unit tests

modules/lemmaBidAdapter.js Outdated Show resolved Hide resolved
updated include modules js file extension.
Added unit test for user sync feature.
Copy link
Contributor

@FilipStamenkovic FilipStamenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are couple of small errors that should be fixed before merging.

You can just run gulp lint and take a look at the output, it will fix ' vs " format and it will let you know about other errors.

modules/lemmaBidAdapter.js Outdated Show resolved Hide resolved
modules/lemmaBidAdapter.js Outdated Show resolved Hide resolved
test/spec/modules/lemmaBidAdapter_spec.js Outdated Show resolved Hide resolved
Fixed format error.
Fixed format error and typo error.
Copy link
Contributor

@FilipStamenkovic FilipStamenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FilipStamenkovic FilipStamenkovic merged commit 2b0bd53 into prebid:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants