Prevent renderAd from overwriting the website DOM document #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -441,7 +441,9 @@ $$PREBID_GLOBAL$$.renderAd = function (doc, id) { | |||
| var url = adObject.adUrl; | |||
| var ad = adObject.ad; | |||
|
|
|||
| if (ad) { | |||
| if (doc===document) { | |||
There was a problem hiding this comment.
We need mark the winning bid before bailing out if the ad render call tries to replace the top document. Previously I had placed it right before the if (adObject) check but that's too early.
|
LGTM. Thanks! |
Studnicky
pushed a commit
to sonobi/Prebid.js
that referenced
this pull request
Oct 4, 2016
* Ensure that we’re not writing to the current document * Check for current document access after marking the ad as winning bid
Studnicky
pushed a commit
to sonobi/Prebid.js
that referenced
this pull request
Oct 4, 2016
* Ensure that we’re not writing to the current document * Check for current document access after marking the ad as winning bid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #602