Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deals in Index Exchange adaptor #620

Closed
wants to merge 1 commit into from

Conversation

indexexchange
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

  • Adding support for IX deal bids
  • Adding support for sizes in IX configuration
  • Adding IX sandbox mode
  • Relaxing configuration check
  • Using up-to-date IX demand parameters
  • official adapter submission

Other information

This PR depends on the fix for issue #618.
This should be merged in after PR #619

@mkendall07
Copy link
Member

Hi @indexexchange
This is a lot of code change in the PR. I see a debug mode has been added (nice!), any instructions on how to use/test this feature? Any additional things in this PR? How about unit tests?

@indexexchange
Copy link
Contributor Author

@mkendall07 -- we're hoping to get deal support for the IX adapter merged into the upcoming v0.13 release; we can make a separate PR for that feature. Would that be preferable?

@protonate
Copy link
Collaborator

@indexexchange I've merged the prerequisite #619 so if you are able to make a separate PR specific to IX adapter deal support, with focused changes and test coverage, or can provide test coverage for all changes here, we should be able to include it in 0.13.0 release.

@indexexchange
Copy link
Contributor Author

so if you are able to make a separate PR specific to IX adapter deal support

We'll close this PR in favour of a more focused change solely for deal support.

@indexexchange indexexchange mentioned this pull request Sep 16, 2016
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants