Pubmatic Bid Adapter: Add warning for non-string adSlots #6304

jsut · 2021-02-12T05:35:10Z

Type of change

Other

Description of change

output a warning if adSlot is not a string. Update markdown to indicate they should be strings. It might be better to just support non-strings, since the recommended usage of the field is actually a number these days, but that's a bit more work, and would probably want tests.

- and update the markdown file to say they should be strings

patmmccann · 2021-02-12T14:14:21Z

modules/pubmaticBidAdapter.md

@@ -26,7 +26,7 @@ var adUnits = [
      params: {
        publisherId: '156209',               // required, must be wrapped in quotes
        oustreamAU: 'renderer_test_pubmatic',   // required if mediaTypes-> video-> context is 'outstream' and optional if renderer is defined in adUnits or in mediaType video. This value can be get by BlueBillyWig Team.
-        adSlot: 'pubmatic_test2',            // optional
+        adSlot: 'pubmatic_test2',            // optional, must be wrapped in quotes


must be wrapped in quotes is an odd way of saying must be a string, when i first read it, i thought it meant must have escaped quotes as the first and last character of the string.

how about: must be a string, not an integer or other js type.

I copied the text that pubmatic (i assume) used on publisherId. I'll update both to say String, which i agree makes more sense.

mike-chowla

LGTM

Fawke

LGTM

@97

* Increment pre version * Fix astraoneBidAdapter (prebid#6230) * Fix astraoneBidAdapter * Fix examples; update astraoneBidAdapter description * Fix astraoneBidAdapter_spec * Remove integration examples * Rename gbt to gpt * update banner ttl (prebid#6228) * browsi: updating test parameters (prebid#6048) * SpotX Bid Adapter: default to 4/3 aspect ratio when response doesn't contain w or h (prebid#6159) * Default to 4/3 aspect ratio when response doesn't contain w or h * SpotX bid adapter: reorder tests and remove extra assertions * Extended ID permissions supported by bidder (prebid#6112) * User id bidder permission scheme * styling * prebidServer support * - * fix * prebidServerBidAdapter take eidPermissions directly from userId module * - * unit tests * - * - * update * - * - * changed pbjs_bidders to pbjsBidders * changed pbjsBidders to bidders ext.prebid.data.eidPermissions to ext.prebid.data.eidpermissions * rerun circleci * rerun circleci * omitting eidPermission entry if 'bidders' is not configured Co-authored-by: myerkovich <myerkovich@rubiconproject.com> Co-authored-by: Marko Yerkovich <marko_yerkovich@MacBook-Pro-Marko.local> * Relevant Yield analytics adapter (prebid#6195) * Pubmatic: fix issue where using an adUnit outstream renderer throws an error (prebid#6152) * Malltv Bid Adapter : added data object as a param (prebid#6232) * Updated malltv adapter * Updated markdown * Added test for malltvBidAdapter * support setting coopSync in s2sConfig (prebid#6213) Co-authored-by: Mark Monday <mmonday@rubiconproject.com> * Revert "support setting coopSync in s2sConfig (prebid#6213)" (prebid#6249) This reverts commit 25dd35c. * pbsBidAdapter: change order of client syncs (prebid#6248) * pbsBidAdapter: change order cookie_syncs Prebid Server places cookie-sync URLs in a specific order. PBJS was pulling them off in reverse order. * moving comment * reverting coopSync * pass a flag back to ID5 servers if abTesting was enabled by the publisher for monitoring usage of the feature (prebid#6170) * appneuxs Bid Adapter - add support for identitylink userId (prebid#6245) * Update britepoolIdSystem.md (prebid#6254) Eliot from Britepool says you can set just the api key without any params (eg ssid or hash) * UNICORN Adapter - accept multiple formats (prebid#6255) * enable multiple formats add version * add banner w/h * fix w/h & spec * ATS-analytics - add comment clarifying ownership of atsAnalytics (prebid#6257) * [ParrableIdSystem] Ensure base64 payload is url-safe (prebid#6258) * Added url safe base64 encoding * Added url safe base64 encoding test Co-authored-by: Victor <victorigualada@gmail.com> * Keywords + Screen resolution + CPU Core (prebid#6259) Co-authored-by: sgimenez <sergi.gimenez@richaudience.com> * Rubicon Analytics: Fire event once gptSlots render (prebid#6241) * Once all gam slots are back fire event * push to cmd queue * New dimension for tracking name of the matching adUnit pattern (prebid#6252) * Adhese Bid Adapter: Per adunit targets (prebid#6256) * adpod category support test * Revert "adpod category support test" * Gjirafa Bid Adapter: added data object as a param (prebid#6231) * Added data parameter to gjirafaBidAdapter * Updated gjirafaBidAdapter markdown * Added test for gjirafaBidAdapter * Fix a TypeError when message event source is not available (prebid#6224) * fix broken tests due to "encoded" base64 logic (prebid#6268) * Adkernel Bid Adapter: stringads alias added (prebid#6262) * Adkernel: stringads alias * Revert "Extended ID permissions supported by bidder (prebid#6112)" (prebid#6269) This reverts commit a926dee. * Prebid 4.25.0 Release * Increment pre version * smartxBidAdapter: new Feature - Made Out-Stream Player configurable (prebid#6239) * Add smartclipBidAdapter * smartxBidAdapter.js - removed unused variables, removed debug, added window before the outstream related functions * - made outstream player configurable * remove wrong named files * camelcase * fix Co-authored-by: smartclip AdTechnology <adtech@smartclip.com> Co-authored-by: Gino Cirlini <adtech@smartclip.tv> * Idl1 (prebid#6242) * Renaming idLibrary to idImportLibrary * Renaming idLibrary to idImportLibrary Co-authored-by: skocheri <skocheri@rubiconproject.com> * Add the trade desk gvlid (prebid#6263) UnifiedId only works with a vendor exception in the gdpr enforcement module. However this is not okay as the unifiedId matching endpoint doesn't take the consent into account and cookies are being dropped even without consent. * pick up wrapper family detail (prebid#6272) * Add user sync (prebid#6244) * initial * fix * remove redundant language mod, use player sizes in video traff * test modify * fix * Adding Tests * add keywords param * log * log * log * fix * add idl * add idl * fix test * lint * lint * fix * lint * lint * lint * lint * add sync * fix Co-authored-by: Aigolkin1991 <Aigolkin1991@gmail.com> Co-authored-by: Aiholkin <artem.iholkin@smartyads.com> * Zeotap id plus gvlid (prebid#6260) * Add gvlid for ZeotapIdPlus module * Pass gvlid and module name to storage manager * add testcases to zeotapIdPlusIdSystem * remove unwanted code * adWMG adapter: add new parameter, fix minor bugs (prebid#6265) * Support floorCPM parameter, fix some minor bugs * fix space-in-parens circleci error * example fix * clean usersync URL * spaces * spaces * add new unit tests, compatibility with IE11 * remove logInfo Co-authored-by: Mikhail Dykun <m.dykun@wmgroup.us> * [ParrableIdSystem] Supply iframe state to backend (prebid#6278) * Add iframe detection * Remove forgotten .only Co-authored-by: Victor <victorigualada@gmail.com> * Bid Viewability Module (prebid#6206) * introducing a new event, bidViewable * new module: bidViewability * details in bidViewability.md * disable webdriver tests in trionBidAdapter spec (prebid#6280) * [ParrableIdSystem] Supply Prebid library version to backend (prebid#6279) * Add prebid version to data object * Renamed prebid to prebidVersion * Fix missing coma Co-authored-by: Victor <victorigualada@gmail.com> * [ParrableIdSystem] Accept list of partners as an array or string (prebid#6277) * Accept partners as an array and fallthrough partner if no partners * Ensure that Parrable data object decodes with urlsafe base64 in tests * Fixed tests caused by typo in config property * Fix failing test due to accessing unexisting property 'partner' Co-authored-by: Victor <victorigualada@gmail.com> * Rubicon Bid Adapter FPD Update (prebid#6122) * Update to consolidate applying FPD to both banner and video requests. FPD will be merged using global defined FPD, ad unit FPD, and rubicon bidder param FPD. Validation logic with warning logs added * Refectored last push to: 1) Correct keywords bug 2) Revise error which looked for FPD in (user/context).ext.data as opposed to (user/context).data 3) General code cleanup * Consolidated other FPD data logic into new function * 1. Update to move pbadslot and adserver data into imp[] as opposed to parent. 2. Update to convert keywords passed through RP params to string if array found * Removed unnecessary conditional * Changed conditional to check for undefined type * Update to consolidate several lines of duplicate code into one location * ID5 User Id Module: update a/b testing to be user based not request based (prebid#6281) * convert A/B testing to be user-based, rather than request-based * update docs to say a/b testing is user based, not request based * Shared ID gdpr support (prebid#6275) * SharedId gdpr support * Reverted commented locally failing tests * Lemma:set mediaType key value (prebid#6006) * lemmaBidAdapter.js Added lemma bid adapter file * lemmaBidAdapter.md Added lemma bid adapter md file * lemmaBidAdapter_spec.js Added lemma bid adapter test spec file * Update lemmaBidAdapter.js Fixed automated code review alert comparison between inconvertible types * Update lemmaBidAdapter.js Fixed review changes * Update lemmaBidAdapter.md Correct parameter value. * Update lemmaBidAdapter.js Lemma Bid Adapter - v3.0 compliance * Update lemmaBidAdapter_spec.js Lemma Bid Adapter - v3.0 compliance * Update lemmaBidAdapter.md Lemma Bid Adapter - v3.0 compliance * Update lemmaBidAdapter.js Added user sync support into bid adapter. * updated include modules file extension. updated include modules js file extension. * Update lemmaBidAdapter_spec.js Added unit test for user sync feature. * Update lemmaBidAdapter.js Fixed format error. * Update lemmaBidAdapter_spec.js Fixed format error and typo error. * Set mediaType key value into bid object Set mediaType key value into the bid object. * Update lemmaBidAdapter.js remove duplicate function * Update lemmaBidAdapter.js Remove non supported code. * Update lemmaBidAdapter_spec.js Remove GDPR test cases. * added support for addtlConsent (prebid#6005) Co-authored-by: Ix-Prebid-Support <ix-prebid-support@indexexchange.com> * Add bid adapter for Missena (prebid#6247) * adds support for getFloor of video mediaTypes * adds test for calling getFloor with correct mediaType * checks that _getFloor converts string floors to float * Add bid adapter for Missena * Use publisher demo token in tests * Add Missena global vendor ID to spec * Use apiKey in the current bidRequest * Add referer info to payload Co-authored-by: Nick Llerandi <nllerandi@triplelift.com> Co-authored-by: Brandon Ling <51931757+blingster7@users.noreply.github.com> Co-authored-by: Brandon Ling <bling@triplelift.com> * Gulp test file example added in readme (prebid#6287) * Sharethrough: Add support for ID5, Shared ID, and Live Intent ID (prebid#6261) * Update prebid adapter universal ids to include ID5, SharedID, and LiveIntent ID. [#176447070](https://www.pivotaltracker.com/story/show/176447070) Co-authored-by: Mathieu Pheulpin <mpheulpin@sharethrough.com> * Addressing review [#176447070] * Quick rewrite [#176447070] * Address ID5 review, forward linkType to adserver * Reformatting SharedID to align with ID5 Co-authored-by: Mathieu Pheulpin <mpheulpin@sharethrough.com> * SmartAdServer Bid Adapter: image sync and noAd (prebid#6236) * SIM-889 Now we have image based sync * SIM-889 Added test to check noad and image sync * SIM-889 Fixing indenting issues * Add client Alias Adkernel (prebid#6291) Adding "bcm" alias to Adkernel adapter * [ParrableIdSystem] Add GVLID and handle TC Consent data (prebid#6283) * Added GDPR support * Remove forgotten .only Co-authored-by: Victor <victorigualada@gmail.com> * 4.26.0 release * 4.27.0-pre * Updated data mapping of winning bid and auction logs in pubxai analytics adapter (prebid#6285) Co-authored-by: Phaneendra Hegde <phaneendra.hegde@gmail.com> * Grid Bid Adapter: Added video protocols to the ad request (prebid#6299) * Rubicon Bid Adapter: updated transactionId to auctionId for OpenRTB (prebid#6298) * Fix for Issue 6117: Added Module Name in Build to Comments (prebid#6297) * map tripleliftBidAdapter.js tl_source to bid.meta.mediaType (prebid#6303) * Tappx Bid Adapter: new bidder adapter added (prebid#6233) * ADD: tappx bid adapter * FIX: replace .includes by .indexOf * UPDATE: Expand the test coverage * FIX: format spacing tests * FIX: get auctionId from validBidRequests * UPDATE: add bannerMediaType tablet sizes * FIX: get timeout from bidderRequest.timeout * UPDATE: replace the way to get the hostname * UPDATE: adding support multiple bid requests in a single call * UPDATE: remove hardcoded test payload param Co-authored-by: marc_tappx <marc@tappx.com> * Add Native ad capability to AdYouLike adapter (prebid#6198) * Remove useless bidderCode in bid response * send all the available sizes in the bid request * Use the banner sizes if given * avoid compatibility issue with old bid format * ad iframe and publisher domain paramters to bid requests * add publisher domain info in ad request * add a check in unit tests for publisherDomain * encode uri components * add native assets support * add native information to ad request * fix native ad parsing * fix nativ condition to set mediatype * fix image access and add trackers * fix and add unit test on native ad * update md file * remove usage of URLSearchParams * allox pure native ad with no adm provided Co-authored-by: Guillaume <guiandouard@gmail.com> * Update targeting.js to fix TTL buffer arithmetic (prebid#6300) * Permutive RTD submodule (prebid#6290) * Add Permutive RTD module * set demo data in LS for test page * fix linter issues * reduce timeout on example page * decrease sample timeouts * rename targeting to segments * Adtelligent Bid Adapter: Add Navelix as alias (prebid#6306) * Navelix bidder * gvlID * Pubmatic add warning for non-string adSlots (prebid#6304) * add warning for non-string adSlots - and update the markdown file to say they should be strings * be more specific in explanatory comment * Update ttl outstream (prebid#6253) * adding DMX test @97%, two files added one updated * Update districtm_spec.js * Update districtmDMX.js * adding all districtm needed file * remove legacy file * remove typo || 0 in the test method * force default to return a valid width and height * update unit test code for failing test * changed class for an object * remove package-lock.json * change file name for dmx adapter * renamed files * restaure package-lock.json * update to last package-lock state * update gdpr user consent * fix sizes issue * Documentation updates Adding the readme.md info * update file name and update unit testing import file location * current machine state * lint correction * remove variable assigment duplicate * adding CCPA support for DMX * adding test for ccpa and gdpr * districtm dmx adding deal id field * idsync support ccpa & gdpr * merge forked * stop mediatype changing ttl * remove lint error * adding gvlid for dmx * removing change Removing change from on commit PR file package-lock.json * update file Removing comments on DMX adapter * Revert "removing change" This reverts commit e4bbbe5 * adding aliases base on ticket prebid#6294 * update file Removing comments on DMX adapter * fix error for issue prebid#6294 * file removal from PR Co-authored-by: Steve Alliance <steve@districtm.ca> Co-authored-by: Luis <luissastreverzun@gmail.com> Co-authored-by: Steve Alliance <stevealliance@Steves-Air.localdomain> Co-authored-by: Steve Alliance <stevealliance@Steves-MacBook-Air.local> Co-authored-by: steve-a-districtm <steve@districtm.net> Co-authored-by: Steve Alliance <stevealliance@DMMBP-C02WXCFAJG5H.local> * [ParrableIdSystem] Accept lowercase timezone names in timezone filter (prebid#6282) * Add lower case comparison for allowedZones * Lowercase blocked zones also * Fixed timezone lowercase tests * Handle IE missing timeZone field * Improve lowercase timezone comparison Co-authored-by: Victor <victorigualada@gmail.com> * Added new size - Id 550 (980x480) (prebid#6311) * Revert "Rubicon Bid Adapter: updated transactionId to auctionId for OpenRTB (prebid#6298)" (prebid#6314) This reverts commit f672209. * Rubicon: adding size 300x200 (prebid#6315) * added prebid version support to ixdiag (prebid#6292) * Extended ID permissions supported by bidder (prebid#6276) * User id bidder permission scheme * styling * prebidServer support * - * fix * prebidServerBidAdapter take eidPermissions directly from userId module * - * unit tests * - * - * update * - * - * changed pbjs_bidders to pbjsBidders * changed pbjsBidders to bidders ext.prebid.data.eidPermissions to ext.prebid.data.eidpermissions * rerun circleci * rerun circleci * omitting eidPermission entry if 'bidders' is not configured * fixed 'calling the PBS adapter without any defined userId modules causes an exception' * proposal * rerun circleci * utils implementation * comment * revert import validation Co-authored-by: myerkovich <myerkovich@rubiconproject.com> Co-authored-by: Marko Yerkovich <marko_yerkovich@MacBook-Pro-Marko.local> Co-authored-by: Marko Yerkovich <myerkovich@magnite.com> * new bid adapter: Logain (prebid#6312) Co-authored-by: Aiholkin <artem.iholkin@smartyads.com> * Change URL in Tapad Id Submodule (prebid#6318) * IndexExchange Bid Adapter: Added support for netID, ID+ and FabrickId userId (prebid#6286) * added more userID partner support for IX adapter - TDID, LI, NetID, Neustar, Zeotap * removed liveintent and adsrvr.org [DNA-5040] * updated neustar id * fixed fabrickid * frabrickId instead of id * added more userID partner support for IX adapter - NetID, Neustar, Zeotap (#1) * added more userID partner support for IX adapter - TDID, LI, NetID, Neustar, Zeotap * added tests * added tests for new userinfo modules * missed a few checks * Dna 5040 ix userid support (#2) * added more userID partner support for IX adapter - TDID, LI, NetID, Neustar, Zeotap * removed liveintent and adsrvr.org [DNA-5040] * updated neustar id * fixed fabrickid * frabrickId instead of id * added tests * added tests for new userinfo modules * missed a few checks Co-authored-by: Ran Li <ran.li@indexexchange.com> * added few missing checks in IX adapter * Use userIdAsEids instead of userId (#3) * use eids, revert package-lock * test update Co-authored-by: Ran Li <ran.li@indexexchange.com> Co-authored-by: amykwyang <amyyang90@gmail.com> * Prebid 4.27.0 Release * increment pre version * mediasquare fix userId (prebid#6321) * Change the EU consent string parameter name to the company-wide standard (prebid#6320) * adding support in pbsAdapter for getFloor (prebid#6273) * AdHash Bidder Adapter: initial prebid.js integration (prebid#6274) * PBJS Video Cache Update (prebid#6295) * Support bidder aliasing by not using bid.bidder to retrieve configs (which are static anyway) (prebid#6313) * Fabrick ID System : updates to _setReferrer and appending urls (prebid#6322) * fabrickId updates - encode all url params - dedupe w/out queryString and keep the longest - additionally truncate from % if that ends up being the last (or next to last) char after truncation - truncate 1k instead of 200 - don't send functions along in query (only send strings and numbers) * attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 - attempting to add debugging so I can know what exactly is failing in ie (since I don't have a windows machine) * found the issue having debugged locally - stubbing my error message is what killed me! * not the right way to loop through a map Co-authored-by: Anderson, Ben <Ben.Anderson@team.neustar> * Configureable option to delay auction event + fix bug with googletag init (prebid#6344) * Adhese Bid Adapter: replace id5 with eid (prebid#6339) * FID-287: Update Reconciliation RTD delivery id format (prebid#6343) * Inskin Bid Adapter: send screen size in the ad call (prebid#6316) * Ozone Bid Adapter: added or updated support for multiple modules (prebid#6324) * ozone 2.5.0 adapter updates * ozone 2.5.0 adapter - fixup for prebidCircleCI tests to remove object values on user.eid Co-authored-by: Afsheen Bigdeli <afsheenb@namecast.net> * Triplelift Bid Adapter: add PubCommon ID support (prebid#6352) * Prebid 4.28.0 Release * Increment pre version * GMOSSP Bid Adapter : add refererInfo from bidderRequest (prebid#6319) * Axonix Bid Adapter: add new bid adapter (prebid#6341) * Add Axonix bid adapter * Fixed tests * Documentation: Prebid Server and Postbid integration example ( ad server-less ) (prebid#6348) * Native: add custom data assets capability (prebid#6220) Use `mediaTypes.native.ext: {}` special object to add/allow custom data. assets. * iPROM adapter upload - adapter (prebid#6334) Co-authored-by: Gašper Žagar <gasper.zagar@iprom.si> * Ucfunnel Bid Adapter: update currency parameter in ad response (prebid#6357) * TheMediaGrid Bid Adapter: fix trouble with alias using (prebid#6363) * Rubicon Analytics Adapter: pass along advertiserDomains (prebid#6356) * Pass along advertiser domains! * only send up to 10 adomains * support setting coopSync in s2sConfig (prebid#6330) * TrustX Bid Adapter: Fix alias error (prebid#6373) * Adform Bid Adapter: add global targeting to the request query as parameter (prebid#6376) Co-authored-by: Justas <jpmiltas@gmail.com> * Prebid 4.29.0 Release Co-authored-by: robertrmartinez <rrmartinez1552@gmail.com> Co-authored-by: Liza Kobrazova <lizakobrazova@gmail.com> Co-authored-by: Steve Alliance <steve.alliance@gmail.com> Co-authored-by: bretg <bgorsline@gmail.com> Co-authored-by: Amanda Dillon <41923726+agdillon@users.noreply.github.com> Co-authored-by: YerkovichM <48519843+YerkovichM@users.noreply.github.com> Co-authored-by: myerkovich <myerkovich@rubiconproject.com> Co-authored-by: Marko Yerkovich <marko_yerkovich@MacBook-Pro-Marko.local> Co-authored-by: samuel-palmer-relevant-digital <77437973+samuel-palmer-relevant-digital@users.noreply.github.com> Co-authored-by: pm-shashank-jain <40654031+pm-shashank-jain@users.noreply.github.com> Co-authored-by: ardit-baloku <77985953+ardit-baloku@users.noreply.github.com> Co-authored-by: msm0504 <51493331+msm0504@users.noreply.github.com> Co-authored-by: Mark Monday <mmonday@rubiconproject.com> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Kotaro Shikata <lim.0.ctyl@gmail.com> Co-authored-by: mamatic <52153441+mamatic@users.noreply.github.com> Co-authored-by: Ian Flournoy <ian@parrable.com> Co-authored-by: Victor <victorigualada@gmail.com> Co-authored-by: Rich Audience <integrations@richaudience.com> Co-authored-by: sgimenez <sergi.gimenez@richaudience.com> Co-authored-by: mefjush <mefjush@gmail.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: harpere <ericsbiz@yahoo.com> Co-authored-by: Denis Logachov <denis@adkernel.com> Co-authored-by: Eric Harper <eharper@rubiconproject.com> Co-authored-by: Skylinar <53079123+Skylinar@users.noreply.github.com> Co-authored-by: smartclip AdTechnology <adtech@smartclip.com> Co-authored-by: Gino Cirlini <adtech@smartclip.tv> Co-authored-by: SKOCHERI <37454420+SKOCHERI@users.noreply.github.com> Co-authored-by: skocheri <skocheri@rubiconproject.com> Co-authored-by: Nepomuk Seiler <muuki88@users.noreply.github.com> Co-authored-by: Adprime <64427228+Adprime@users.noreply.github.com> Co-authored-by: Aigolkin1991 <Aigolkin1991@gmail.com> Co-authored-by: Aiholkin <artem.iholkin@smartyads.com> Co-authored-by: shikharsharma-zeotap <shikhar.sharma@zeotap.com> Co-authored-by: nyakove <43004249+nyakove@users.noreply.github.com> Co-authored-by: Mikhail Dykun <m.dykun@wmgroup.us> Co-authored-by: Ian Flournoy <ian@flournoy.us> Co-authored-by: Harshad Mane <harshad.mane@pubmatic.com> Co-authored-by: mmoschovas <63253416+mmoschovas@users.noreply.github.com> Co-authored-by: bjorn-lw <32431346+bjorn-lw@users.noreply.github.com> Co-authored-by: Lemma Dev <54662130+lemmadev@users.noreply.github.com> Co-authored-by: ix-certification <adapter-certification-eng@indexexchange.com> Co-authored-by: Ix-Prebid-Support <ix-prebid-support@indexexchange.com> Co-authored-by: Missena <78362128+dev-missena@users.noreply.github.com> Co-authored-by: Nick Llerandi <nllerandi@triplelift.com> Co-authored-by: Brandon Ling <51931757+blingster7@users.noreply.github.com> Co-authored-by: Brandon Ling <bling@triplelift.com> Co-authored-by: Pooja Pasawala <poojapasawala@gmail.com> Co-authored-by: Mathieu Pheulpin <mpheulpin@sharethrough.com> Co-authored-by: lowendavid <66423906+lowendavid@users.noreply.github.com> Co-authored-by: iskmerof <matt.foremski@gmail.com> Co-authored-by: Matt Kendall <1870166+mkendall07@users.noreply.github.com> Co-authored-by: pnh-pubx <73683023+pnh-pubx@users.noreply.github.com> Co-authored-by: Phaneendra Hegde <phaneendra.hegde@gmail.com> Co-authored-by: TheMediaGrid <44166371+TheMediaGrid@users.noreply.github.com> Co-authored-by: prebidtappx <77485538+prebidtappx@users.noreply.github.com> Co-authored-by: marc_tappx <marc@tappx.com> Co-authored-by: guiann <guillaume.andouard@adyoulike.com> Co-authored-by: Guillaume <guiandouard@gmail.com> Co-authored-by: David Reischer <reischer.david@gmail.com> Co-authored-by: Gena <wertixvost@gmail.com> Co-authored-by: jsut <adam.prime@wattpad.com> Co-authored-by: Steve Alliance <steve@districtm.ca> Co-authored-by: Luis <luissastreverzun@gmail.com> Co-authored-by: Steve Alliance <stevealliance@Steves-Air.localdomain> Co-authored-by: Steve Alliance <stevealliance@Steves-MacBook-Air.local> Co-authored-by: steve-a-districtm <steve@districtm.net> Co-authored-by: Steve Alliance <stevealliance@DMMBP-C02WXCFAJG5H.local> Co-authored-by: Thomas Skaarnes Nikitin <48713095+thomas-netric@users.noreply.github.com> Co-authored-by: lksharma <sharmak.love@gmail.com> Co-authored-by: Marko Yerkovich <myerkovich@magnite.com> Co-authored-by: WlsLogan <77974248+WlsLogan@users.noreply.github.com> Co-authored-by: Paweł Cejrowski <pcejrowski@gmail.com> Co-authored-by: li-ran <70167305+li-ran@users.noreply.github.com> Co-authored-by: Ran Li <ran.li@indexexchange.com> Co-authored-by: amykwyang <amyyang90@gmail.com> Co-authored-by: Jason Snellbaker <jsnellbaker@appnexus.com> Co-authored-by: matthieularere-msq <63732822+matthieularere-msq@users.noreply.github.com> Co-authored-by: Samuel Adu <samuel.adu@gmail.com> Co-authored-by: Damyan <wyand@abv.bg> Co-authored-by: Ben Anderson <benanderson@benanderson.us> Co-authored-by: Anderson, Ben <Ben.Anderson@team.neustar> Co-authored-by: Vladimir Fedoseev <vl.fedoseev@gmail.com> Co-authored-by: afsheenb <afsheenb@users.noreply.github.com> Co-authored-by: Afsheen Bigdeli <afsheenb@namecast.net> Co-authored-by: nllerandi3lift <75995508+nllerandi3lift@users.noreply.github.com> Co-authored-by: Mike Chowla <mike.chowla@pubmatic.com> Co-authored-by: KazuakiM <kazuaki_mabuchi_to_go@hotmail.co.jp> Co-authored-by: César Fernández <cfalonso@gmail.com> Co-authored-by: ysfbsf <youssef.bsf@gmail.com> Co-authored-by: Olivier <osazos@adagio.io> Co-authored-by: iprom-adserver <79305981+iprom-adserver@users.noreply.github.com> Co-authored-by: Gašper Žagar <gasper.zagar@iprom.si> Co-authored-by: jackhsiehucf <77815341+jackhsiehucf@users.noreply.github.com> Co-authored-by: PWyrembak <paul@trustx.org> Co-authored-by: Justas Pupelis <pupelis.justas@gmail.com> Co-authored-by: Justas <jpmiltas@gmail.com> Co-authored-by: Alex Cook <alexcook@Alexs-MacBook-Pro.local>

@97

* Increment pre version * Fix astraoneBidAdapter (prebid#6230) * Fix astraoneBidAdapter * Fix examples; update astraoneBidAdapter description * Fix astraoneBidAdapter_spec * Remove integration examples * Rename gbt to gpt * update banner ttl (prebid#6228) * browsi: updating test parameters (prebid#6048) * SpotX Bid Adapter: default to 4/3 aspect ratio when response doesn't contain w or h (prebid#6159) * Default to 4/3 aspect ratio when response doesn't contain w or h * SpotX bid adapter: reorder tests and remove extra assertions * Extended ID permissions supported by bidder (prebid#6112) * User id bidder permission scheme * styling * prebidServer support * - * fix * prebidServerBidAdapter take eidPermissions directly from userId module * - * unit tests * - * - * update * - * - * changed pbjs_bidders to pbjsBidders * changed pbjsBidders to bidders ext.prebid.data.eidPermissions to ext.prebid.data.eidpermissions * rerun circleci * rerun circleci * omitting eidPermission entry if 'bidders' is not configured Co-authored-by: myerkovich <myerkovich@rubiconproject.com> Co-authored-by: Marko Yerkovich <marko_yerkovich@MacBook-Pro-Marko.local> * Relevant Yield analytics adapter (prebid#6195) * Pubmatic: fix issue where using an adUnit outstream renderer throws an error (prebid#6152) * Malltv Bid Adapter : added data object as a param (prebid#6232) * Updated malltv adapter * Updated markdown * Added test for malltvBidAdapter * support setting coopSync in s2sConfig (prebid#6213) Co-authored-by: Mark Monday <mmonday@rubiconproject.com> * Revert "support setting coopSync in s2sConfig (prebid#6213)" (prebid#6249) This reverts commit 25dd35c. * pbsBidAdapter: change order of client syncs (prebid#6248) * pbsBidAdapter: change order cookie_syncs Prebid Server places cookie-sync URLs in a specific order. PBJS was pulling them off in reverse order. * moving comment * reverting coopSync * pass a flag back to ID5 servers if abTesting was enabled by the publisher for monitoring usage of the feature (prebid#6170) * appneuxs Bid Adapter - add support for identitylink userId (prebid#6245) * Update britepoolIdSystem.md (prebid#6254) Eliot from Britepool says you can set just the api key without any params (eg ssid or hash) * UNICORN Adapter - accept multiple formats (prebid#6255) * enable multiple formats add version * add banner w/h * fix w/h & spec * ATS-analytics - add comment clarifying ownership of atsAnalytics (prebid#6257) * [ParrableIdSystem] Ensure base64 payload is url-safe (prebid#6258) * Added url safe base64 encoding * Added url safe base64 encoding test Co-authored-by: Victor <victorigualada@gmail.com> * Keywords + Screen resolution + CPU Core (prebid#6259) Co-authored-by: sgimenez <sergi.gimenez@richaudience.com> * Rubicon Analytics: Fire event once gptSlots render (prebid#6241) * Once all gam slots are back fire event * push to cmd queue * New dimension for tracking name of the matching adUnit pattern (prebid#6252) * Adhese Bid Adapter: Per adunit targets (prebid#6256) * adpod category support test * Revert "adpod category support test" * Gjirafa Bid Adapter: added data object as a param (prebid#6231) * Added data parameter to gjirafaBidAdapter * Updated gjirafaBidAdapter markdown * Added test for gjirafaBidAdapter * Fix a TypeError when message event source is not available (prebid#6224) * fix broken tests due to "encoded" base64 logic (prebid#6268) * Adkernel Bid Adapter: stringads alias added (prebid#6262) * Adkernel: stringads alias * Revert "Extended ID permissions supported by bidder (prebid#6112)" (prebid#6269) This reverts commit a926dee. * Prebid 4.25.0 Release * Increment pre version * smartxBidAdapter: new Feature - Made Out-Stream Player configurable (prebid#6239) * Add smartclipBidAdapter * smartxBidAdapter.js - removed unused variables, removed debug, added window before the outstream related functions * - made outstream player configurable * remove wrong named files * camelcase * fix Co-authored-by: smartclip AdTechnology <adtech@smartclip.com> Co-authored-by: Gino Cirlini <adtech@smartclip.tv> * Idl1 (prebid#6242) * Renaming idLibrary to idImportLibrary * Renaming idLibrary to idImportLibrary Co-authored-by: skocheri <skocheri@rubiconproject.com> * Add the trade desk gvlid (prebid#6263) UnifiedId only works with a vendor exception in the gdpr enforcement module. However this is not okay as the unifiedId matching endpoint doesn't take the consent into account and cookies are being dropped even without consent. * pick up wrapper family detail (prebid#6272) * Add user sync (prebid#6244) * initial * fix * remove redundant language mod, use player sizes in video traff * test modify * fix * Adding Tests * add keywords param * log * log * log * fix * add idl * add idl * fix test * lint * lint * fix * lint * lint * lint * lint * add sync * fix Co-authored-by: Aigolkin1991 <Aigolkin1991@gmail.com> Co-authored-by: Aiholkin <artem.iholkin@smartyads.com> * Zeotap id plus gvlid (prebid#6260) * Add gvlid for ZeotapIdPlus module * Pass gvlid and module name to storage manager * add testcases to zeotapIdPlusIdSystem * remove unwanted code * adWMG adapter: add new parameter, fix minor bugs (prebid#6265) * Support floorCPM parameter, fix some minor bugs * fix space-in-parens circleci error * example fix * clean usersync URL * spaces * spaces * add new unit tests, compatibility with IE11 * remove logInfo Co-authored-by: Mikhail Dykun <m.dykun@wmgroup.us> * [ParrableIdSystem] Supply iframe state to backend (prebid#6278) * Add iframe detection * Remove forgotten .only Co-authored-by: Victor <victorigualada@gmail.com> * Bid Viewability Module (prebid#6206) * introducing a new event, bidViewable * new module: bidViewability * details in bidViewability.md * disable webdriver tests in trionBidAdapter spec (prebid#6280) * [ParrableIdSystem] Supply Prebid library version to backend (prebid#6279) * Add prebid version to data object * Renamed prebid to prebidVersion * Fix missing coma Co-authored-by: Victor <victorigualada@gmail.com> * [ParrableIdSystem] Accept list of partners as an array or string (prebid#6277) * Accept partners as an array and fallthrough partner if no partners * Ensure that Parrable data object decodes with urlsafe base64 in tests * Fixed tests caused by typo in config property * Fix failing test due to accessing unexisting property 'partner' Co-authored-by: Victor <victorigualada@gmail.com> * Rubicon Bid Adapter FPD Update (prebid#6122) * Update to consolidate applying FPD to both banner and video requests. FPD will be merged using global defined FPD, ad unit FPD, and rubicon bidder param FPD. Validation logic with warning logs added * Refectored last push to: 1) Correct keywords bug 2) Revise error which looked for FPD in (user/context).ext.data as opposed to (user/context).data 3) General code cleanup * Consolidated other FPD data logic into new function * 1. Update to move pbadslot and adserver data into imp[] as opposed to parent. 2. Update to convert keywords passed through RP params to string if array found * Removed unnecessary conditional * Changed conditional to check for undefined type * Update to consolidate several lines of duplicate code into one location * ID5 User Id Module: update a/b testing to be user based not request based (prebid#6281) * convert A/B testing to be user-based, rather than request-based * update docs to say a/b testing is user based, not request based * Shared ID gdpr support (prebid#6275) * SharedId gdpr support * Reverted commented locally failing tests * Lemma:set mediaType key value (prebid#6006) * lemmaBidAdapter.js Added lemma bid adapter file * lemmaBidAdapter.md Added lemma bid adapter md file * lemmaBidAdapter_spec.js Added lemma bid adapter test spec file * Update lemmaBidAdapter.js Fixed automated code review alert comparison between inconvertible types * Update lemmaBidAdapter.js Fixed review changes * Update lemmaBidAdapter.md Correct parameter value. * Update lemmaBidAdapter.js Lemma Bid Adapter - v3.0 compliance * Update lemmaBidAdapter_spec.js Lemma Bid Adapter - v3.0 compliance * Update lemmaBidAdapter.md Lemma Bid Adapter - v3.0 compliance * Update lemmaBidAdapter.js Added user sync support into bid adapter. * updated include modules file extension. updated include modules js file extension. * Update lemmaBidAdapter_spec.js Added unit test for user sync feature. * Update lemmaBidAdapter.js Fixed format error. * Update lemmaBidAdapter_spec.js Fixed format error and typo error. * Set mediaType key value into bid object Set mediaType key value into the bid object. * Update lemmaBidAdapter.js remove duplicate function * Update lemmaBidAdapter.js Remove non supported code. * Update lemmaBidAdapter_spec.js Remove GDPR test cases. * added support for addtlConsent (prebid#6005) Co-authored-by: Ix-Prebid-Support <ix-prebid-support@indexexchange.com> * Add bid adapter for Missena (prebid#6247) * adds support for getFloor of video mediaTypes * adds test for calling getFloor with correct mediaType * checks that _getFloor converts string floors to float * Add bid adapter for Missena * Use publisher demo token in tests * Add Missena global vendor ID to spec * Use apiKey in the current bidRequest * Add referer info to payload Co-authored-by: Nick Llerandi <nllerandi@triplelift.com> Co-authored-by: Brandon Ling <51931757+blingster7@users.noreply.github.com> Co-authored-by: Brandon Ling <bling@triplelift.com> * Gulp test file example added in readme (prebid#6287) * Sharethrough: Add support for ID5, Shared ID, and Live Intent ID (prebid#6261) * Update prebid adapter universal ids to include ID5, SharedID, and LiveIntent ID. [#176447070](https://www.pivotaltracker.com/story/show/176447070) Co-authored-by: Mathieu Pheulpin <mpheulpin@sharethrough.com> * Addressing review [#176447070] * Quick rewrite [#176447070] * Address ID5 review, forward linkType to adserver * Reformatting SharedID to align with ID5 Co-authored-by: Mathieu Pheulpin <mpheulpin@sharethrough.com> * SmartAdServer Bid Adapter: image sync and noAd (prebid#6236) * SIM-889 Now we have image based sync * SIM-889 Added test to check noad and image sync * SIM-889 Fixing indenting issues * Add client Alias Adkernel (prebid#6291) Adding "bcm" alias to Adkernel adapter * [ParrableIdSystem] Add GVLID and handle TC Consent data (prebid#6283) * Added GDPR support * Remove forgotten .only Co-authored-by: Victor <victorigualada@gmail.com> * 4.26.0 release * 4.27.0-pre * Updated data mapping of winning bid and auction logs in pubxai analytics adapter (prebid#6285) Co-authored-by: Phaneendra Hegde <phaneendra.hegde@gmail.com> * Grid Bid Adapter: Added video protocols to the ad request (prebid#6299) * Rubicon Bid Adapter: updated transactionId to auctionId for OpenRTB (prebid#6298) * Fix for Issue 6117: Added Module Name in Build to Comments (prebid#6297) * map tripleliftBidAdapter.js tl_source to bid.meta.mediaType (prebid#6303) * Tappx Bid Adapter: new bidder adapter added (prebid#6233) * ADD: tappx bid adapter * FIX: replace .includes by .indexOf * UPDATE: Expand the test coverage * FIX: format spacing tests * FIX: get auctionId from validBidRequests * UPDATE: add bannerMediaType tablet sizes * FIX: get timeout from bidderRequest.timeout * UPDATE: replace the way to get the hostname * UPDATE: adding support multiple bid requests in a single call * UPDATE: remove hardcoded test payload param Co-authored-by: marc_tappx <marc@tappx.com> * Add Native ad capability to AdYouLike adapter (prebid#6198) * Remove useless bidderCode in bid response * send all the available sizes in the bid request * Use the banner sizes if given * avoid compatibility issue with old bid format * ad iframe and publisher domain paramters to bid requests * add publisher domain info in ad request * add a check in unit tests for publisherDomain * encode uri components * add native assets support * add native information to ad request * fix native ad parsing * fix nativ condition to set mediatype * fix image access and add trackers * fix and add unit test on native ad * update md file * remove usage of URLSearchParams * allox pure native ad with no adm provided Co-authored-by: Guillaume <guiandouard@gmail.com> * Update targeting.js to fix TTL buffer arithmetic (prebid#6300) * Permutive RTD submodule (prebid#6290) * Add Permutive RTD module * set demo data in LS for test page * fix linter issues * reduce timeout on example page * decrease sample timeouts * rename targeting to segments * Adtelligent Bid Adapter: Add Navelix as alias (prebid#6306) * Navelix bidder * gvlID * Pubmatic add warning for non-string adSlots (prebid#6304) * add warning for non-string adSlots - and update the markdown file to say they should be strings * be more specific in explanatory comment * Update ttl outstream (prebid#6253) * adding DMX test @97%, two files added one updated * Update districtm_spec.js * Update districtmDMX.js * adding all districtm needed file * remove legacy file * remove typo || 0 in the test method * force default to return a valid width and height * update unit test code for failing test * changed class for an object * remove package-lock.json * change file name for dmx adapter * renamed files * restaure package-lock.json * update to last package-lock state * update gdpr user consent * fix sizes issue * Documentation updates Adding the readme.md info * update file name and update unit testing import file location * current machine state * lint correction * remove variable assigment duplicate * adding CCPA support for DMX * adding test for ccpa and gdpr * districtm dmx adding deal id field * idsync support ccpa & gdpr * merge forked * stop mediatype changing ttl * remove lint error * adding gvlid for dmx * removing change Removing change from on commit PR file package-lock.json * update file Removing comments on DMX adapter * Revert "removing change" This reverts commit e4bbbe5 * adding aliases base on ticket prebid#6294 * update file Removing comments on DMX adapter * fix error for issue prebid#6294 * file removal from PR Co-authored-by: Steve Alliance <steve@districtm.ca> Co-authored-by: Luis <luissastreverzun@gmail.com> Co-authored-by: Steve Alliance <stevealliance@Steves-Air.localdomain> Co-authored-by: Steve Alliance <stevealliance@Steves-MacBook-Air.local> Co-authored-by: steve-a-districtm <steve@districtm.net> Co-authored-by: Steve Alliance <stevealliance@DMMBP-C02WXCFAJG5H.local> * [ParrableIdSystem] Accept lowercase timezone names in timezone filter (prebid#6282) * Add lower case comparison for allowedZones * Lowercase blocked zones also * Fixed timezone lowercase tests * Handle IE missing timeZone field * Improve lowercase timezone comparison Co-authored-by: Victor <victorigualada@gmail.com> * Added new size - Id 550 (980x480) (prebid#6311) * Revert "Rubicon Bid Adapter: updated transactionId to auctionId for OpenRTB (prebid#6298)" (prebid#6314) This reverts commit f672209. * Rubicon: adding size 300x200 (prebid#6315) * added prebid version support to ixdiag (prebid#6292) * Extended ID permissions supported by bidder (prebid#6276) * User id bidder permission scheme * styling * prebidServer support * - * fix * prebidServerBidAdapter take eidPermissions directly from userId module * - * unit tests * - * - * update * - * - * changed pbjs_bidders to pbjsBidders * changed pbjsBidders to bidders ext.prebid.data.eidPermissions to ext.prebid.data.eidpermissions * rerun circleci * rerun circleci * omitting eidPermission entry if 'bidders' is not configured * fixed 'calling the PBS adapter without any defined userId modules causes an exception' * proposal * rerun circleci * utils implementation * comment * revert import validation Co-authored-by: myerkovich <myerkovich@rubiconproject.com> Co-authored-by: Marko Yerkovich <marko_yerkovich@MacBook-Pro-Marko.local> Co-authored-by: Marko Yerkovich <myerkovich@magnite.com> * new bid adapter: Logain (prebid#6312) Co-authored-by: Aiholkin <artem.iholkin@smartyads.com> * Change URL in Tapad Id Submodule (prebid#6318) * IndexExchange Bid Adapter: Added support for netID, ID+ and FabrickId userId (prebid#6286) * added more userID partner support for IX adapter - TDID, LI, NetID, Neustar, Zeotap * removed liveintent and adsrvr.org [DNA-5040] * updated neustar id * fixed fabrickid * frabrickId instead of id * added more userID partner support for IX adapter - NetID, Neustar, Zeotap (#1) * added more userID partner support for IX adapter - TDID, LI, NetID, Neustar, Zeotap * added tests * added tests for new userinfo modules * missed a few checks * Dna 5040 ix userid support (#2) * added more userID partner support for IX adapter - TDID, LI, NetID, Neustar, Zeotap * removed liveintent and adsrvr.org [DNA-5040] * updated neustar id * fixed fabrickid * frabrickId instead of id * added tests * added tests for new userinfo modules * missed a few checks Co-authored-by: Ran Li <ran.li@indexexchange.com> * added few missing checks in IX adapter * Use userIdAsEids instead of userId (#3) * use eids, revert package-lock * test update Co-authored-by: Ran Li <ran.li@indexexchange.com> Co-authored-by: amykwyang <amyyang90@gmail.com> * Prebid 4.27.0 Release * increment pre version * mediasquare fix userId (prebid#6321) * Change the EU consent string parameter name to the company-wide standard (prebid#6320) * adding support in pbsAdapter for getFloor (prebid#6273) * AdHash Bidder Adapter: initial prebid.js integration (prebid#6274) * PBJS Video Cache Update (prebid#6295) * Support bidder aliasing by not using bid.bidder to retrieve configs (which are static anyway) (prebid#6313) * Fabrick ID System : updates to _setReferrer and appending urls (prebid#6322) * fabrickId updates - encode all url params - dedupe w/out queryString and keep the longest - additionally truncate from % if that ends up being the last (or next to last) char after truncation - truncate 1k instead of 200 - don't send functions along in query (only send strings and numbers) * attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 - attempting to add debugging so I can know what exactly is failing in ie (since I don't have a windows machine) * found the issue having debugged locally - stubbing my error message is what killed me! * not the right way to loop through a map Co-authored-by: Anderson, Ben <Ben.Anderson@team.neustar> * Configureable option to delay auction event + fix bug with googletag init (prebid#6344) * Adhese Bid Adapter: replace id5 with eid (prebid#6339) * FID-287: Update Reconciliation RTD delivery id format (prebid#6343) * Inskin Bid Adapter: send screen size in the ad call (prebid#6316) * Ozone Bid Adapter: added or updated support for multiple modules (prebid#6324) * ozone 2.5.0 adapter updates * ozone 2.5.0 adapter - fixup for prebidCircleCI tests to remove object values on user.eid Co-authored-by: Afsheen Bigdeli <afsheenb@namecast.net> * Triplelift Bid Adapter: add PubCommon ID support (prebid#6352) * Prebid 4.28.0 Release * Increment pre version * GMOSSP Bid Adapter : add refererInfo from bidderRequest (prebid#6319) * Axonix Bid Adapter: add new bid adapter (prebid#6341) * Add Axonix bid adapter * Fixed tests * Documentation: Prebid Server and Postbid integration example ( ad server-less ) (prebid#6348) * Native: add custom data assets capability (prebid#6220) Use `mediaTypes.native.ext: {}` special object to add/allow custom data. assets. * iPROM adapter upload - adapter (prebid#6334) Co-authored-by: Gašper Žagar <gasper.zagar@iprom.si> * Ucfunnel Bid Adapter: update currency parameter in ad response (prebid#6357) * TheMediaGrid Bid Adapter: fix trouble with alias using (prebid#6363) * Rubicon Analytics Adapter: pass along advertiserDomains (prebid#6356) * Pass along advertiser domains! * only send up to 10 adomains * support setting coopSync in s2sConfig (prebid#6330) * TrustX Bid Adapter: Fix alias error (prebid#6373) * Adform Bid Adapter: add global targeting to the request query as parameter (prebid#6376) Co-authored-by: Justas <jpmiltas@gmail.com> * Prebid 4.29.0 Release * Increment pre version * Gamoshi Bid Adapter: update adaptor aliases (prebid#6355) * Marsmedia Bid Adapter: add support for viewability, floor price module, COPPA & CCPA (prebid#6337) * Change publisherId to zoneId Add gdpr Add supply chain Add video media type * Remove comments * Fix unit test coverage * fix request id bug add vastXml to video response * Remove bid response default sizes * Change endpoint url * Add unit test for vastXml * Change end point * Remove trailing-space * Add onBidWon function * New adapter - videofy * Marsmedia & Videofy - Add onTimeout onSetTargeting * Create sendbeacon function * - add viewability * remove unnecessary utils.getWindowTop() * fix bidderRequest matching for finding a renderer (prebid#6359) * Seedtag Bid Adapter: add support for inArticle placement (prebid#6369) * Fix: check mandatory video params * Simplifying mediaType video existence check * SQDTAR-42: onWonBid event (#2) * Adding onBidWon handler. * Adding nurl to bid. * Adding nurl field to bid. * Adding inArticle placement type to seedtag adapter. (#1) Co-authored-by: Carlos Barreiro Mata <barreymata@gmail.com> * improve robustness on OnEvent fields (prebid#6384) * oneVideo Bid Adapter: remove adapter adId because of conflict with pbjs core (prebid#6382) * updated object,str,num validations using pbjs utils * validation if statements for content object * validation if statements for content object * updated contetn object validations using utils * refractoring clean if statement * fixing typos * added todos * added category string & data object validations * fixed esling ENDPOINT issue * updated content obj unit tests * fixed cat & data validation * fixed producer as object * revert .includes() to .indexof() for IE * reduced content obj params accoriding to ad-server support * fixed typeOf typo * fixed episode to Number * gitignore * restore gitignore * removed unsupported params from md file * reverted package & pagkage-lock * fixed incorrect episdoe from str to num * removed bid.adid setting from L97 * removed bid.adId setting * updated adId test * updated version to 3.0.6 * PBS Bid Adapter: add dchain (demand chain object) to prebid server adapter (prebid#6383) * Update prebidServerBidAdapter_spec.js * Update index.js * Gulp Build: fix to populate modules list when gulp bundle is executed (prebid#6331) * added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * need to update modules list when gulp bundle is called * added a comment * Smartx Bid Adapter: updated out-stream render to support smartPlay 5.2 (prebid#6370) * Add smartclipBidAdapter * smartxBidAdapter.js - removed unused variables, removed debug, added window before the outstream related functions * - made outstream player configurable * remove wrong named files * camelcase * fix * Out-Stream render update to SmartPlay 5.2 * ESlint fix * ESlint fix * ESlint fix * adjust tests, fixes * ESlint Co-authored-by: smartclip AdTechnology <adtech@smartclip.com> Co-authored-by: Gino Cirlini <adtech@smartclip.tv> * Fpd 2.0 Update (prebid#6293) * Update to consolidate applying FPD to both banner and video requests. FPD will be merged using global defined FPD, ad unit FPD, and rubicon bidder param FPD. Validation logic with warning logs added * Refectored last push to: 1) Correct keywords bug 2) Revise error which looked for FPD in (user/context).ext.data as opposed to (user/context).data 3) General code cleanup * Consolidated other FPD data logic into new function * 1. Update to move pbadslot and adserver data into imp[] as opposed to parent. 2. Update to convert keywords passed through RP params to string if array found * Removed unnecessary conditional * Changed conditional to check for undefined type * FPD 2.0 Update 1) The setConfig and setBidderConfig functions support a transition period where they map the original 'fpd' config: - fpd.context.ATTR --> ortb2.site.ATTR - fpd.context.data.ATTR --> ortb2.site.ext.data - fpd.user.ATTR --> ortb2.user.ATTR - fpd.user.data.ATTR --> ortb2.user.ext.data 2) gptPreAuction: a) move adunit.fpd to adunit.ortb2 b) adUnit.ortb2Imp.ext.data.adserver.{name, adSlot} c) pbAdSlot moves to AdUnit.ortb2Imp.ext.data.pbAdSlot 3) pbsBidAdapter a) merge the new ortb2 and AdUnit.ortb2Imp.ext objects into the OpenRTB JSON. b) therefore imp[].ext.context.data.pbadslot is now changed to imp[].ext.data.pbadslot (no context) c) read adUnit.ortb2Imp.ext.data.adserver from the new location. Output location is moved to imp[].ext.data.adserver (no context) * FPD 2.0 Update Update to adrelevantis adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to amx adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to avocet adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to criteo adapter to look at config.ortb2 instead of config.fpd * Update to correct imp fpd structure * Update to s2s adapter to coincide with imp fpd alteration * Update to consolidate several lines of duplicate code into one location * Slight modification for ortb2Imp to use ortb2Imp.ext as opposed to ortb2Imp.ext.data * FPD 2.0 Update Update to grid adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to inmar adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to luponmedia adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to smaato adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to triplelift adapter to look at config.ortb2 instead of config.fpd * Update to gptPreAuction to move over to imp level ortb2 * FPD 2.0 Update Update to triplelift adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update * FPD 2.0 Update Update to jwplayerRtd adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to admixer adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to rubicon adapter to look at config.ortb2 instead of config.fpd * Update to fix keyword bug * Added backwards compatibility functions for FPD both global/bidder and adunit level data * Update to utilize new backward functionality for fpd 2.0 * Removed extra new line * Update to include new backward functionality for FPD 2.0 data * Update to utilize new backward functionality to pass FPD 2.0 data * Update to utilize backward functionality to pass FPD 2.0 data * Update to utilize backward functionality to pass FPD 2.0 data * Update to utilize backward functionality to pass FPD 2.0 data * Update to utilize backward functionality to pass FPD 2.0 data * Update to utilize backward functionality to pass FPD 2.0 data * Fixed typo in fpd config object location * Uodate to utilize backward functionality to pass FPD 2.0 data * Update to change all ortb2Imp.ext.data.adserver.adSlot references to ortb2Imp.ext.data.adserver.adslot - all lowercase. Corresponding adapter and unit tests to adhere to these changes * Fixed typo * Fixed typo * FPD 2.0 update to rubicon adapter to pass iab values * Updates: 1) Change function name 2) addAdUnits always pass array 3) Remove unecessary comment 4) Bug fix for ortb2.user.data to be filtered on legacy fpd conversion * PBS Bid Adapter: fix s2s alias collision with built-in adapter aliasing (prebid#6379) * fixed overwriting of aliases for s2s * made change * added fix * Clean side-effect when checking that local storage is enabled (prebid#6323) * updates docs and demo for fpd changes (prebid#6302) Co-authored-by: karimJWP <karimJWP@github.com> * Changed net revenue to True (prebid#6387) * adagioBidAdapter: add Native support (prebid#6368) * EIDS Support Update (prebid#6394) * TheMediaGridNM Bid Adapter: fix trouble with alias (prebid#6371) * Added TheMediaGridNM Bid Adapter * Updated required params for TheMediaGridNM Bid Adapter * Update TheMediGridNM Bid Adapter * Fix tests for TheMediaGridNM Bid Adapter * Fixes after review for TheMediaGridNM Bid Adapter * Add support of multi-format in TheMediaGrid Bid Adapter * Update sync url for grid and gridNM Bid Adapters * TheMediaGrid Bid Adapter: added keywords adUnit parameter * Update TheMediaGrid Bid Adapter to support keywords from config * Implement new request format for TheMediaGrid Bid Adapter * Fix jwpseg params for TheMediaGrid Bid Adapter * Update unit tests for The Media Grid Bid Adapter * Fix typo in TheMediaGrid Bid Adapter * Added test for jwTargeting in TheMediaGrid Bid Adapter * The new request format was made by default in TheMediaGrid Bid Adapter * Update userId format in ad request for TheMediaGrid Bid Adapter * Added bidFloor parameter for TheMediaGrid Bid Adapter * Fix for review TheMediaGrid Bid Adapter * Support floorModule in TheMediaGrid Bid Adapter * Fix empty bidfloor for TheMediaGrid Bid Adapter * Some change to restart autotests * Fix userIds format for TheMediaGrid Bid Adapter * Remove digitrust userId from TheMediaGrid Bid Adapter * Protocols was added in video section in ad request for TheMediaGrid Bid Adapter * TheMediaGrid: fix trouble with alias using * TheMediaGridNM: fix trouble with alias * Grab sourceAgnostic IDs first, then fallback to regular IDs (prebid#6400) * Permutive - add AC support for TrustX (prebid#6393) * SmartRTB Bid Adapter: add alias and update valid opts (prebid#6365) * Add alias, update valid opts * Update bidder tests * Prebid 4.30.0 Release * Increment pre version * Sonobi Bid Adapter: send eids in bid request. (prebid#6364) * unwrapping id5id uid. Added new eid param for user id modules * set userid to new variable * fixed spelling mistake in unit test Co-authored-by: Scott Menzer <smenzer@gmail.com> * copying userid object so the referenced object does not get updated. * using deepClone instead of spreading the top userId object Co-authored-by: Scott Menzer <smenzer@gmail.com> * Apacdex Bid Adapter: userId module support, show demo ads in debug mode & other maintenance (prebid#6378) * Upgrade and maintenance apacdexBidAdapter * fix error and add unit test * Novatiq ID System: add snowflake userId submodule (prebid#6350) * Novatiq snowflake userId submodule Novatiq snowflake userId submodule initial release * change request updates added novatiq info /modules/userId/userId.md added novatiq info /modules/userId/eids.md added novatiq eids /modules/userId/eids.js added novatiq module in /modules/.submodules.json removed unnecessary value from getId response * Update novatiqIdSystem_spec.js removed unnecessary srcid value * Update novatiqIdSystem.md Novatiq ID System: updated novatiq snowflake ID description * Rise Bid Adapter: add session_id & is_wrapper params to adapter (prebid#6407) * add new params to rise adapter * add unit tests for isWrapper and sessionId adapter params * IronSource Bid Adapter: add session_id & is_wrapper params to adapter (prebid#6408) * add new params * add unit tests for isWrapper and sessionId adapter params * AMX Bid Adapter: add or update general adapter support and code refactoring (prebid#6403) * AMX Bid adapter improvements * fix eslint issues (breaking CI) * VOX Bid adapter, Hybrid Bid adapter: fix global var name to avoid conflicts with astraOne adapter. (prebid#6416) Co-authored-by: Petrov Denis <d.petrov@hybrid.ai> * LiveIntent Id System: fix for parsing response twice (prebid#6418) * Don't parse response twice in LiveIntent Id submodule * Update the liveintent module test to have the 204 response * PBJS Core: use mediaType renderer when backupOnly and no bid.renderer (prebid#6419) * use mediaType renderer when backupOnly and no bid.renderer * check if necessary renderer properties are defined * GumGum Bid Adapter: pass bidfloor currency in bidrequest (prebid#6391) * adds support for zone and pubId params * adds support for iriscat field * sets mediatype depending on product id * Update doc for mediaType needed for video products * makes slot and invideo products avail for pubId * updates gumgum doc * lint * adds missing comma in gumgum doc * adds currency in ad request, adds unit test * readd the previous irisid changes * remove the only in testing * Documentation: fixed a typo and sentence structure (prebid#6421) * Bid Glass Bid Adapter: pass options in bid request (prebid#6424) * Added bidglass adapter + test * PR Review Updates: - Added formal params to getUserSyncs function definition - getUserSyncs now always returns an array - Improved unit test coverage * PR Review Updates: - Removed unused methods: getUserSyncs, onTimeout, onBidWon, onSetTargeting - Removed getUserSyncs unit test - Removed "dead code" - Removed some unnecessary comments - Fixed usage of parseInt * Bid Glass Bid Adapter: pass options in bid request * Spotx Bid Adapter: add publisher support for cache.ignoreBidderCacheKey (prebid#6413) * Support ignoreBidderCacheKey in spotxBidAdapter * Update spotxBidAdapter_spec.js * Update spotxBidAdapter_spec.js Co-authored-by: Nick Peceniak <npeceniak@spotx.tv> * update prebid adapter. Add at, ccpa, gdpr and coppa support (prebid#6405) * Qwarry Bid Adapter: add referer detection (prebid#6412) * qwarry bid adapter * formatting fixes * fix tests for qwarry * qwarry bid adapter * add header for qwarry bid adapter * bid requests fix * fix tests * response fix * fix tests for Qwarry bid adapter * add pos parameter to qwarry bid adapter * qwarryBidAdapter onBidWon hotfix * Change bidder endpoint url for Qwarry adapter * add referer JS detection * use bidderRequest.refererInfo * fix tests Co-authored-by: Artem Kostritsa <akostritsa@akostritsa.com> Co-authored-by: Alexander Kascheev <akascheev@asteriosoft.com> * Smartyads Bid Adapter: add coppa field from config (prebid#6402) * update adapter. Add coppa field from config * move stubs and restores for coppa tests * PBS Bid Adapter: Fpd2.0 bug fix for first party data issue (prebid#6428) * Bug fix for PBS data from FPD2.0 update: Merging request.site and request.user with site and user object in FPD. * Prebid 4.31.0 Release Co-authored-by: robertrmartinez <rrmartinez1552@gmail.com> Co-authored-by: Liza Kobrazova <lizakobrazova@gmail.com> Co-authored-by: Steve Alliance <steve.alliance@gmail.com> Co-authored-by: bretg <bgorsline@gmail.com> Co-authored-by: Amanda Dillon <41923726+agdillon@users.noreply.github.com> Co-authored-by: YerkovichM <48519843+YerkovichM@users.noreply.github.com> Co-authored-by: myerkovich <myerkovich@rubiconproject.com> Co-authored-by: Marko Yerkovich <marko_yerkovich@MacBook-Pro-Marko.local> Co-authored-by: samuel-palmer-relevant-digital <77437973+samuel-palmer-relevant-digital@users.noreply.github.com> Co-authored-by: pm-shashank-jain <40654031+pm-shashank-jain@users.noreply.github.com> Co-authored-by: ardit-baloku <77985953+ardit-baloku@users.noreply.github.com> Co-authored-by: msm0504 <51493331+msm0504@users.noreply.github.com> Co-authored-by: Mark Monday <mmonday@rubiconproject.com> Co-authored-by: Scott Menzer <scott@id5.io> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com> Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Kotaro Shikata <lim.0.ctyl@gmail.com> Co-authored-by: mamatic <52153441+mamatic@users.noreply.github.com> Co-authored-by: Ian Flournoy <ian@parrable.com> Co-authored-by: Victor <victorigualada@gmail.com> Co-authored-by: Rich Audience <integrations@richaudience.com> Co-authored-by: sgimenez <sergi.gimenez@richaudience.com> Co-authored-by: mefjush <mefjush@gmail.com> Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com> Co-authored-by: harpere <ericsbiz@yahoo.com> Co-authored-by: Denis Logachov <denis@adkernel.com> Co-authored-by: Eric Harper <eharper@rubiconproject.com> Co-authored-by: Skylinar <53079123+Skylinar@users.noreply.github.com> Co-authored-by: smartclip AdTechnology <adtech@smartclip.com> Co-authored-by: Gino Cirlini <adtech@smartclip.tv> Co-authored-by: SKOCHERI <37454420+SKOCHERI@users.noreply.github.com> Co-authored-by: skocheri <skocheri@rubiconproject.com> Co-authored-by: Nepomuk Seiler <muuki88@users.noreply.github.com> Co-authored-by: Adprime <64427228+Adprime@users.noreply.github.com> Co-authored-by: Aigolkin1991 <Aigolkin1991@gmail.com> Co-authored-by: Aiholkin <artem.iholkin@smartyads.com> Co-authored-by: shikharsharma-zeotap <shikhar.sharma@zeotap.com> Co-authored-by: nyakove <43004249+nyakove@users.noreply.github.com> Co-authored-by: Mikhail Dykun <m.dykun@wmgroup.us> Co-authored-by: Ian Flournoy <ian@flournoy.us> Co-authored-by: Harshad Mane <harshad.mane@pubmatic.com> Co-authored-by: mmoschovas <63253416+mmoschovas@users.noreply.github.com> Co-authored-by: bjorn-lw <32431346+bjorn-lw@users.noreply.github.com> Co-authored-by: Lemma Dev <54662130+lemmadev@users.noreply.github.com> Co-authored-by: ix-certification <adapter-certification-eng@indexexchange.com> Co-authored-by: Ix-Prebid-Support <ix-prebid-support@indexexchange.com> Co-authored-by: Missena <78362128+dev-missena@users.noreply.github.com> Co-authored-by: Nick Llerandi <nllerandi@triplelift.com> Co-authored-by: Brandon Ling <51931757+blingster7@users.noreply.github.com> Co-authored-by: Brandon Ling <bling@triplelift.com> Co-authored-by: Pooja Pasawala <poojapasawala@gmail.com> Co-authored-by: Mathieu Pheulpin <mpheulpin@sharethrough.com> Co-authored-by: lowendavid <66423906+lowendavid@users.noreply.github.com> Co-authored-by: iskmerof <matt.foremski@gmail.com> Co-authored-by: Matt Kendall <1870166+mkendall07@users.noreply.github.com> Co-authored-by: pnh-pubx <73683023+pnh-pubx@users.noreply.github.com> Co-authored-by: Phaneendra Hegde <phaneendra.hegde@gmail.com> Co-authored-by: TheMediaGrid <44166371+TheMediaGrid@users.noreply.github.com> Co-authored-by: prebidtappx <77485538+prebidtappx@users.noreply.github.com> Co-authored-by: marc_tappx <marc@tappx.com> Co-authored-by: guiann <guillaume.andouard@adyoulike.com> Co-authored-by: Guillaume <guiandouard@gmail.com> Co-authored-by: David Reischer <reischer.david@gmail.com> Co-authored-by: Gena <wertixvost@gmail.com> Co-authored-by: jsut <adam.prime@wattpad.com> Co-authored-by: Steve Alliance <steve@districtm.ca> Co-authored-by: Luis <luissastreverzun@gmail.com> Co-authored-by: Steve Alliance <stevealliance@Steves-Air.localdomain> Co-authored-by: Steve Alliance <stevealliance@Steves-MacBook-Air.local> Co-authored-by: steve-a-districtm <steve@districtm.net> Co-authored-by: Steve Alliance <stevealliance@DMMBP-C02WXCFAJG5H.local> Co-authored-by: Thomas Skaarnes Nikitin <48713095+thomas-netric@users.noreply.github.com> Co-authored-by: lksharma <sharmak.love@gmail.com> Co-authored-by: Marko Yerkovich <myerkovich@magnite.com> Co-authored-by: WlsLogan <77974248+WlsLogan@users.noreply.github.com> Co-authored-by: Paweł Cejrowski <pcejrowski@gmail.com> Co-authored-by: li-ran <70167305+li-ran@users.noreply.github.com> Co-authored-by: Ran Li <ran.li@indexexchange.com> Co-authored-by: amykwyang <amyyang90@gmail.com> Co-authored-by: Jason Snellbaker <jsnellbaker@appnexus.com> Co-authored-by: matthieularere-msq <63732822+matthieularere-msq@users.noreply.github.com> Co-authored-by: Samuel Adu <samuel.adu@gmail.com> Co-authored-by: Damyan <wyand@abv.bg> Co-authored-by: Ben Anderson <benanderson@benanderson.us> Co-authored-by: Anderson, Ben <Ben.Anderson@team.neustar> Co-authored-by: Vladimir Fedoseev <vl.fedoseev@gmail.com> Co-authored-by: afsheenb <afsheenb@users.noreply.github.com> Co-authored-by: Afsheen Bigdeli <afsheenb@namecast.net> Co-authored-by: nllerandi3lift <75995508+nllerandi3lift@users.noreply.github.com> Co-authored-by: Mike Chowla <mike.chowla@pubmatic.com> Co-authored-by: KazuakiM <kazuaki_mabuchi_to_go@hotmail.co.jp> Co-authored-by: César Fernández <cfalonso@gmail.com> Co-authored-by: ysfbsf <youssef.bsf@gmail.com> Co-authored-by: Olivier <osazos@adagio.io> Co-authored-by: iprom-adserver <79305981+iprom-adserver@users.noreply.github.com> Co-authored-by: Gašper Žagar <gasper.zagar@iprom.si> Co-authored-by: jackhsiehucf <77815341+jackhsiehucf@users.noreply.github.com> Co-authored-by: PWyrembak <paul@trustx.org> Co-authored-by: Justas Pupelis <pupelis.justas@gmail.com> Co-authored-by: Justas <jpmiltas@gmail.com> Co-authored-by: Salomon Rada <salomon@gamoshi.com> Co-authored-by: vladi-mmg <vladi@m-m-g.com> Co-authored-by: JulieLorin <juli.lorin+github@gmail.com> Co-authored-by: Laura Morillo-Velarde <laura.morillovelarde@gmail.com> Co-authored-by: Carlos Barreiro Mata <barreymata@gmail.com> Co-authored-by: Adam Browning <19834421+adam-browning@users.noreply.github.com> Co-authored-by: Ryan Schweitzer <50628828+r-schweitzer@users.noreply.github.com> Co-authored-by: Pierre Turpin <pierre.turpin54@gmail.com> Co-authored-by: Karim Mourra <karim@jwplayer.com> Co-authored-by: karimJWP <karimJWP@github.com> Co-authored-by: pm-azhar-mulla <75726247+pm-azhar-mulla@users.noreply.github.com> Co-authored-by: rtuschkany <35923908+rtuschkany@users.noreply.github.com> Co-authored-by: evanmsmrtb <evanm@smrtb.com> Co-authored-by: JonGoSonobi <jgo@sonobi.com> Co-authored-by: Scott Menzer <smenzer@gmail.com> Co-authored-by: thuyhq <61451682+thuyhq@users.noreply.github.com> Co-authored-by: novatiq <79258366+novatiq@users.noreply.github.com> Co-authored-by: lasloche <62240785+lasloche@users.noreply.github.com> Co-authored-by: Nick Jacob <nickbjacob@gmail.com> Co-authored-by: hybrid-ai <58724131+hybrid-ai@users.noreply.github.com> Co-authored-by: Petrov Denis <d.petrov@hybrid.ai> Co-authored-by: Yevhenii Melnyk <ymelnyk@liveintent.com> Co-authored-by: Aleksa Trajkovic <aleksatr@gmail.com> Co-authored-by: susyt <susan@fox.camp> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Daniel Liebner <dliebner@gmail.com> Co-authored-by: Nick Peceniak <njpeceniak@gmail.com> Co-authored-by: Nick Peceniak <npeceniak@spotx.tv> Co-authored-by: BizzClick <73241175+BizzClick@users.noreply.github.com> Co-authored-by: pro-nsk <32703851+pro-nsk@users.noreply.github.com> Co-authored-by: Artem Kostritsa <akostritsa@akostritsa.com> Co-authored-by: Alexander Kascheev <akascheev@asteriosoft.com> Co-authored-by: SmartyAdsSSP <41569976+SmartyAdsSSP@users.noreply.github.com> Co-authored-by: Alejandro Villanueva <avillanueva@ranker.com>

* Pubmatic: fix issue where using an adUnit outstream renderer throws an error (#6152) * Malltv Bid Adapter : added data object as a param (#6232) * Updated malltv adapter * Updated markdown * Added test for malltvBidAdapter * support setting coopSync in s2sConfig (#6213) Co-authored-by: Mark Monday <mmonday@rubiconproject.com> * Revert "support setting coopSync in s2sConfig (#6213)" (#6249) This reverts commit 25dd35c99f404390242133b84245bb5cafeb7d7b. * pbsBidAdapter: change order of client syncs (#6248) * pbsBidAdapter: change order cookie_syncs Prebid Server places cookie-sync URLs in a specific order. PBJS was pulling them off in reverse order. * moving comment * reverting coopSync * pass a flag back to ID5 servers if abTesting was enabled by the publisher for monitoring usage of the feature (#6170) * appneuxs Bid Adapter - add support for identitylink userId (#6245) * Update britepoolIdSystem.md (#6254) Eliot from Britepool says you can set just the api key without any params (eg ssid or hash) * UNICORN Adapter - accept multiple formats (#6255) * enable multiple formats add version * add banner w/h * fix w/h & spec * ATS-analytics - add comment clarifying ownership of atsAnalytics (#6257) * [ParrableIdSystem] Ensure base64 payload is url-safe (#6258) * Added url safe base64 encoding * Added url safe base64 encoding test Co-authored-by: Victor <victorigualada@gmail.com> * Keywords + Screen resolution + CPU Core (#6259) Co-authored-by: sgimenez <sergi.gimenez@richaudience.com> * Rubicon Analytics: Fire event once gptSlots render (#6241) * Once all gam slots are back fire event * push to cmd queue * New dimension for tracking name of the matching adUnit pattern (#6252) * Adhese Bid Adapter: Per adunit targets (#6256) * adpod category support test * Revert "adpod category support test" * Gjirafa Bid Adapter: added data object as a param (#6231) * Added data parameter to gjirafaBidAdapter * Updated gjirafaBidAdapter markdown * Added test for gjirafaBidAdapter * Fix a TypeError when message event source is not available (#6224) * fix broken tests due to "encoded" base64 logic (#6268) * Adkernel Bid Adapter: stringads alias added (#6262) * Adkernel: stringads alias * Revert "Extended ID permissions supported by bidder (#6112)" (#6269) This reverts commit a926dee9e108ca4b8792ba8992a9bca7c2f42781. * Prebid 4.25.0 Release * Increment pre version * smartxBidAdapter: new Feature - Made Out-Stream Player configurable (#6239) * Add smartclipBidAdapter * smartxBidAdapter.js - removed unused variables, removed debug, added window before the outstream related functions * - made outstream player configurable * remove wrong named files * camelcase * fix Co-authored-by: smartclip AdTechnology <adtech@smartclip.com> Co-authored-by: Gino Cirlini <adtech@smartclip.tv> * Idl1 (#6242) * Renaming idLibrary to idImportLibrary * Renaming idLibrary to idImportLibrary Co-authored-by: skocheri <skocheri@rubiconproject.com> * Add the trade desk gvlid (#6263) UnifiedId only works with a vendor exception in the gdpr enforcement module. However this is not okay as the unifiedId matching endpoint doesn't take the consent into account and cookies are being dropped even without consent. * pick up wrapper family detail (#6272) * Add user sync (#6244) * initial * fix * remove redundant language mod, use player sizes in video traff * test modify * fix * Adding Tests * add keywords param * log * log * log * fix * add idl * add idl * fix test * lint * lint * fix * lint * lint * lint * lint * add sync * fix Co-authored-by: Aigolkin1991 <Aigolkin1991@gmail.com> Co-authored-by: Aiholkin <artem.iholkin@smartyads.com> * Zeotap id plus gvlid (#6260) * Add gvlid for ZeotapIdPlus module * Pass gvlid and module name to storage manager * add testcases to zeotapIdPlusIdSystem * remove unwanted code * adWMG adapter: add new parameter, fix minor bugs (#6265) * Support floorCPM parameter, fix some minor bugs * fix space-in-parens circleci error * example fix * clean usersync URL * spaces * spaces * add new unit tests, compatibility with IE11 * remove logInfo Co-authored-by: Mikhail Dykun <m.dykun@wmgroup.us> * [ParrableIdSystem] Supply iframe state to backend (#6278) * Add iframe detection * Remove forgotten .only Co-authored-by: Victor <victorigualada@gmail.com> * Bid Viewability Module (#6206) * introducing a new event, bidViewable * new module: bidViewability * details in bidViewability.md * disable webdriver tests in trionBidAdapter spec (#6280) * [ParrableIdSystem] Supply Prebid library version to backend (#6279) * Add prebid version to data object * Renamed prebid to prebidVersion * Fix missing coma Co-authored-by: Victor <victorigualada@gmail.com> * [ParrableIdSystem] Accept list of partners as an array or string (#6277) * Accept partners as an array and fallthrough partner if no partners * Ensure that Parrable data object decodes with urlsafe base64 in tests * Fixed tests caused by typo in config property * Fix failing test due to accessing unexisting property 'partner' Co-authored-by: Victor <victorigualada@gmail.com> * Rubicon Bid Adapter FPD Update (#6122) * Update to consolidate applying FPD to both banner and video requests. FPD will be merged using global defined FPD, ad unit FPD, and rubicon bidder param FPD. Validation logic with warning logs added * Refectored last push to: 1) Correct keywords bug 2) Revise error which looked for FPD in (user/context).ext.data as opposed to (user/context).data 3) General code cleanup * Consolidated other FPD data logic into new function * 1. Update to move pbadslot and adserver data into imp[] as opposed to parent. 2. Update to convert keywords passed through RP params to string if array found * Removed unnecessary conditional * Changed conditional to check for undefined type * Update to consolidate several lines of duplicate code into one location * ID5 User Id Module: update a/b testing to be user based not request based (#6281) * convert A/B testing to be user-based, rather than request-based * update docs to say a/b testing is user based, not request based * Shared ID gdpr support (#6275) * SharedId gdpr support * Reverted commented locally failing tests * Lemma:set mediaType key value (#6006) * lemmaBidAdapter.js Added lemma bid adapter file * lemmaBidAdapter.md Added lemma bid adapter md file * lemmaBidAdapter_spec.js Added lemma bid adapter test spec file * Update lemmaBidAdapter.js Fixed automated code review alert comparison between inconvertible types * Update lemmaBidAdapter.js Fixed review changes * Update lemmaBidAdapter.md Correct parameter value. * Update lemmaBidAdapter.js Lemma Bid Adapter - v3.0 compliance * Update lemmaBidAdapter_spec.js Lemma Bid Adapter - v3.0 compliance * Update lemmaBidAdapter.md Lemma Bid Adapter - v3.0 compliance * Update lemmaBidAdapter.js Added user sync support into bid adapter. * updated include modules file extension. updated include modules js file extension. * Update lemmaBidAdapter_spec.js Added unit test for user sync feature. * Update lemmaBidAdapter.js Fixed format error. * Update lemmaBidAdapter_spec.js Fixed format error and typo error. * Set mediaType key value into bid object Set mediaType key value into the bid object. * Update lemmaBidAdapter.js remove duplicate function * Update lemmaBidAdapter.js Remove non supported code. * Update lemmaBidAdapter_spec.js Remove GDPR test cases. * added support for addtlConsent (#6005) Co-authored-by: Ix-Prebid-Support <ix-prebid-support@indexexchange.com> * Add bid adapter for Missena (#6247) * adds support for getFloor of video mediaTypes * adds test for calling getFloor with correct mediaType * checks that _getFloor converts string floors to float * Add bid adapter for Missena * Use publisher demo token in tests * Add Missena global vendor ID to spec * Use apiKey in the current bidRequest * Add referer info to payload Co-authored-by: Nick Llerandi <nllerandi@triplelift.com> Co-authored-by: Brandon Ling <51931757+blingster7@users.noreply.github.com> Co-authored-by: Brandon Ling <bling@triplelift.com> * Gulp test file example added in readme (#6287) * Sharethrough: Add support for ID5, Shared ID, and Live Intent ID (#6261) * Update prebid adapter universal ids to include ID5, SharedID, and LiveIntent ID. [#176447070](https://www.pivotaltracker.com/story/show/176447070) Co-authored-by: Mathieu Pheulpin <mpheulpin@sharethrough.com> * Addressing review [#176447070] * Quick rewrite [#176447070] * Address ID5 review, forward linkType to adserver * Reformatting SharedID to align with ID5 Co-authored-by: Mathieu Pheulpin <mpheulpin@sharethrough.com> * SmartAdServer Bid Adapter: image sync and noAd (#6236) * SIM-889 Now we have image based sync * SIM-889 Added test to check noad and image sync * SIM-889 Fixing indenting issues * Add client Alias Adkernel (#6291) Adding "bcm" alias to Adkernel adapter * [ParrableIdSystem] Add GVLID and handle TC Consent data (#6283) * Added GDPR support * Remove forgotten .only Co-authored-by: Victor <victorigualada@gmail.com> * 4.26.0 release * 4.27.0-pre * Updated data mapping of winning bid and auction logs in pubxai analytics adapter (#6285) Co-authored-by: Phaneendra Hegde <phaneendra.hegde@gmail.com> * Grid Bid Adapter: Added video protocols to the ad request (#6299) * Rubicon Bid Adapter: updated transactionId to auctionId for OpenRTB (#6298) * Fix for Issue 6117: Added Module Name in Build to Comments (#6297) * map tripleliftBidAdapter.js tl_source to bid.meta.mediaType (#6303) * Tappx Bid Adapter: new bidder adapter added (#6233) * ADD: tappx bid adapter * FIX: replace .includes by .indexOf * UPDATE: Expand the test coverage * FIX: format spacing tests * FIX: get auctionId from validBidRequests * UPDATE: add bannerMediaType tablet sizes * FIX: get timeout from bidderRequest.timeout * UPDATE: replace the way to get the hostname * UPDATE: adding support multiple bid requests in a single call * UPDATE: remove hardcoded test payload param Co-authored-by: marc_tappx <marc@tappx.com> * Add Native ad capability to AdYouLike adapter (#6198) * Remove useless bidderCode in bid response * send all the available sizes in the bid request * Use the banner sizes if given * avoid compatibility issue with old bid format * ad iframe and publisher domain paramters to bid requests * add publisher domain info in ad request * add a check in unit tests for publisherDomain * encode uri components * add native assets support * add native information to ad request * fix native ad parsing * fix nativ condition to set mediatype * fix image access and add trackers * fix and add unit test on native ad * update md file * remove usage of URLSearchParams * allox pure native ad with no adm provided Co-authored-by: Guillaume <guiandouard@gmail.com> * Update targeting.js to fix TTL buffer arithmetic (#6300) * Permutive RTD submodule (#6290) * Add Permutive RTD module * set demo data in LS for test page * fix linter issues * reduce timeout on example page * decrease sample timeouts * rename targeting to segments * Adtelligent Bid Adapter: Add Navelix as alias (#6306) * Navelix bidder * gvlID * Pubmatic add warning for non-string adSlots (#6304) * add warning for non-string adSlots - and update the markdown file to say they should be strings * be more specific in explanatory comment * Update ttl outstream (#6253) * adding DMX test @97%, two files added one updated * Update districtm_spec.js * Update districtmDMX.js * adding all districtm needed file * remove legacy file * remove typo || 0 in the test method * force default to return a valid width and height * update unit test code for failing test * changed class for an object * remove package-lock.json * change file name for dmx adapter * renamed files * restaure package-lock.json * update to last package-lock state * update gdpr user consent * fix sizes issue * Documentation updates Adding the readme.md info * update file name and update unit testing import file location * current machine state * lint correction * remove variable assigment duplicate * adding CCPA support for DMX * adding test for ccpa and gdpr * districtm dmx adding deal id field * idsync support ccpa & gdpr * merge forked * stop mediatype changing ttl * remove lint error * adding gvlid for dmx * removing change Removing change from on commit PR file package-lock.json * update file Removing comments on DMX adapter * Revert "removing change" This reverts commit e4bbbe55 * adding aliases base on ticket #6294 * update file Removing comments on DMX adapter * fix error for issue #6294 * file removal from PR Co-authored-by: Steve Alliance <steve@districtm.ca> Co-authored-by: Luis <luissastreverzun@gmail.com> Co-authored-by: Steve Alliance <stevealliance@Steves-Air.localdomain> Co-authored-by: Steve Alliance <stevealliance@Steves-MacBook-Air.local> Co-authored-by: steve-a-districtm <steve@districtm.net> Co-authored-by: Steve Alliance <stevealliance@DMMBP-C02WXCFAJG5H.local> * [ParrableIdSystem] Accept lowercase timezone names in timezone filter (#6282) * Add lower case comparison for allowedZones * Lowercase blocked zones also * Fixed timezone lowercase tests * Handle IE missing timeZone field * Improve lowercase timezone comparison Co-authored-by: Victor <victorigualada@gmail.com> * Added new size - Id 550 (980x480) (#6311) * Revert "Rubicon Bid Adapter: updated transactionId to auctionId for OpenRTB (#6298)" (#6314) This reverts commit f672209110ef30b9cdf96048d4e8285d43716b4a. * Rubicon: adding size 300x200 (#6315) * added prebid version support to ixdiag (#6292) * Extended ID permissions supported by bidder (#6276) * User id bidder permission scheme * styling * prebidServer support * - * fix * prebidServerBidAdapter take eidPermissions directly from userId module * - * unit tests * - * - * update * - * - * changed pbjs_bidders to pbjsBidders * changed pbjsBidders to bidders ext.prebid.data.eidPermissions to ext.prebid.data.eidpermissions * rerun circleci * rerun circleci * omitting eidPermission entry if 'bidders' is not configured * fixed 'calling the PBS adapter without any defined userId modules causes an exception' * proposal * rerun circleci * utils implementation * comment * revert import validation Co-authored-by: myerkovich <myerkovich@rubiconproject.com> Co-authored-by: Marko Yerkovich <marko_yerkovich@MacBook-Pro-Marko.local> Co-authored-by: Marko Yerkovich <myerkovich@magnite.com> * new bid adapter: Logain (#6312) Co-authored-by: Aiholkin <artem.iholkin@smartyads.com> * Change URL in Tapad Id Submodule (#6318) * IndexExchange Bid Adapter: Added support for netID, ID+ and FabrickId userId (#6286) * added more userID partner support for IX adapter - TDID, LI, NetID, Neustar, Zeotap * removed liveintent and adsrvr.org [DNA-5040] * updated neustar id * fixed fabrickid * frabrickId instead of id * added more userID partner support for IX adapter - NetID, Neustar, Zeotap (#1) * added more userID partner support for IX adapter - TDID, LI, NetID, Neustar, Zeotap * added tests * added tests for new userinfo modules * missed a few checks * Dna 5040 ix userid support (#2) * added more userID partner support for IX adapter - TDID, LI, NetID, Neustar, Zeotap * removed liveintent and adsrvr.org [DNA-5040] * updated neustar id * fixed fabrickid * frabrickId instead of id * added tests * added tests for new userinfo modules * missed a few checks Co-authored-by: Ran Li <ran.li@indexexchange.com> * added few missing checks in IX adapter * Use userIdAsEids instead of userId (#3) * use eids, revert package-lock * test update Co-authored-by: Ran Li <ran.li@indexexchange.com> Co-authored-by: amykwyang <amyyang90@gmail.com> * Prebid 4.27.0 Release * increment pre version * mediasquare fix userId (#6321) * Change the EU consent string parameter name to the company-wide standard (#6320) * adding support in pbsAdapter for getFloor (#6273) * AdHash Bidder Adapter: initial prebid.js integration (#6274) * PBJS Video Cache Update (#6295) * Support bidder aliasing by not using bid.bidder to retrieve configs (which are static anyway) (#6313) * Fabrick ID System : updates to _setReferrer and appending urls (#6322) * fabrickId updates - encode all url params - dedupe w/out queryString and keep the longest - additionally truncate from % if that ends up being the last (or next to last) char after truncation - truncate 1k instead of 200 - don't send functions along in query (only send strings and numbers) * attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 * re-attempting to fix ie failure - https://app.circleci.com/pipelines/github/prebid/Prebid.js/3945/workflows/4929a5c0-9e57-49e3-a6d8-29691560ca31/jobs/12086 - attempting to add debugging so I can know what exactly is failing in ie (since I don't have a windows machine) * found the issue having debugged locally - stubbing my error message is what killed me! * not the right way to loop through a map Co-authored-by: Anderson, Ben <Ben.Anderson@team.neustar> * Configureable option to delay auction event + fix bug with googletag init (#6344) * Adhese Bid Adapter: replace id5 with eid (#6339) * FID-287: Update Reconciliation RTD delivery id format (#6343) * Inskin Bid Adapter: send screen size in the ad call (#6316) * Ozone Bid Adapter: added or updated support for multiple modules (#6324) * ozone 2.5.0 adapter updates * ozone 2.5.0 adapter - fixup for prebidCircleCI tests to remove object values on user.eid Co-authored-by: Afsheen Bigdeli <afsheenb@namecast.net> * Triplelift Bid Adapter: add PubCommon ID support (#6352) * Prebid 4.28.0 Release * Increment pre version * GMOSSP Bid Adapter : add refererInfo from bidderRequest (#6319) * Axonix Bid Adapter: add new bid adapter (#6341) * Add Axonix bid adapter * Fixed tests * Documentation: Prebid Server and Postbid integration example ( ad server-less ) (#6348) * Native: add custom data assets capability (#6220) Use `mediaTypes.native.ext: {}` special object to add/allow custom data. assets. * iPROM adapter upload - adapter (#6334) Co-authored-by: Gašper Žagar <gasper.zagar@iprom.si> * Ucfunnel Bid Adapter: update currency parameter in ad response (#6357) * TheMediaGrid Bid Adapter: fix trouble with alias using (#6363) * Rubicon Analytics Adapter: pass along advertiserDomains (#6356) * Pass along advertiser domains! * only send up to 10 adomains * support setting coopSync in s2sConfig (#6330) * TrustX Bid Adapter: Fix alias error (#6373) * Adform Bid Adapter: add global targeting to the request query as parameter (#6376) Co-authored-by: Justas <jpmiltas@gmail.com> * Prebid 4.29.0 Release * Increment pre version * Gamoshi Bid Adapter: update adaptor aliases (#6355) * Marsmedia Bid Adapter: add support for viewability, floor price module, COPPA & CCPA (#6337) * Change publisherId to zoneId Add gdpr Add supply chain Add video media type * Remove comments * Fix unit test coverage * fix request id bug add vastXml to video response * Remove bid response default sizes * Change endpoint url * Add unit test for vastXml * Change end point * Remove trailing-space * Add onBidWon function * New adapter - videofy * Marsmedia & Videofy - Add onTimeout onSetTargeting * Create sendbeacon function * - add viewability * remove unnecessary utils.getWindowTop() * fix bidderRequest matching for finding a renderer (#6359) * Seedtag Bid Adapter: add support for inArticle placement (#6369) * Fix: check mandatory video params * Simplifying mediaType video existence check * SQDTAR-42: onWonBid event (#2) * Adding onBidWon handler. * Adding nurl to bid. * Adding nurl field to bid. * Adding inArticle placement type to seedtag adapter. (#1) Co-authored-by: Carlos Barreiro Mata <barreymata@gmail.com> * improve robustness on OnEvent fields (#6384) * oneVideo Bid Adapter: remove adapter adId because of conflict with pbjs core (#6382) * updated object,str,num validations using pbjs utils * validation if statements for content object * validation if statements for content object * updated contetn object validations using utils * refractoring clean if statement * fixing typos * added todos * added category string & data object validations * fixed esling ENDPOINT issue * updated content obj unit tests * fixed cat & data validation * fixed producer as object * revert .includes() to .indexof() for IE * reduced content obj params accoriding to ad-server support * fixed typeOf typo * fixed episode to Number * gitignore * restore gitignore * removed unsupported params from md file * reverted package & pagkage-lock * fixed incorrect episdoe from str to num * removed bid.adid setting from L97 * removed bid.adId setting * updated adId test * updated version to 3.0.6 * PBS Bid Adapter: add dchain (demand chain object) to prebid server adapter (#6383) * Update prebidServerBidAdapter_spec.js * Update index.js * Gulp Build: fix to populate modules list when gulp bundle is executed (#6331) * added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * need to update modules list when gulp bundle is called * added a comment * Smartx Bid Adapter: updated out-stream render to support smartPlay 5.2 (#6370) * Add smartclipBidAdapter * smartxBidAdapter.js - removed unused variables, removed debug, added window before the outstream related functions * - made outstream player configurable * remove wrong named files * camelcase * fix * Out-Stream render update to SmartPlay 5.2 * ESlint fix * ESlint fix * ESlint fix * adjust tests, fixes * ESlint Co-authored-by: smartclip AdTechnology <adtech@smartclip.com> Co-authored-by: Gino Cirlini <adtech@smartclip.tv> * Fpd 2.0 Update (#6293) * Update to consolidate applying FPD to both banner and video requests. FPD will be merged using global defined FPD, ad unit FPD, and rubicon bidder param FPD. Validation logic with warning logs added * Refectored last push to: 1) Correct keywords bug 2) Revise error which looked for FPD in (user/context).ext.data as opposed to (user/context).data 3) General code cleanup * Consolidated other FPD data logic into new function * 1. Update to move pbadslot and adserver data into imp[] as opposed to parent. 2. Update to convert keywords passed through RP params to string if array found * Removed unnecessary conditional * Changed conditional to check for undefined type * FPD 2.0 Update 1) The setConfig and setBidderConfig functions support a transition period where they map the original 'fpd' config: - fpd.context.ATTR --> ortb2.site.ATTR - fpd.context.data.ATTR --> ortb2.site.ext.data - fpd.user.ATTR --> ortb2.user.ATTR - fpd.user.data.ATTR --> ortb2.user.ext.data 2) gptPreAuction: a) move adunit.fpd to adunit.ortb2 b) adUnit.ortb2Imp.ext.data.adserver.{name, adSlot} c) pbAdSlot moves to AdUnit.ortb2Imp.ext.data.pbAdSlot 3) pbsBidAdapter a) merge the new ortb2 and AdUnit.ortb2Imp.ext objects into the OpenRTB JSON. b) therefore imp[].ext.context.data.pbadslot is now changed to imp[].ext.data.pbadslot (no context) c) read adUnit.ortb2Imp.ext.data.adserver from the new location. Output location is moved to imp[].ext.data.adserver (no context) * FPD 2.0 Update Update to adrelevantis adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to amx adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to avocet adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to criteo adapter to look at config.ortb2 instead of config.fpd * Update to correct imp fpd structure * Update to s2s adapter to coincide with imp fpd alteration * Update to consolidate several lines of duplicate code into one location * Slight modification for ortb2Imp to use ortb2Imp.ext as opposed to ortb2Imp.ext.data * FPD 2.0 Update Update to grid adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to inmar adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to luponmedia adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to smaato adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to triplelift adapter to look at config.ortb2 instead of config.fpd * Update to gptPreAuction to move over to imp level ortb2 * FPD 2.0 Update Update to triplelift adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update * FPD 2.0 Update Update to jwplayerRtd adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to admixer adapter to look at config.ortb2 instead of config.fpd * FPD 2.0 Update Update to rubicon adapter to look at config.ortb2 instead of config.fpd * Update to fix keyword bug * Added backwards compatibility functions for FPD both global/bidder and adunit level data * Update to utilize new backward functionality for fpd 2.0 * Removed extra new line * Update to include new backward functionality for FPD 2.0 data * Update to utilize new backward functionality to pass FPD 2.0 data * Update to utilize backward functionality to pass FPD 2.0 data * Update to utilize backward functionality to pass FPD 2.0 data * Update to utilize backward functionality to pass FPD 2.0 data * Update to utilize backward functionality to pass FPD 2.0 data * Update to utilize backward functionality to pass FPD 2.0 data * Fixed typo in fpd config object location * Uodate to utilize backward functionality to pass FPD 2.0 data * Update to change all ortb2Imp.ext.data.adserver.adSlot references to ortb2Imp.ext.data.adserver.adslot - all lowercase. Corresponding adapter and unit tests to adhere to these changes * Fixed typo * Fixed typo * FPD 2.0 update to rubicon adapter to pass iab values * Updates: 1) Change function name 2) addAdUnits always pass array 3) Remove unecessary comment 4) Bug fix for ortb2.user.data to be filtered on legacy fpd conversion * PBS Bid Adapter: fix s2s alias collision with built-in adapter aliasing (#6379) * fixed overwriting of aliases for s2s * made change * added fix * Clean side-effect when checking that local storage is enabled (#6323) * updates docs and demo for fpd changes (#6302) Co-authored-by: karimJWP <karimJWP@github.com> * Changed net revenue to True (#6387) * adagioBidAdapter: add Native support (#6368) * EIDS Support Update (#6394) * TheMediaGridNM Bid Adapter: fix trouble with alias (#6371) * Added TheMediaGridNM Bid Adapter * Updated required params for TheMediaGridNM Bid Adapter * Update TheMediGridNM Bid Adapter * Fix tests for TheMediaGridNM Bid Adapter * Fixes after review for TheMediaGridNM Bid Adapter * Add support of multi-format in TheMediaGrid Bid Adapter * Update sync url for grid and gridNM Bid Adapters * TheMediaGrid Bid Adapter: added keywords adUnit parameter * Update TheMediaGrid Bid Adapter to support keywords from config * Implement new request format for TheMediaGrid Bid Adapter * Fix jwpseg params for TheMediaGrid Bid Adapter * Update unit tests for The Media Grid Bid Adapter * Fix typo in TheMediaGrid Bid Adapter * Added test for jwTargeting in TheMediaGrid Bid Adapter * The new request format was made by default in TheMediaGrid Bid Adapter * Update userId format in ad request for TheMediaGrid Bid Adapter * Added bidFloor parameter for TheMediaGrid Bid Adapter * Fix for review TheMediaGrid Bid Adapter * Support floorModule in TheMediaGrid Bid Adapter * Fix empty bidfloor for TheMediaGrid Bid Adapter * Some change to restart autotests * Fix userIds format for TheMediaGrid Bid Adapter * Remove digitrust userId from TheMediaGrid Bid Adapter * Protocols was added in video section in ad request for TheMediaGrid Bid Adapter * TheMediaGrid: fix trouble with alias using * TheMediaGridNM: fix trouble with alias * Grab sourceAgnostic IDs first, then fallback to regular IDs (#6400) * Permutive - add AC support for TrustX (#6393) * SmartRTB Bid Adapter: add alias and update valid opts (#6365) * Add alias, update valid opts * Update bidder tests * Prebid 4.30.0 Release * Increment pre version * Sonobi Bid Adapter: send eids in bid request. (#6364) * unwrapping id5id uid. Added new eid param for user id modules * set userid to new variable * fixed spelling mistake in unit test Co-authored-by: Scott Menzer <smenzer@gmail.com> * copying userid object so the referenced object does not get updated. * using deepClone instead of spreading the top userId object Co-authored-by: Scott Menzer <smenzer@gmail.com> * Apacdex Bid Adapter: userId module support, show demo ads in debug mode & other maintenance (#6378) * Upgrade and maintenance apacdexBidAdapter * fix error and add unit test * Novatiq ID System: add snowflake userId submodule (#6350) * Novatiq snowflake userId submodule Novatiq snowflake userId submodule initial release * change request updates added novatiq info /modules/userId/userId.md added novatiq info /modules/userId/eids.md added novatiq eids /modules/userId/eids.js added novatiq module in /modules/.submodules.json removed unnecessary value from getId response * Update novatiqIdSystem_spec.js removed unnecessary srcid value * Update novatiqIdSystem.md Novatiq ID System: updated novatiq snowflake ID description * Rise Bid Adapter: add session_id & is_wrapper params to adapter (#6407) * add new params to rise adapter * add unit tests for isWrapper and sessionId adapter params * IronSource Bid Adapter: add session_id & is_wrapper params to adapter (#6408) * add new params * add unit tests for isWrapper and sessionId adapter params * AMX Bid Adapter: add or update general adapter support and code refactoring (#6403) * AMX Bid adapter improvements * fix eslint issues (breaking CI) * VOX Bid adapter, Hybrid Bid adapter: fix global var name to avoid conflicts with astraOne adapter. (#6416) Co-authored-by: Petrov Denis <d.petrov@hybrid.ai> * LiveIntent Id System: fix for parsing response twice (#6418) * Don't parse response twice in LiveIntent Id submodule * Update the liveintent module test to have the 204 response * PBJS Core: use mediaType renderer when backupOnly and no bid.renderer (#6419) * use mediaType renderer when backupOnly and no bid.renderer * check if necessary renderer properties are defined * GumGum Bid Adapter: pass bidfloor currency in bidrequest (#6391) * adds support for zone and pubId params * adds support for iriscat field * sets mediatype depending on product id * Update doc for mediaType needed for video products * makes slot and invideo products avail for pubId * updates gumgum doc * lint * adds missing comma in gumgum doc * adds currency in ad request, adds unit test * readd the previous irisid changes * remove the only in testing * Documentation: fixed a typo and sentence structure (#6421) * Bid Glass Bid Adapter: pass options in bid request (#6424) * Added bidglass adapter + test * PR Review Updates: - Added formal params to getUserSyncs function definition - getUserSyncs now always returns an array - Improved unit test coverage * PR Review Updates: - Removed unused methods: getUserSyncs, onTimeout, onBidWon, onSetTargeting - Removed getUserSyncs unit test - Removed "dead code" - Removed some unnecessary comments - Fixed usage of parseInt * Bid Glass Bid Adapter: pass options in bid request * Spotx Bid Adapter: add publisher support for cache.ignoreBidderCacheKey (#6413) * Support ignoreBidderCacheKey in spotxBidAdapter * Update spotxBidAdapter_spec.js * Update spotxBidAdapter_spec.js Co-authored-by: Nick Peceniak <npeceniak@spotx.tv> * update prebid adapter. Add at, ccpa, gdpr and coppa support (#6405) * Qwarry Bid Adapter: add referer detection (#6412) * qwarry bid adapter * formatting fixes * fix tests for qwarry * qwarry bid adapter * add header for qwarry bid adapter * bid requests fix * fix tests * response fix * fix tests for Qwarry bid adapter * add pos parameter to qwarry bid adapter * qwarryBidAdapter onBidWon hotfix * Change bidder endpoint url for Qwarry adapter * add referer JS detection * use bidderRequest.refererInfo * fix tests Co-authored-by: Artem Kostritsa <akostritsa@akostritsa.com> Co-authored-by: Alexander Kascheev <akascheev@asteriosoft.com> * Smartyads Bid Adapter: add coppa field from config (#6402) * update adapter. Add coppa field from config * move stubs and restores for coppa tests * PBS Bid Adapter: Fpd2.0 bug fix for first party data issue (#6428) * Bug fix for PBS data from FPD2.0 update: Merging request.site and request.user with site and user object in FPD. * Prebid 4.31.0 Release * Increment pre version * a4g Bid Adapter: delete adid and use crid if it exists (#6409) * Deleted adid * set crid if it's exist and added unit tests * Mediawallah ID System: add openlink userId submodule (#5921) * My first commit * Removed unnecessary await operation * Bug fixes and compliance fixes * Fixing some formatting and naming * Updating code based on automated feedback. * Parking refactoring change for team review * update mwOpenLink module * remove .git 2 folder * Trying to force a change * update the PR comments * applying the changes * update submodules.json and userId.md * fix typo of module names * update module decode function and test code * update test codes * apply the suggestions from Prebid * fix count of modules. Co-authored-by: Eric Brown <eric@mediawallah.com> Co-authored-by: hanna <hanna.panova190119@gmail.com> Co-authored-by: hannapanova190119 <71532550+hannapanova190119@users.noreply.github.com> * Documentation: Adjust desired bitrate examples smartx adapter (#6438) * Remove adId (autogenerated by Prebid) (#6441) * RichAudience Bid Adapter: add render video in banner (#6392) * Integration Example: ID import library example (#6434) * ID Import Library example * Fixing review comments Co-authored-by: skocheri <skocheri@rubiconproject.com> * Mass Module: add module to support MASS protocol (#6332) * Initial implementation for the MASS module * Updated namespace and CDN location * Updated the data object passed to MASS bootloader * Fix linting issues * Added unit tests * Added a README for the MASS module. * Allow MASS be disabled via Prebid configuration * Only check deal ID for matching MASS bids * Updated docs * Update how we test for MASS bids * Thighten the test for MASS bids * Fix linting issues * Change deal ID prefix and add option to specify the bootloader location. Updates to docs. * Updated tests with the new META_MASS deal ID prefix * Update comment in modules/mass.js Co-authored-by: Scott Menzer <smenzer@gmail.com> * Additional information about the module * More specific description of external resource * Identify MASS bids by looking for a 'mass' flag in bid meta or testing deal IDs against a publisher defined pattern * Updated MASS module tests * Bug fixing, added integration example and increased test coverage * Fix integration example and add notice * Updated example page * Updated bootloaderUrl param name to renderUrl and removed its default value. Must be specfied in module config now. * Updated integration example for MASS * Update mass.md Updated disclaimer and synced with docs Co-authored-by: Scott Menzer <smenzer@gmail.com> Co-authored-by: massadmin <58946787+massadmin@users.noreply.github.com> * Axonix bid adapter: set both connectiontype & effectivetype in the request (#6439) * Set both connectiontype and effectivetype in the request object * Version bump * Fixes for undefined var * Sublime Bid Adapter: v0.7.1 & add extra information in tracking pixels (#6442) * add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon (#22) * add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon * Incremente version of sublimeBidAdapter * Renamed pixel for timeout and introduce gvlid * Remove unnecessary params for sendEvent Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com> Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com> Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com> * Remove trailing-space * Fix version in tests * sublimeAdapter: Improve pixels data * sublimeAdapter: Update tests * sublimeAdapter: Rename data Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com> Co-authored-by: Léo <51166933+SublimeLeo@users.noreply.github.com> Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com> Co-authored-by: Léo GRAND <leo.grand@sublimeskinz.com> * Interactive Offers Bid Adapter: add new bid adapter (#6399) * Interactive Offers bid adapter * Interactive Offers bid adapter * Interactive Offers bid adapter * Interactive Offers bid adapter * Interactive Offers bid adapter * Interactive Offers bid adapter * Interactive Offers bid adapter * Interactive Offers bid adapter * manually kicking off tests Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> * AdYouLike Bid Adapter: replace shorthand "image" native config (#6401) * replace shrorthand "image" native type * merge publisher native config with image type config * add unit tests on native image config type * AMX Bid Adapter: Video Bugfix (#6435) * LiveWrapper Bid Adapter: use userIdAsEids to handle all user ids (#6445) * Livewrapped bid and analytics adapter * Fixed some tests for browser compatibility * Fixed some tests for browser compatibility * Changed analytics adapter code name * Fix double quote in debug message * modified how gdpr is being passed * Added support for Publisher Common ID Module * Corrections for ttr in analytics * ANalytics updates * Auction start time stamp changed * Detect recovered ad blocked requests Make it possible to pass dynamic parameters to adapter * Collect info on ad units receiving any valid bid * Support for ID5 Pass metadata from adapter * Typo in test + eids on wrong level * Fix for Prebid 3.0 * Fix get referer * http -> https in tests * Native support * Read sizes from mediatype.banner * Revert accidental commit * Support native data collection + minor refactorings * Set analytics endpoint * Support for app parameters * Fix issue where adunits with bids were not counted on reload * Send debug info from adapter to external debugger * SChain support * Send GDPR data in analytics request * video support Video support * Report back floor via analytic * Send auction id and adunit/bidder connection id * Criteo id support * Updated example * livewrapped Analytics Adapter info file * Livewrapped gvlid * Handle all User Ids * kick off tests manually Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> * Invibes: Read legitimate interests; pubCommonId & pubProvidedId integration (#6420) * Update dfpAdServerVideo.js * revert accidental commit * AdTrue Bid Adapter: getUserSyncs logic update (#6338) * add AdTrue bid adapter * add AdTrue Bid Adapter unit tests * add AdTrue Bid Adapter unit tests * add AdTrue bid adapter * add AdTrue Bid Adapter unit tests * add AdTrue Bid Adapter unit tests * add AdTrue bid adapter * adtrue usersync udpate * adtrue usersync udpate * #adtrue bidder usersync udpate * #Refactoring code & add unit test * Update package.json * Update package-lock.json * 1. Merge branch 'master' of https://github.com/prebid/Prebid.js 2.AdTrue Bid Adapter Refactoring code * 1. Merge branch 'master' of https://github.com/prebid/Prebid.js 2.AdTrue Bid Adapter Refactoring code * removing a package-lock.json from PR * - removing a package-lock.json from PR - AdTrue bidder: refactoring code & add unit test * - removing a package-lock.json from PR - AdTrue bidder: refactoring code & add unit test * - removing a package-lock.json from PR - AdTrue bidder: refactoring code & add unit test * update package-lock.json from upstream * IX Bid Adapter: add priceFloors support and an integration example (#6390) * Adding priceFloors Support to IX bid adapter and some refactoring * refactoring the getfloor logic, and removing dead code * newline at end of integration example * spacing issues lint fix * try catch around getFloor, in case the priceFloors module throws an exception * minor rename allU -> allu * falsey values fix, log prefix added * PBS adapter: remove condition on gdpr consentstring which isnt required by the tcf2 spec when gdprapplies is false (#6429) * Update index.js * Update prebidServerBidAdapter_spec.js * Update prebidServerBidAdapter_spec.js * Update prebidServerBidAdapter_spec.js * if the stored value was an object, then it could end up with a space before the {, causing the stored value not to be json parsed simply because of a space in the first character (#6467) * Kargo Bid Adapter: add gdpr support (#6447) * Bid Glass Adapter: Merge externally set targeting params (#6426) * Added bidglass adapter + test * PR Review Updates: - Added formal params to getUserSyncs function definition - getUserSyncs now always returns an array - Improved unit test coverage * PR Review Updates: - Removed unused methods: getUserSyncs, onTimeout, onBidWon, onSetTargeting - Removed getUserSyncs unit test - Removed "dead code" - Removed some unnecessary comments - Fixed usage of parseInt * Bid Glass Bid Adapter: pass options in bid request * Merge externally set targeting params * Updates to address gulp errors * Get `bidglass` reference from window * Optimon Analytics Adapter: add new analytics adapter (#6333) * Publish the Optimon platform's analytics adapter for prebid Added js and md files for the analytics adapter. * Fix wrong content in MD file * Fix wrong content in MD file * Created unit testing to Optimon Analytics Adapter * Created unit testing to Optimon Analytics Adapter * Created unit testing to Optimon Analytics Adapter * Created unit testing to Optimon Analytics Adapter * Fixes ESlint styling * Removing DEF const * Created unit testing to Optimon Analytics Adapter * Created unit testing to Optimon Analytics Adapter * 4.32.0 release * 4.33.0-pre * UID 2.0 Userid submodule (#6443) * UID 2.0 User id submodule * UID 2.0 User id submodule * UID 2.0 User id submodule * UID 2.0 User id submodule * Resolving merge conflicts and review comments * Updating documentation * Renaming module * Fixing review comments * Fixing review comments * Fixing review comments * Fixing review comments * Fixing review comments * Updating source uid2.com to uidapi.com Co-authored-by: skocheri <skocheri@rubiconproject.com> * H12media Bid Adapter: added new optional params, fixes, and various integration support (#6436) * Change module H12 Media * Change module H12 Media * Change module H12 Media * Change module H12 Media * Update module H12 Media * Update module H12 Media * Update module H12 Media * Update module H12 Media * Update module H12 Media * Update module H12 Media * AdYouLike Bid Adapter: add video capabilities (#6398) * read and send getFloor value * improve robustness on OnEvent fields * add video mediatype to adyoulike adapter * improve robustness on OnEvent fields * handle instream cases * minor format fix * move the atob call to apply it on every Vast response * update adyoulike md file with video type * update adyoulike bidder doc * fix merge error on 'bid' var name * update adyoulike bidder doc * remove deprecated creative rendering example * Update Recommendation to install with 'npm ci' (#5697) With the recent upgrade of npm we should be using the 'npm ci' option install packages. This provides a more reliable deployment that does not update packages on install. It will reduce check-ins of improper package-lock.json and provide greater assurance that a stable node_modules is deployed. * Openx Bid Adapter: add floor support for Video (#6460) * fix confusing comment * refactor(openxBidAdapter): extract enrichQueryWithFloors * PBID-1194: add floor for Video * Update to rubicon analytics adapter to pass along pbsBidId if present on the bidObject (#6461) * differentiate the IDs provided by ID5 when the user is opted out vs the user is in the control group of A/B testing (#6471) * AdagioBidAdapter: add capability to pass ext-data from localStorage in bidRequest (#6415) * Seedtag Bid Adapter: add connection type to bid request (#6457) * add connectionType to the bidRequest * remove a console.log * put connectionType in the payload * more secure connectionType access * add a unit test for connectionType * fix connectionType typo * AdDefend Bid Adapter: new bid adapter (#6450) * addefeend bid adapter implementation * fixed parameter documentation Co-authored-by: Mitschi <mitschi@addefend.com> * GumGum Bid Adapter: adds meta field to bidresponse (#6478) * adds meta field to bidresponse * adds meta mediatype and advertiserdomain default * example integration file renamed to hello_world (#6475) * Incorrect atypes on various eids (#6477) * Update eids.js * Update eids_spec.js * Update eids.js * Update pubmaticBidAdapter_spec.js * Update eids.js * Update eids_spec.js * Update conversantBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update conversantBidAdapter_spec.js * Delete test/spec/adapters directory * Update userId_spec.js * added support for roundel alias (#6473) * Doceree Bid Adapter: new bid adapter (#6437) * doceree adapter * add fix for impression register * fix linting issues * fix build issue * remove extra spaces * fixing - Implicit operand conversion * fixed ci/cd lint issue * update test case * support for advertiserdomains and updated test case * remove space to rerun test cases * remove the client side creative creation * OpenX Bidder Adapter: Add user ID sub-modules (#6490) * Smaato: FPD Revision (#6459) Co-authored-by: Bernhard Pickenbrock <bernhard.pickenbrock@smaato.com> * Conversant adapter: add adomain, remove digitrust (#6495) * Update eids.js * Update eids_spec.js * Update eids.js * Update pubmaticBidAdapter_spec.js * Update eids.js * Update eids_spec.js * Update conversantBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update conversantBidAdapter_spec.js * Delete test/spec/adapters directory * Update userId_spec.js * Update conversantBidAdapter.js * Update conversantBidAdapter_spec.js * Update conversantBidAdapter_spec.js * Update conversantBidAdapter_spec.js * Rads Bid Adapter: add GDPR support & user sync support (#6455) * Proxistore Bid Adapter: add cookieless url endpoint & use floor module (#6427) * use floor module * call cookieless endpoint when necessary * test endpoint url * change url endpoint * delete console log * fix tests * add language to url * use ortb interface * unit test * update test unit * create proxistore module * add unit tests and documentation * delete modules * delete module * add proxistore rtd submodule * delete proxistore module * spacing * change url * AdYoulike Bid Adapter: Add an "Insertion" tracking for Native mediatype (#6481) * add insertion event * add missing campaign ID parameter * update unit test with new tracking checked * Dspx Bid Adapter : add user sync support (#6456) * Add sync support for dspx adapter * Dspx Bid Adapter : add user sync support Co-authored-by: Alexander <avj83@list.ru> * Multibid Module: add new module to handle multiple bids from single bidder & update rubicon adapter (#6404) * Multibid module - create new module - Expands the number of key value pairs going to the ad server in the normal Prebid way by establishing the concept of a "dynamic alias" First commit * Continued updates from 1st commit * Adding logWarn for filtered bids * Update to include passing multibid configuration to PBS requests * Update to rubicon bid adapter to pass query param rp_maxbids value taken from bidderRequest.bidLimit * Update to config to look for camelcase property names according to spec. These convert to all lowercase when passed to PBS endpoint * Adjust RP adapter to always include maxbids value - default is 1 * Added support for bidders array in multibid config * Fixed floor comparison to be <= bid cpm as oppossed to just < bid cpm. Updated md file to fix camelCase tpyo * Update to include originalBidderRequest in video call to prebid cache * Update to ignore adpod bids from multibid and allow them to return as normal bids * Adding uid2 to submodules.json (#6508) * NextRoll ID System: add new ID module (#6396) * Add Nextroll ID Module * Add nextroll to eids * Make configuration value names consistent with Adapter Module * Use parnerId instead of sellerId * Add nextroll to userId and eids md files * Remove storage configuration * Rename nextroll -> nextrollId * Add nextrollId to common ID specs * Qwarry Bid Adapter: add GDPR and consent string handling (#6489) * qwarry bid adapter * formatting fixes * fix tests for qwarry * qwarry bid adapter * add header for qwarry bid adapter * bid requests fix * fix tests * response fix * fix tests for Qwarry bid adapter * add pos parameter to qwarry bid adapter * qwarryBidAdapter onBidWon hotfix * Change bidder endpoint url for Qwarry adapter * add referer JS detection * use bidderRequest.refererInfo * fix tests * GDPR consent string support * NPE fix Co-authored-by: Artem Kostritsa <akostritsa@akostritsa.com> Co-authored-by: Alexander Kascheev <akascheev@asteriosoft.com> Co-authored-by: pro-nsk <32703851+pro-nsk@users.noreply.github.com> * Zemanta Bid Adapter: add support for new params & consent strings to usersync URL (#6468) * add gvl id to spec * add support for bcat and badv params * add consent strings to usersync url * add bcat and badv params to doc * Automatad Bid Adapter: Add meta.advertiserDomains to bid response (#6509) * added bid meta with advertiserDomains * Adhese Bid Adapter: add support for caching video content (#6501) * adpod category support test * Revert "adpod category support test" This reverts commit 70a3cf2ad5db94757addd9e08c3a083caca282d0. * adpod category support test * Revert "adpod category support test" This reverts commit 70a3cf2ad5db94757addd9e08c3a083caca282d0. * Adhese Bid Adapter: cache video content Co-authored-by: Tim Sturtewagen <tim@adhese.com> Co-authored-by: Mateusz <mateusz@adhese.eu> * update apacdex unit test to disable debug mode (#6511) * Telaria: not setting adid (#6507) * Prebid 4.33.0 Release * automate-creation of modules.json file * Prebid upgarde automate- test pull request created through git api please ignore it (#455) * Support for ext object in icon * automate-creation of modules.json file * Fixed merge issue and test cases fixes * Check for valid sizes only * Unit test cases for the change * automate-creation of modules.json file * Fixed Merge issues * UOE-4404 if adslot and mediatype both contain sizes * automate-creation of modules.json file * Initial User Id Module * Updated modules.json * automate-creation of modules.json file * Server Side throttling based on condition * Condition for all partners throttled * Changed gulp task dependencies * Build Time Optimization * changed unused gulp packages * Updated Package.json * automate-creation of modules.json file * resolved conflixt * automate-creation of modules.json file * IdentityPartners * Changes for Hashed Key and parseAdSlot logic * Fix for custom module * making call secure of ow * Removed implicit customId system and added it as a separated submodule * Making server side calls secure and flag secure to 1 * Changed unifiedId from implicit to explicit * Updated The code to fix text cases * Fixed unit test cases * Took latest for all ids * Fixed the linting issue * Custom Data support and ParseInt for Id5 * Fixed custom data * Updated function call * Changed Event from Auction End to Request Bid * added secure flag * Revert "Open identity" * Revert "Revert "Open identity"" * First Party Id name updated for cookies * PubMatic Handle first Party Id * Pubmatic alias * Handle regex pattern in logger for Hybrid Implementation * Increment pre version * Somo: fix an issue where the requestId was being set to the wrong value (#4596) * Sovrn ccpa support legacy (#4623) * sovrn ccpa support * use array map/join instead of object.entries * TripleLift: CCPA legacy support (#4641) * Add CCPA query param * Simplify check for usPrivacy argument * pbsBidAdapter currency fix for legacy branch (#4642) * pbsBidAdapter currency fix for legacy branch * fixed unit tests * Prebid 2.44.1 Release * Revert "Prebid 2.44.1 Release" This reverts commit 105313b792b79002c0ada3301d154afd49adb7cd. * fix a bug when the iframe locator is not present on page (#4637) * fix a bug when the iframe locator is not present on page * clean up * Prebid 2.44.1 Release * increment pre version * Index Exchange: CCPA support (#4662) * support for us privacy (CCPA) (#4665) * Added CCPA support for legacy (#4663) * Update CCPA v3 (#4677) CCPA support V2 compatibility Sample tag update * automate-creation of modules.json file * Medianet: CCPA support added (#4656) * Ccpa legacy support for OneVideo (#4648) * outstream changes * removing global filtet * reverting page * message * adapter change * remove space * testcases * testpage * spaces for test page * renderer exist case * reverting package-lock.json * adding schain object * adding tagid * syntaxx error fix * video.html * space trailing * space * tagid * inventoryId and placement * rewarded video * added unit test case * ccpa cahnges * ccpa change * test page * test page change * test page change 2 * change the variable * handling the case if both GDPR and CCPA case * handiling both cases * test cases * legacy ccpa support * Update oneVideoBidAdapter.js * Add us privacy 2.X (#4669) * cedato adapter gdpr and usp compliance (#4686) * Fidelity Media Bid Adapter 2.44.x legacy. CCPA support. (#4652) * Fidelity Media Bid Adapter v2.44.x. CCPA support. * Fidelity Media Bid Adapter v2.44.x. CCPA support. * add dh adapter for legacy prebid 2.x (#4670) * Prebid 2.44.2 Release * automate-creation of modules.json file * Support for CCPA * Adding tracker in vast creative before cache * add adform alias adform2 * Updated First Party Module * Updated our adapter to have firstpartyid * automate-creation of modules.json file * Update key value pair for video in openwrap * Server side syncup in accordance with latest filter settings * Support for Eids in PubMaticServerBidAdapter * Fix for pubCommonId * Fix for pubmatic server bid adapter * fix for player size and considering w & h for video * automate-creation of modules.json file * Fixed test issues * automate-creation of modules.json file * fix test cases * Pull changes for dspid and seatid from prebid master * Support for buyerId * Updated location of buyid * automate-creation of modules.json file * Changes for consuming targeting from server side * Fix test cases * Updated rubiconBidAdapter for alias * adding sspId * UOE-5262 : OpenWrap: Add Secondary Ad Generation Bidder * bluebillywig outstream renderer * Fix an issue with replacing Renderer * Replaced Renderee * code review comments * automate-creation of modules.json file * added missing adatpers * updating package.json for prod dependecies * updated namespace * Fix for SSP ID * fixed test cases * took latest * ternay adapters * Update adformBidAdapter.js * automate-creation of modules.json file * updated modules.json removed audienceNetworkBidAdapter * wiid fix * Targeting Keys * dg bid adapter * automate-creation of modules.json file * fixes for dfp * removed audienceNetwork from modules.json * Fix for UOE-5694 * Fix for test cases * regex support * OpenWrap Nightly Release v21.1.0 (#417) * support for video in hybrid profiles * added newBid.mediaType for pubmaticServerBidAdapter * unit test case for video request * reverted debug flag * Changes for UOe-5712/5705 * Manually took the changes for DVC related info * Fix Typo * piid for hybrid profiles * removed fix for piid from staged_nightly * Removing OW PB Same Changes regarding device as it will be releaed in Q1 * Log SSPId in piid for pubmatic * OpenWrap Release v21.3.0 (#426) * support for video in hybrid profiles * added newBid.mediaType for pubmaticServerBidAdapter * unit test case for video request * reverted debug flag * Changes for UOe-5712/5705 * Manually took the changes for DVC related info * Fix Typo * piid for hybrid profiles * removed fix for piid from staged_nightly * sspId for pubmatic only (#418) * fix to remove redundant validation for datatype for partner value - UOE-5788 * fix for UOE-5788 * moved changes for UOE-5788 in hasRequiredParams function * consent string gets overwritten when IH is enabled * Feature/secondary alias (#425) * gps secondary bid adapter * fix alias * remove dvc since it will go with ow prebid same Co-authored-by: manisha <manisha.satpute@pubmatic.com> Co-authored-by: Manasi <pm-manasi-moghe@users.noreply.github.com> * Staged nightly (#427) * support for video in hybrid profiles * added newBid.mediaType for pubmaticServerBidAdapter * unit test case for video request * reverted debug flag * increment pre version * Britepool user id module update (#5750) * adding britepool_pubparams dynamic variable lookup and merge into submodule params if exists * adding support for gdpr consent string in query params * adding tests for britepool_pubparams * adding doc block for consentData * adding pixel on success * - ensures id resolution pixel only fires when authoritative information is not present - adds tests for id resolution pixel * Add a new param cid to bridgewellBidAdapter (#5764) * pass a new param cid to bridgewellBidAdapter * update the markdown file for bridgewellBidAdpter * Refactor refererDetection to allow for URL discovery on AMP pages. (#4846) * Refactor refererDetection to allow for URL discovery on AMP pages. * Update import to include extension. * Intentiq id add url params (#5771) * Add new url params from config * Add intentIqIdSystem_spec.js tests class * added instream video ad support (#5766) * added adapters for gjirafa and malltv * interpretResponse fix for empty result * updated testing propertyId and placementId * added instream video ad support * Single request for multple bids * feat(sublimeBidAdapter): updating sublimeBidAdapter module (#5726) - handle new notifyId parameter; - bumping version to 0.6.0. * Add GVL ID and bidder code to CriteoId module (#5781) * Add GVL ID and bidder code to CriteoId module * Add gvlid as property to CriteoIdSubmodule Co-authored-by: Jesus Alberto Polo Garcia <ja.pologarcia@criteo.com> * Update BrightMountainMedia cookie sync URL (#5740) * Convert id5id to an object to support passing additional data points to platforms (#5756) * move id5id to an object to support passing linkType and other data in the future * update bid adapters supporting the ID5 ID to use the new object instead of a string * remove `.only` from test * Smaato: Support in-app use cases (#5765) * Added GVLID to Media.net Analytics Adapter (#5789) Co-authored-by: monis.q <monis.q@media.net> * Add video ad support to ablida bid adapter (#5782) * add onBidWon function, add bidder adapter version to bid requests * add support for native * use triggerPxel instead of ajax, because ajax was called 3 times with native * add gdpr consent to bid requests * update tests * add video ad support * Add adrelevantis adapter (#5735) * Update adrelevantis adapter * Update Adrelevantis Bid Adapter and Add Unit Tests Commit changes suggested by @jsnellbaker on pull request #5735 * Adnow bidder (#5738) * Add AdNow bid Adaptor * Fix problems by PR comments. * PR comments: - Use only secure endpoint. - Use adUnit mediaTypes instead of mediaType param in buildRequests. - Pass correct sizes to the endpoint for banner and native. - Fix adnowBidAdaper.md examples. - Fix and add new tests in adnowBidAdaper_spec.js * rename test * Restore package-lock.json from master * Fix sizes of bid response object for banners. * Fix adapters tests. * Improve error and documentation for publisherId (#5788) - The error message you get if you use a publisherId that is a JS numeric instead of a JS string is not super helpful if you aren't familiar with JS internals. Update the warning message to give a suggestion on a solution, and update the markdown documentation to explictly state that the ID needs to be wrapped in quotes. * SpotX bid adapter: add page parameter (#5784) * Media.net Analytics improvements (#5755) * medianetAnalyticsAdapter improvements * medianetAnalyticsAdapter improvements * review changes * fixed eslint Co-authored-by: monis.q <monis.q@media.net> * adagio Bid Adapter: add support for CCPA, COPPA (#5749) Co-authored-by: Clément besse <clement.besse@gmail.com> * PubMatic analytics adapter: Not passing GDPR information (#5791) * added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source …

add warning for non-string adSlots

a390afe

- and update the markdown file to say they should be strings

patmmccann reviewed Feb 12, 2021

View reviewed changes

patmmccann approved these changes Feb 12, 2021

View reviewed changes

be more specific in explanatory comment

b7acdf8

mkendall07 assigned Fawke Feb 12, 2021

mike-chowla self-requested a review February 15, 2021 20:33

mike-chowla approved these changes Feb 15, 2021

View reviewed changes

Fawke self-requested a review February 16, 2021 12:27

Fawke approved these changes Feb 16, 2021

View reviewed changes

Fawke added LGTM minor maintenance labels Feb 16, 2021

Fawke merged commit c94ee67 into prebid:master Feb 16, 2021

Fawke changed the title ~~add warning for non-string adSlots~~ Pubmatic Bid Adapter: Add warning for non-string adSlots Feb 16, 2021

jsut deleted the pubmatic-numbers branch February 16, 2021 16:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pubmatic Bid Adapter: Add warning for non-string adSlots #6304

Pubmatic Bid Adapter: Add warning for non-string adSlots #6304

jsut commented Feb 12, 2021

patmmccann Feb 12, 2021

jsut Feb 12, 2021

mike-chowla left a comment

Fawke left a comment

Pubmatic Bid Adapter: Add warning for non-string adSlots #6304

Pubmatic Bid Adapter: Add warning for non-string adSlots #6304

Conversation

jsut commented Feb 12, 2021

Type of change

Description of change

patmmccann Feb 12, 2021

Choose a reason for hiding this comment

jsut Feb 12, 2021

Choose a reason for hiding this comment

mike-chowla left a comment

Choose a reason for hiding this comment

Fawke left a comment

Choose a reason for hiding this comment