Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eTarget Bid Adapter: add "getMetaData" function to adapter #6830

Closed
wants to merge 1 commit into from
Closed

eTarget Bid Adapter: add "getMetaData" function to adapter #6830

wants to merge 1 commit into from

Conversation

etargetse
Copy link
Contributor

@etargetse etargetse commented May 26, 2021

getMetaData used to gether useful information from publisher site

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

getMetaData used to gether useful information from publisher site
@ChrisHuie
Copy link
Collaborator

@etargetse looks like that worked :) Don't forget to add back in the test too if you could

@ChrisHuie ChrisHuie changed the title new feature "getMetaData" eTarget Bid Adapter: add "getMetaData" function to adapter May 26, 2021
bidder: 'etarget',
gdpr: gdprObject
};

function getMetaData() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the request here, please also gather this info from the ortb2 object

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem is that ortb2 is available only when portal will fill info into this object, what we want to achieve is to gather info every time our adapter will be used. Is there any leagal/technical problem with our implementation? Why we cant collect info by ourselfs?

Copy link
Contributor Author

@etargetse etargetse May 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix #6650 ; it's being enforced imminently

I started working on this feature but i need to create new fork because when i edit things on old fork then circleci have always problems with somethink. But i cant create new fork before this pull requerst is closed. So can you please merge this new feature if there is no real reason why not to merge? THANKS.

@patmmccann
Copy link
Collaborator

Please also fix #6650 ; it's being enforced imminently

@etargetse
Copy link
Contributor Author

Please also fix #6650 ; it's being enforced imminently

working on it

@etargetse
Copy link
Contributor Author

etargetse commented Jun 1, 2021

@ChrisHuie @patmmccann Hey guys, we are in bit hurry, please if our code has no legal or coding errors can you please review our adapter and merge it into master repo? Thanks.

@ChrisHuie
Copy link
Collaborator

@etargetse you still need to add back the unit tests before this pr can get approved please

@etargetse
Copy link
Contributor Author

i am closing this pull request because when i update test script then it will fail because this new feature is not included

@etargetse etargetse closed this Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants