Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgkeyword RTD Provider: add new real time data module #6912

Merged
merged 15 commits into from
Jun 2, 2021
Merged

dgkeyword RTD Provider: add new real time data module #6912

merged 15 commits into from
Jun 2, 2021

Conversation

mediaconsortium-develop
Copy link
Contributor

@mediaconsortium-develop mediaconsortium-develop commented Jun 2, 2021

Type of change

Description of change

We want to add Real Time Data Submodule

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.
https://www.suuiiisya.com/test/agytest/rt_module_test.html

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

we want to set some keywords before requestBids() in our customer's site.
The keywords are real time data and can be got to access our partner's service site.
So we want to start requestBids() after getting keywords only when our keywords service use.

@ChrisHuie
Copy link
Collaborator

@osazos I tested this a few times and looks stable to me

@ChrisHuie ChrisHuie changed the title Feature/dgkeyword rtd provider v2 dgkeyword RTD Provider: add new rtd module Jun 2, 2021
@ChrisHuie ChrisHuie changed the title dgkeyword RTD Provider: add new rtd module dgkeyword RTD Provider: add new real time data module Jun 2, 2021
@osazos osazos merged commit 948cb1d into prebid:master Jun 2, 2021
K-JBoon added a commit to bluebillywig/Prebid.js that referenced this pull request Jun 3, 2021
* 'master' of github.com:prebid/Prebid.js: (303 commits)
  BridgewellBidAdapter: modify to include user ids in the bid request object (prebid#6845)
  GridNMBidAdapter: Use absent in video params data from mediaTypes (prebid#6817)
  PubMatic: For Video: bid.mediaTypes.video.mimes OR bid.params.video.mimes should be present and must be a non-empty array (prebid#6926)
  Increment pre version
  Prebid 4.42.0 Release
  Seedtag Bid Adapter: read video params from mediaTypes, and allow override from bidder params, support passing adomain (prebid#6888)
  Medianet bid adapter: MD update for video parameters. (prebid#6922)
  dgkeyword RTD Provider: add new real time data module  (prebid#6912)
  Smaato bid adapter: Rework multi imp support (prebid#6814)
  Adot Bid Adapter: add the advertising domains support (prebid#6876)
  Update Adtelligent, Adtarget, ViewDeos   adapters to support adomain (prebid#6917)
  LockerDome Bid Adapter: support for meta.advertiserDomains  (prebid#6921)
  Sublime Bid Adapter : Add support for meta.advertiserDomains (prebid#6920)
  Brightcom Bid Adapter: use getFloor function (prebid#6918)
  AdYouLike Bidder: Handle advertiser domains (prebid#6916)
  relaido Bid Adapter: Add meta OBJ to BidResponse (prebid#6914)
  Jixie Bid Adapter: add support for advertiserDomains (prebid#6898)
  Onomagic Bid Adapter: use getFloor function (prebid#6907)
  Sharethrough Bid Adapter: Use getFloor module for Prebid 5.0 compliance (prebid#6874)
  Accept outstream renderers defined in mediatype for PBS (prebid#6896)
  ...
@mediaconsortium-develop
Copy link
Contributor Author

mediaconsortium-develop commented Jun 8, 2021

Thank you for merging to muster.
Now I checked prebid.js download site, and I found that dgkeyword real time sub-module can not select.
I think dgkeyword real time sub-module can use only when using gulp build.
https://docs.prebid.org/download.html

So I want to change, our dgkeyword real time sub-module can download from the prebid.js download site.

I edited the pull request($6912) first message "official adapter submission" check on .
Will you please update the prebid.js download site?

@mediaconsortium-develop
Copy link
Contributor Author

mediaconsortium-develop commented Jun 8, 2021 via email

@patmmccann
Copy link
Collaborator

patmmccann commented Jun 8, 2021 via email

@patmmccann
Copy link
Collaborator

patmmccann commented Jun 8, 2021 via email

prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
* re-open pull request reference prebid#6410

* delete Overview

* for test , comment out.

* for test, comment out.

* for test. comment out setConfig.

* execute resetConfig aftet test.

* execute resetConfig after test.

* set emppty bidderConfig after test

* fix setBidderConfig and test code

* fix test code.

* fix

* for test resetBidderConfig in config

* resetBidderConfig afterEach

* setBidderConfig is not executed when ci test
@mediaconsortium-develop mediaconsortium-develop deleted the feature/dgkeywordRtdProvider_v2 branch January 12, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants