Audiencerun Bid Adapter 1.1.0

[audiencerun]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

• Removing adID parameter (see adId when set by bid adapters in the response object must be unique #6381)
• Add new pixel to track timeout
• Some changes to retrieve page url

• contact email of the adapter’s maintainer github@audiencerun.com

Other information

[patmmccann]

Please fix floors issue #6465 , #6650, and make this on timeout behavior configurable

[patmmccann]

@audiencerun can you confirm this is intentionally still in draft?

[audiencerun]

• Adapter does not seem capable of supporting advertiserDomains #6650 are fixed
• For Bid adapters that support floors must support the floors module #6465 we are working on it, meanwhile it's possible to validate this MR without the floor module ?
• For onTimeout configurable, could you explain more specifically what you mean @patmmccann ?

Thanks

[patmmccann]

6465 fixes are required for pb5 inclusion

Making ontimeout configurable would just mean wrapping the call in something like if(!getConfig(...)) {}

Alternatively, you could just add a disclosure you make calls ontimeout to your doc.

[Rothalack]

@audiencerun Did you still need to make the timeout change?

[Rothalack]

Hey @audiencerun just checking back in on this. If I'm understanding correctly you need to make a documentation update or an update to how you're doing onTimeout. Are you intending to do either of those or am I misunderstanding the status of this?

[audiencerun]

Hi, we have added some fixes:

• Support for advertiserDomains Adapter does not seem capable of supporting advertiserDomains #6650 has been added
• Support for floors module Bid adapters that support floors must support the floors module #6465 has been added

However, some test cases failed for other adapters on CircleCI. Please let us know If we have to do something on our side or you can simply re-run the tests?

[Rothalack]

Rerunning the test worked, it failed on a normal timeout issue we see all the time on tests. My tests worked as well. This looks good to go!

[audiencerun]

Hi @Rothalack,

Just noticed that there is a disclosure for our adapter on https://docs.prebid.org/dev-docs/bidders/audiencerun.html#description about adId (#6381). Should we submit another pull request to update the documentation too?

[Rothalack]

Hi @Rothalack,

Just noticed that there is a disclosure for our adapter on https://docs.prebid.org/dev-docs/bidders/audiencerun.html#description about adId (#6381). Should we submit another pull request to update the documentation too?

Definitely! You should be able to make that PR and mention this PR to show the code.