Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prebid Server Bid Adapter: added ortb2Imp.instl support #8040

Closed
wants to merge 1 commit into from

Conversation

TheMediaGrid
Copy link
Contributor

Type of change

  • Feature

Description of change

For testing instl field in s2s go adapters, we need to update Server-to-Server Testing module to make possible to sent instl field

@ChrisHuie ChrisHuie self-requested a review February 9, 2022 17:33
@ChrisHuie ChrisHuie self-assigned this Feb 9, 2022
@patmmccann patmmccann added the needs 2nd review Core module updates require two approvals from the core team label Feb 10, 2022
@patmmccann patmmccann changed the title prebidServerAdapter: added ortb2Imp.instl support prebid Server Bid Adapter: added ortb2Imp.instl support Feb 10, 2022
@patmmccann
Copy link
Collaborator

patmmccann commented Feb 10, 2022

Is this useful? I thought PBS took the whole object already

Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this PR is not needed when #7831 is imminent.

@patmmccann
Copy link
Collaborator

@TheMediaGrid thanks for your contribution! Could you review and comment on #8062

Will this solve your need?

@patmmccann
Copy link
Collaborator

@TheMediaGrid your test coverage was added in #8159 ; thanks for raising this!

@patmmccann patmmccann closed this Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants