Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yandex Bid Adapter: initial release #8183

Merged
merged 2 commits into from
Apr 2, 2022

Conversation

Saveliev
Copy link
Contributor

@Saveliev Saveliev commented Mar 15, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: 'yandex',
  params: {
    pageId: 346580,
    impId: 143,
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie changed the title add Yandex Bidder Adapter Yandex Bid Adapter: add new bid adapter Mar 16, 2022
@ChrisHuie ChrisHuie requested a review from osazos March 16, 2022 10:27
@Saveliev
Copy link
Contributor Author

Saveliev commented Mar 18, 2022

@osazos,
bro, please look at this pull request

@ChrisHuie ChrisHuie requested review from ChrisHuie and removed request for osazos March 25, 2022 17:22
@ChrisHuie ChrisHuie assigned ChrisHuie and unassigned osazos Mar 25, 2022
@ChrisHuie
Copy link
Collaborator

@Saveliev I will make sure and get this added this week. Can you please pull in recent merges to master because looks like we still have some errors

@Saveliev
Copy link
Contributor Author

@ChrisHuie I performed rebase for my PR, but I see one failed test for the Edge browser. I don't think it can be related to my changes.
Can i do anything else?

@ChrisHuie
Copy link
Collaborator

Reran tests and they passed :) Can you please in add handling for adomain into this pr. That is now a prebid standard

@patmmccann patmmccann changed the title Yandex Bid Adapter: add new bid adapter Yandex Bid Adapter: initial release Apr 2, 2022
@patmmccann patmmccann merged commit 02ea759 into prebid:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants