Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biddo Bid Adapter: add new bid adapter #8206

Merged
merged 10 commits into from
Apr 5, 2022
Merged

Conversation

llays
Copy link
Contributor

@llays llays commented Mar 23, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: 'biddo',
  params: {
    zoneId: 379783,
  }
}

modules/biddoBidAdapter.js Show resolved Hide resolved
modules/biddoBidAdapter.js Outdated Show resolved Hide resolved
test/spec/modules/biddoBidAdapter_spec.js Outdated Show resolved Hide resolved
@msm0504
Copy link
Contributor

msm0504 commented Apr 5, 2022

@llays Thanks for updating the test zone id. I now see responses from your server.

However, I'm still not clear on why this needs to be a new adapter. Since all of the code is the same, why can't this be an alias of the invamia adapter? The endpoint could then be conditionally set based on a request's bidderCode.

@llays
Copy link
Contributor Author

llays commented Apr 5, 2022

@msm0504 Currently, we've decided to separate business by demand sources and Biddo will have separate team of developers and different business logic on delivery servers. To make it cheaper this adapter is based on invamia's adapter, but in the near future biddo's dev team will go on their own. Thank you!

@msm0504 msm0504 merged commit e2c4086 into prebid:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants