Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taboola bid adapter: initial release #8385

Closed
wants to merge 83 commits into from
Closed

Conversation

mikizi
Copy link
Contributor

@mikizi mikizi commented May 8, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: 'taboola',
  params: {
          tagId: 'test-1',
          publisherId: 'test'
     }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer : prebid@taboola.com
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

  • A link to a PR on the docs repo at this link

})

describe('handle userid ', function () {
it('should get user id from local storage', function () {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure your tests work post #8279

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like other adapters tests are failing in my last 2 builds
there is away to rerun the job without making a new push to my brunch?
BTW it passed now...

Copy link
Contributor Author

@mikizi mikizi May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @patmmccann .@ncolletti - did you had a chance to look at it after I made the change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it doesnt appear to be aware of the allow in the tests

@patmmccann patmmccann changed the title Add taboola bid adapter Taboola bid adapter: initial release May 17, 2022
@patmmccann
Copy link
Collaborator

@mikizi in order to do this 0784363 (thanks very much!)

it looks like you are now changing 43 files, could you fix?

@ChrisHuie
Copy link
Collaborator

@mikizi could you try repulling from master. Looks like this pr includes other prs right now. Thanks

@patmmccann
Copy link
Collaborator

reopened on #8483

@patmmccann patmmccann closed this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.