-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taboola bid adapter: initial release #8385
Conversation
taboolaBidAdapter_spec.js - new UT
taboolaBidAdapter_spec.js - new UT
* refactor code for better readability * small fix in UT
* add relevant Ut * small fixes in UT
…-taboola-bid-adapter Merge from prebid
…d-taboola-bid-adapter
* add relevant Ut * small fixes in md
* add relevant Ut * small fixes
* add relevant Ut * small fixes
* update UT * Update banner End point structure
Add taboola bid adapter
}) | ||
|
||
describe('handle userid ', function () { | ||
it('should get user id from local storage', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make sure your tests work post #8279
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like other adapters tests are failing in my last 2 builds
there is away to rerun the job without making a new push to my brunch?
BTW it passed now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @patmmccann .@ncolletti - did you had a chance to look at it after I made the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it doesnt appear to be aware of the allow in the tests
* refactor code for better readability * small fix in UT
* add relevant Ut * small fixes in UT
* add relevant Ut * small fixes in md
* add relevant Ut * small fixes
* add relevant Ut * small fixes
* update UT * Update banner End point structure
…otocols + update Ut
update md (placement + pub )
@mikizi could you try repulling from master. Looks like this pr includes other prs right now. Thanks |
reopened on #8483 |
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide: