Bugfix: RemoteFileSyncer handling of error responses #3440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
RemoteFileSyncer never validated the server response status code and always saved the response body unless the request has timed out. This led to RemoteFileSyncer wiping perfectly valid files on periodic sync in case the remote server errors out for whatever reason.
🧠 Rationale behind the change
This PR adds a new check for
200
response status code before attempting to save the downloaded file.Another bugfix here is that the RemoteFileSyncer now actually follows redirects.
🧪 Test plan
New logic is covered with unit tests.
🏎 Quality check