Add tests for Zero Non Deal Bids Warning Only in Debug #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marki1an
requested changes
Oct 31, 2024
Comment on lines
116
to
117
| it.dooh = Dooh.defaultDooh | ||
| }, |
Comment on lines
274
to
275
| test = 0 | ||
| ext.prebid.debug = 0 |
There was a problem hiding this comment.
If you don't mind, please make test and debug like enum DISABLED(0), ENABLED(1)
Comment on lines
290
to
292
| then: "Invalid bid should be deleted" | ||
| assert response.seatbid.size() == 0 | ||
|
|
There was a problem hiding this comment.
Strangely, seat bid is not about invalid bids, better to check the seatNonBid field.
Comment on lines
279
to
282
| def bidResponse = BidResponse.getDefaultBidResponse(bidRequest) | ||
| def bid = bidResponse.seatbid.first().bid.first() | ||
| bid.dealid = dealId | ||
| bid.price = bidPrice |
There was a problem hiding this comment.
def bidResponse = BidResponse.getDefaultBidResponse(bidRequest).tap{
it.bid.tap{
dealid = dealId
price = bidPrice
}
}
| 1 | 0 | null | null | ||
| } | ||
|
|
||
| def "PBS should drop invalid bid without debug error when request debug disabled and bid price is #bidPrice and deal id is #dealId"() { |
There was a problem hiding this comment.
Did the bidder call happen in such case?
| def "PBS should update 'adapter.generic.requests.bid_validation' metric when bid validation error appears"() { | ||
| given: "Initial 'adapter.generic.requests.bid_validation' metric value" | ||
| def initialMetricValue = getCurrentMetricValue(defaultPbsService, "adapter.generic.requests.bid_validation") | ||
| def "PBS should only drop invalid bid without discarding whole seat without debug error when request debug disabled "() { |
There was a problem hiding this comment.
Please add a test to the end of the spec.
Comment on lines
332
to
333
| then: "Invalid bids should be deleted" | ||
| assert response.seatbid?.first()?.bid*.id == [validBidId] |
There was a problem hiding this comment.
Better description: "Bid response contains only valid bid"
marki1an
approved these changes
Nov 4, 2024
Compile-Ninja
deleted the
functional-tests/drop-zero-non-deal-bids-debug-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes? Are there any
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check