consumable: Correct width and height reported in response. #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prebid Server now responds with the width and height specified in the Bid Response from Consumable. Previously it would reuse the width and height specified in the Bid Request. That older behaviour was ported from an older version of the prebid.js adapter but is no longer valid.
DGarbar
suggested changes
Aug 27, 2020
src/main/java/org/prebid/server/bidder/consumable/model/ConsumableDecision.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/consumable/model/ConsumableDecision.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/consumable/ConsumableBidderTest.java
Outdated
Show resolved
Hide resolved
|
I've made the requested changes. |
DGarbar
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corresponds to prebid/prebid-server#1459.
Corrects the width and height specified in the bid response.
After this change, Prebid Server uses the width and height specified in the bid response from Consumable.
Previously, Prebid Server would reuse the width and height specified in the bid request. That older behaviour was ported from an older version of the prebid.js adapter but is no longer valid.
I am submitting this PR on behalf of Consumable, cc @naffis.