Privacy Request Metrics #1378
Closed
Privacy Request Metrics #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guscarreon
requested changes
Jul 7, 2020
exchange/utils.go
Outdated
| parsedConsent, err := vendorconsent.ParseString(consent) | ||
| if err == nil { | ||
| cleanMetrics.gdprTcfVersion = int(parsedConsent.Version()) | ||
| version := int(parsedConsent.Version()) | ||
| privacyLabels.GDPRTCFVersion = pbsmetrics.TCFVersionValue(version) |
There was a problem hiding this comment.
Shouldn't this call refer to the TCFVersionToValue function found in pbsmetrics/metrics.go instead?
280 func TCFVersionToValue(version int) TCFVersionValue {
281 switch {
282 case version == 1:
283 return TCFVersionV1
284 case version == 2:
285 return TCFVersionV2
286 }
287 return TCFVersionErr
288 }
pbsmetrics/metrics.go
There was a problem hiding this comment.
Despite the fact that this part of the code appears to be covered by test cases, I could not find a test inside the exchange directory asserting the contents of the third return value of cleanOpenRTBRequests, privacyLabels pbsmetrics.PrivacyLabels. Should we include a test to assert this logic?
There was a problem hiding this comment.
You're exactly right. Bug fixed. Tests added.
|
This PR isn't behaving correctly. Something is out of sync. I'm going to close and recreate. |
hhhjort
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #1360 to extend to CCPA, COPPA, and LMT for requests.