Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GumGum: Override the default currency. #3928

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MartinGumGum
Copy link

This PR resolves an issue where bid currency from the Ad Exchange was not being set in the Prebid Server's Go version, causing the currency to default to USD in all cases. The bid currency will now be dynamically set based on the response from the Ad Exchange, ensuring proper handling of different currencies in the bidding process.

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, f481c0d

gumgum

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:23:	MakeRequests		87.1%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:84:	MakeBids		76.2%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:130:	preprocess		71.4%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:189:	getBiggerFormat		100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:213:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:223:	Builder			100.0%
total:									(statements)		82.2%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 30c7c78

gumgum

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:23:	MakeRequests		87.1%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:84:	MakeBids		81.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:130:	preprocess		71.4%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:189:	getBiggerFormat		100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:213:	getMediaTypeForImpID	100.0%
github.com/prebid/prebid-server/v2/adapters/gumgum/gumgum.go:223:	Builder			100.0%
total:									(statements)		83.2%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant