Replace all placeholders with the corresponding ortb assets

[anitaschiller]

At the moment only the first occurrence of an ortb placeholder is replaced by the asset value, the second one will be replaced by an empty string.

I found this issue because our native design template uses the same placeholder twice for responsiveness reasons. Depending on the viewport size, one of them has the CSS property display: none but they are both present in the template. When the second occurrence gets displayed, the html element is always empty - I would expect all placeholders with the corresponding asset id to be replaced though.

Thank you for checking! 😊

[musikele]

Hi there. I request only one change: to add a test case.

It'll be very easy, infact I have just wrote it for you :D

in nativeAssetManager_spec.js , in test "no placeholders found but requests all assets flag set - adTemplate - openRTB", add a duplicate placeholder (for example I added <h2>##hb_native_asset_id_1##</h2>, that corresponds to new value ) and then test with

// test that we are replacing ALL assets occurrences occurrences 
expect(([...win.document.body.innerHTML.match(/new value/g)] || []).length, "expected 2 occurrences of \"new value\"").to.equal(2);

[anitaschiller]

@musikele thanks for the test, it's now available in the code 😁.

[musikele]

LGTM