Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some comments to nativeAssetManager.js #233

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Adding some comments to nativeAssetManager.js #233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7e9e7a
Adding some comments to nativeAssetManager.js
bretg Jun 21, 2024
68301e7
Update src/nativeAssetManager.js
bretg Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/nativeAssetManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,11 +333,17 @@ export function newNativeAssetManager(win, nativeTag, mkMessenger = prebidMessen
renderPayload.ortb = data.ortb;
}

// if there's a rendererUrl, we need to check whether it's already been loaded.
// There are 3 scenarios:
// 1) it's already been loaded (window.renderAd is present)
// 2) it is currently being loaded (through a script tag with id "pb-native-renderer")
// 3) it hasn't been loaded yet
// 1 and 2 seem intended to work with logic in nativeRenderManager.js, which (sometimes) loads rendererUrl through a <script id="pb-native-renderer">, but they could conceivably be used in an undocumented way to embed renderer logic directly in the creative.
if ((data.hasOwnProperty('rendererUrl') && data.rendererUrl) || (hasPbNativeData() && win.pbNativeData.hasOwnProperty('rendererUrl'))) {
if (win.renderAd) {
const newHtml = (win.renderAd && win.renderAd(renderPayload)) || '';

renderAd(newHtml, data);
renderAd(newHtml, data); // this is the renderAd() below, not to be confused with the renderAd() supplied by the rendererUrl script :-/
} else if (document.getElementById('pb-native-renderer')) {
document.getElementById('pb-native-renderer').addEventListener('load', function () {
const newHtml = (win.renderAd && win.renderAd(renderPayload)) || '';
Expand All @@ -360,7 +366,7 @@ export function newNativeAssetManager(win, nativeTag, mkMessenger = prebidMessen
const newHtml = replace(body, data);

win.document.body.innerHTML = newHtml;
callback && callback();
callback && callback(); // all the other scenarios hit the callback via renderAd()
stopListening();
}
}
Expand Down