Fix for so that the impressionTrackers and jsTrackers are called once per adElement #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led once per adElement
|
@idettman @jaiminpanchal27 Could you take a look into this PR? |
jaiminpanchal27
approved these changes
Aug 6, 2019
mkendall07
approved these changes
Sep 9, 2019
idettman
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix corrects an issue that occurs when multiple native placements use the
native-trk.jsscript.The previous code only grabbed the first adElement and executed the imp/js trackers for that ad. This fix will detect all available elements and execute them appropriately.