33Across: Added note for Prebid Server Adapter #2484
Conversation
We support Schain!
Added usp support
Xch 1994: Add video support
Added note to clarify Prebid Server Adapter
| --- | ||
|
|
||
| ### Prebid Server Note: | ||
| The 33Across Adapter in Prebid Server does not support multi-impression requests, and will respond with a 400 level response if more than one impression is present in `$.imp[]` of the request. |
There was a problem hiding this comment.
Are you saying that PBS fails the whole request if 33across gets an imp with both banner and video? That seems extreme. Shouldn't the 33across adapter just choose one of them and run with that? FWIW, that's what the Rubicon adapter does -- if it sees both banner and video, it chooses video.
There was a problem hiding this comment.
Not quite, what the note is saying is that our exchange server does not support SRA and will respond with a 400. We do support multi-format within the same imp however.
|
Please fix conflicts and I'll merge. |
Done. |
Not an issue with the doc true, we were asked to add this note as a clarification to Publishers while we are working to improve the server-side adapter. |
|
Sorry for the delay. I set up a test request to confirm what happens here. I have to say this is a major problem in your PBS adapter... it's job is to prepare data for your endpoint. If your endpoint can't handle SRA, then your PBS adapter isn't doing its job. It should be either:
|
|
@bretg yes we have decided to go with approach No.2 and split imps. I have filed a PR prebid/prebid-server#1609 and am awaiting CR. I know this PR just got merged but I will be filing a follow up PR to remove the NOTE added in anticipation of our adapter's support for multi-imp requests. |
* Add publisher usage docs for 33Across * Added 33Across to partners list * Clarified example pubID * Reinstated changes that got lost during rebase * 33across adapter is GDPR compliant * update docs * added usp support * We support Schain! * Update for video support * fixes to video params * fixed context * fixed instream params * fix for multi-format * Fixed Ad Unit titles * protocols is required * typo fix * Added required bidder param * removed duplicate video params * formatting edits * prebid-server adapter will support only single imp reqs * Updated based in CR * minor fix * resolved merge conflicts Co-authored-by: Gleb Glushtsov <gleb.glushtsov@33across.com> Co-authored-by: Gleb Glushtsov <glebglushtsov@users.noreply.github.com> Co-authored-by: Aparna Hegde <ahegde@AHEGDE-MAC.local> Co-authored-by: Aparna Hegde <ahegde@AHEGDE-MAC.fios-router.home>
Based on feedback from CR in prebid/prebid-server#1557 (comment) added note to clarify how the Prebid Server Adapter will behave when multiple impressions are sent.