Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid 6 legacy code deploy example #3362

Merged
merged 7 commits into from
Nov 10, 2021
Merged

Conversation

patmmccann
Copy link
Collaborator

This is not the right js fiddle yet, please lmk if I am putting this in the correct place / modifying the correct files.

@bretg
Copy link
Contributor

bretg commented Oct 21, 2021

In general, the formatting looks right. My only question would be whether this example needs to sit so high in the examples list in the navbar?

@patmmccann
Copy link
Collaborator Author

It does not; also the fiddle should be correct now

@bretg
Copy link
Contributor

bretg commented Oct 21, 2021

Minor typo in the fiddle... 'annswer'. Is it intended that the 'self-invoked wrapper' script is commented out? What is prebid4ie.js?

        <!-- Module scripts are deferred, so another technique might be (from an annswer at https://stackoverflow.com/questions/29987969/how-to-load-a-script-only-in-ie )
        
        <script>
    // self-invoked wrapper for scoping the `document` variable
    !function( d ) {
        if( !d.currentScript ){
            var s = d.createElement('script')
            s.src = 'prebid4ie.js'
            s.setAttribute('type', 'text/javascript');
            s.setAttribute('async', 'true');
            d.head.appendChild(s)
        } else { 
        var s = d.createElement('script')
            s.src = 'prebid.js'
            s.setAttribute('type', 'text/javascript');
            s.setAttribute('async', 'true');
            d.head.appendChild(s)
        }
    }(document)
</script>  -->

@bretg bretg merged commit fdd07ea into prebid:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants