-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebid.js: new PAAPI module documentation #5135
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I thought this module was meant to run independently from gpt.js / GAM? |
dev-docs/modules/paapi.md
Outdated
pbjs.setConfig({ | ||
paapi: { | ||
enabled: true, | ||
bidders: ['openx', 'rtbhouse'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: given that the default is "all bidders", shouldn't the example omit this parameter?
dev-docs/modules/paapi.md
Outdated
|
||
```js | ||
pbjs.setBidderConfig({ | ||
bidders: ["openx"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: should this be a generic bidder adapter name, like we have for other parameters?
selectively test with one or more bidders as they desire. To enable one or more bidders, use the `setBidderConfig` method | ||
of Prebid.js: | ||
```bash | ||
gulp build --modules=fledgeForGpt,... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verifying that this module name is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's an existing module so renaming it is a breaking change and needs to wait for a major version release.
| ------------ | ------------ | ------------ |------------ | | ||
| fledgeEnabled | Boolean | Enable/disable a bidder to participate in FLEDGE | Defaults to `false` | | ||
|defaultForSlots | Number |Default value for `imp.ext.ae` in requests for specified bidders |Should be 1| | ||
- include this module with your Prebid.js bundle; this also automatically includes the [PAAPI module](/dev-docs/modules/paapi.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the the two similarly named modules confusing. Perhaps it is clear to folks that swim with modules regularly, but is there an explanation or diagram?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One provides support for paapi; the other adds integration between paapi and gpt. This is stated in the overview. I'm not sure if you mean that's not clear enough, or if something else still needs to be explained (what?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that flipping between source and rich diff.
{: .table .table-bordered .table-striped } | ||
|Name |Type |Description |Notes | | ||
| ------------ | ------------ | ------------ |------------ | | ||
| fledgeEnabled | Boolean | Enable/disable a bidder to participate in FLEDGE | Defaults to `false` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this can't be renamed since it would break existing deployed configs.
Could a future looking replacement be introduced, e.g. paapiEnabled
, with fledgeEnabled
deprecated down the road?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we eventually should deprecate this entirely; it's redundant with paapi.enabled
(and fledge.enabled
). If for consistency we also introduce paapiEnabled
, we'll have two things to deprecate.
dev-docs/modules/paapi.md
Outdated
## Related Reading | ||
|
||
- [fledgeForGpt module](/dev-docs/modules/fledgeForGpt.html) | ||
- [FLEDGE](https://github.com/WICG/turtledove/blob/main/FLEDGE.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
Configure GPT slots to use PAAPI. | ||
|
||
**Kind**: static method of pbjs API. Only available when the [fledgeForGpt module](/dev-docs/modules/fledgeForGpt.html) is installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sibling pbjs.getPAAPIConfig
method above indicates this is associated with the PAAPI module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but setPAAPIConfigForGpt
is, as the name suggests, specific to GPT and requires the fledgeForGpt module.
dev-docs/modules/paapi.md
Outdated
layout: page_v2 | ||
page_type: module | ||
title: Module - PAAPI | ||
description: Protected audience API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Protected audience API
s/b
Protected Audience API
@dgirardi -- the fact that the module creates an |
ext: { | ||
ae: 1 | ||
pbjs.setConfig({ | ||
paapi: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fledgeForGpt.autoconfig
is also supported for now. I think it worth mentioning it since it backwards compatible in the current versions.
pbjs.setConfig({
fledgeForGpt: {
autoconfig: false
}
})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That being said, it does produce a warning.
3. Publisher Prebid.js configuration (detailed above) | ||
|
||
When a bid request is FLEDGE enabled, a bid adapter can return a tuple consisting of bids and AuctionConfig objects rather than just a list of bids: | ||
You may then use `setPAAPIConfigForGPT`, typically from a `bidsBackHandler`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add more context here to ensure pbjs.setPAAPIConfigForGPT(); function is invoked within the bidsBackHandler whenever new bids are requested, such as when refreshing adSlots. This is important because auctionConfig needs to be linked with a GPT slot manually when autoconfig is disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisHuie will take a look at your comments @lksharma and make the requested changes. We would then like to merge this to have some documentation at all. @dgirardi , @patmmccann , @dmdabbs would that be fine with you folks? |
@muuki88 , I'd like to make sure @rdgordon-index signs off before we merge this PR, he's been very close to the testing and has been keeping the ID PMC abreast of our progress here. |
Prebid.js
paapi
andfledgeForGpt
module doc updates - prebid/Prebid.js#10930🏷 Type of documentation
📋 Checklist