Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insticator Bid Adaptor: update docs for bidfloor #5307

Merged

Conversation

shubhamc-ins
Copy link
Contributor

@shubhamc-ins shubhamc-ins commented May 9, 2024

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Copy link

netlify bot commented May 9, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit df072af
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/664f442028ef0a00087a4dc0
😎 Deploy Preview https://deploy-preview-5307--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shubhamc-ins shubhamc-ins changed the title update docs for bidfloor Insticator Bid Adaptor: update docs for bidfloor May 9, 2024
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment here prebid/Prebid.js#11472 (comment)

If you only support USD please add a section "floors" and add a disclaimer that you will ignore floors if they don't come in USD. Or that you require the currency module to work properly if you decide to change the implementation.

@muuki88 muuki88 added needs work and removed LGTM labels May 10, 2024
@shubhamc-ins shubhamc-ins requested a review from muuki88 May 13, 2024 10:03
@muuki88 muuki88 added LGTM and removed needs work labels May 13, 2024
@bretg
Copy link
Contributor

bretg commented May 30, 2024

part of 8.51

@bretg bretg merged commit 383dd22 into prebid:master May 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants