Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: QT #5331

Merged
merged 2 commits into from
Jun 12, 2024
Merged

New Adapter: QT #5331

merged 2 commits into from
Jun 12, 2024

Conversation

qt-io
Copy link
Contributor

@qt-io qt-io commented May 21, 2024

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

@netlify Netlify
Copy link

netlify bot commented May 21, 2024 •
edited
Loading

❌ Deploy Preview for prebid-docs-preview failed. Why did it fail? →

Name Link
🔨 Latest commit f8d93a8
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6669c0391a4e9a0008a5bd24

This was referenced May 21, 2024
Merged
Merged
This was referenced May 24, 2024
Merged
Closed
bretg
bretg reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks ok, with 2 suggestions:

  • Generally bid adapters provide some kind of contact information. e.g. "To register with QT, contact sales@example.com"
  • If your PBJS and PBS bid adapters are merged at very different times, you may want to release this doc with one or the other of pbjs and pbs flags as false.

@bretg bretg added the question label May 29, 2024
@qt-io
Copy link
Contributor Author

qt-io commented Jun 12, 2024

@bretg set pbs as false for now

@qt-io qt-io requested a review from bretg June 12, 2024 15:36
@bretg bretg added LGTM and removed question labels Jun 12, 2024
@bretg
Copy link
Contributor

bretg commented Jun 12, 2024

this was in 8.51 - merging

@bretg bretg merged commit e03e747 into prebid:master Jun 12, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qt-io @bretg