Skip to content

Commit

Permalink
fix spawn EINVAL error (#69)
Browse files Browse the repository at this point in the history
fixes #68
  • Loading branch information
derevnjuk authored May 2, 2024
1 parent a79f703 commit 692860e
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions bin.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ if (!buildFromSource()) {
}

function build () {
var args = [os.platform() === 'win32' ? 'node-gyp.cmd' : 'node-gyp', 'rebuild']
var win32 = os.platform() === 'win32'
var args = [win32 ? 'node-gyp.cmd' : 'node-gyp', 'rebuild']

try {
var pkg = require('node-gyp/package.json')
Expand All @@ -27,7 +28,7 @@ function build () {
]
} catch (_) {}

proc.spawn(args[0], args.slice(1), { stdio: 'inherit' }).on('exit', function (code) {
proc.spawn(args[0], args.slice(1), { stdio: 'inherit', shell: win32, windowsHide: true }).on('exit', function (code) {
if (code || !process.argv[3]) process.exit(code)
exec(process.argv[3]).on('exit', function (code) {
process.exit(code)
Expand All @@ -45,15 +46,18 @@ function preinstall () {

function exec (cmd) {
if (process.platform !== 'win32') {
var shell = os.platform() === 'android' ? 'sh' : '/bin/sh'
return proc.spawn(shell, ['-c', '--', cmd], {
var shell = os.platform() === 'android' ? 'sh' : true
return proc.spawn(cmd, [], {
shell,
stdio: 'inherit'
})
}

return proc.spawn(process.env.comspec || 'cmd.exe', ['/s', '/c', '"' + cmd + '"'], {
return proc.spawn(cmd, [], {
windowsVerbatimArguments: true,
stdio: 'inherit'
stdio: 'inherit',
shell: true,
windowsHide: true
})
}

Expand Down

0 comments on commit 692860e

Please sign in to comment.