Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot specify binary_host for packages starting with @ #152

Closed
tom-boothman opened this issue Jun 1, 2021 · 1 comment
Closed

Cannot specify binary_host for packages starting with @ #152

tom-boothman opened this issue Jun 1, 2021 · 1 comment

Comments

@tom-boothman
Copy link
Contributor

tom-boothman commented Jun 1, 2021

Packages with names starting with @ such as
https://github.com/abandonware/node-bluetooth-hci-socket/blob/master/package.json and https://github.com/serialport/node-serialport/blob/master/packages/bindings/package.json can't have their binary_host override specified.

"@serialport/bindings" wants a variable called _serialport_bindings_binary_host according to https://github.com/prebuild/prebuild-install/blob/master/util.js#L64

Any npm config variable that starts with a _ just seems to vanish whether you specify it from .npmrc or as a command line parameter to npm i.

Steps to reproduce

npm_config__serialport_bindings_binary_host="https://whatever/" npm i @serialport/bindings

or

echo '_serialport_bindings_binary_host="https://whatever/' >> .npmrc
echo 'test=5' >> .npmrc
npm i @serialport/bindings
npm config list
@vweevers
Copy link
Member

Done in #153.

mmomtchev added a commit to mmomtchev/prebuild-install that referenced this issue Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants