Upgrade to version 2 of detect-libc #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the Report API where available (Node.js 12+) Otherwise spawns a single child process (Node.js 8, 10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, the latest detect-libc has been modernised to use the non-blocking Node.js Report API where available (Node.js >= 12), falling back to use an efficient single child process with older versions.
It's a major version bump for detect-lib as it drops support for versions of Node.js < 8. Given prebuild-install already requires >= 10 this PR should OK to include in a patch release.
There's an extensive integration test suite, e.g. https://github.com/lovell/detect-libc/actions/runs/1717414863
Should anyone be interested in the background to this, please see lovell/detect-libc#14