-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make 'rc.path' absolute #158
Conversation
I would prefer to do it here: Lines 45 to 47 in cca87fb
So that we don't modify rc outside of rc. Along the lines of: rc.path = path.resolve(rc.path === true ? '.' : rc.path || '.') |
5020475
to
227e17e
Compare
Can you update this test accordingly? prebuild-install/test/rc-test.js Lines 33 to 34 in cca87fb
|
I just saw that after I pushed it, I'll take a look! What should I set as the correct path? Running the tests on Github vs locally will result in a different value for path. |
It's OK to use prebuild-install/test/rc-test.js Line 149 in cca87fb
I.e. |
6.1.4. Thanks! |
I went ahead and implemented the suggestion by @vweevers. This will make
rc.path
an absolute path.This fixes #157.