Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminar Duplicação de código #11

Open
ludimila opened this issue Aug 3, 2018 · 0 comments
Open

Eliminar Duplicação de código #11

ludimila opened this issue Aug 3, 2018 · 0 comments
Labels
decision hacktoberfest prioridade-média

Comments

@ludimila
Copy link
Contributor

ludimila commented Aug 3, 2018

Código duplicado dificulta a manutenção e a eficiência do código.

Os códigos duplicados segundo análise do Code Climate estão no link abaixo:

https://codeclimate.com/github/prefeiturasp/SME-FilaDaCreche/issues?category=duplication&engine_name%5B%5D=structure&engine_name%5B%5D=duplication
victorsenam added a commit to victorsenam/SME-FilaDaCreche that referenced this issue Aug 25, 2018
@victorsenam
Creates SchoolContact component
d733308 
It is intended two remove duplicate code between the `RegistrationList` and the `SchoolList` components, as requested by prefeiturasp#11.

[Here](http://filadacreche.sme.prefeitura.sp.gov.br/#/resultados/28/-46.793739000000016/-23.6862114/R.%20Feiti%C3%A7o%20da%20Vila,%20399%20-%20Chacara%20Santa%20Maria,%20S%C3%A3o%20Paulo%20-%20SP,%2005879-000,%20Brasil) is an example of SchoolList being used. If you click "Cadastrar na fila" at the bottom part of the page, you will reach a page where RegistrationList is used. Neither of those should break after this change, they should look exactly the same as before.
@victorsenam victorsenam mentioned this issue Aug 25, 2018
Merged
@victorsenam victorsenam mentioned this issue Sep 28, 2018
Merged
@gabrielsclimaco gabrielsclimaco mentioned this issue Oct 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decision hacktoberfest prioridade-média
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ludimila @victorsenam