-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add option to init with a pyproject.toml #1188
Conversation
/// The pyproject.toml template | ||
/// | ||
/// This is used to create a pyproject.toml from scratch | ||
const NEW_PYROJECT_TEMPLATE: &str = r#"[project] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure or what to include in that template. build-system, python version, etc.
Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know uv has a slower code path for it currently, but would hatch be a better option than setuptools?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. Setuptools seems to remain the most used today. https://framapiaf.org/@fcodvpt/111540079686191842
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok let's leave it.
Slightly related question: the import command initialise the prefix. This is currently the only branch that does this. To be consistent, should we do it here as well (to install python)? Personally, I find it strange, and would rather pull out the prefix initialisation from the import branch |
Yes! I ❤️ this thank you! With regards to your question I would keep this as you have now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @olivier-lacroix
Fixes #1177