Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not leak env vars from bat scripts in cmd.exe #1205

Merged
merged 3 commits into from
Apr 16, 2024
Merged

fix: do not leak env vars from bat scripts in cmd.exe #1205

merged 3 commits into from
Apr 16, 2024

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Apr 16, 2024 •
edited
Loading

This fixes #1200

With this change, for cmd.exe / bat scripts we now wrap the script with:

@echo off
setlocal
... script contents
endlocal

ruben-arts
ruben-arts approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ruben-arts ruben-arts enabled auto-merge (squash) April 16, 2024 09:46
@ruben-arts ruben-arts merged commit 280f5cb into prefix-dev:main Apr 16, 2024
24 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruben-arts ruben-arts ruben-arts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: pixi keeps adding global package to %PATH% until it's too long
2 participants
@wolfv @ruben-arts