Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set linguist attributes for pixi.lock #265

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Set linguist attributes for pixi.lock #265

merged 4 commits into from
Aug 18, 2023

Conversation

spenserblack
Copy link
Contributor

Just stumbled on this project and figured I'd add this small nice-to-have.

This applies syntax highlighting in the GitHub web interface, and treats it as a generated file.

In the future, you might want to contribute to github-linguist so that GitHub has proper support for this filename, but, for now, a quick search shows that this file probably won't meet the popularity requirement.

This applies syntax highlighting in the GitHub web interface, and treats
it as a generated file.
@baszalmstra
Copy link
Contributor

Hey @spenserblack ! Thanks for your contribution!

I was wondering, would you also be able to contribute adding the .gitattributes file when running pixi init? Similar to how we generate a default gitignore.

@spenserblack
Copy link
Contributor Author

I'll see what I can do 🙂

So you're good with both attributes? Note that GitHub excludes generated files from PR diffs. So, while it might be accurate to label pixi.lock as generated, you might prefer not to. yarn.lock for example, had a PR to linguist to stop marking it as generated.

@spenserblack
Copy link
Contributor Author

Done. Let me know if you want any more changes 🙂

@baszalmstra
Copy link
Contributor

Ah that is a problem indeed, I wasn't aware of that detail. In that case, lets remove the generated part. I think it is very important people are aware a lock file changed in a PR.

@baszalmstra
Copy link
Contributor

Thanks! Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants