Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: also install cargo-dist on build-local #2683

Merged
merged 21 commits into from
Dec 11, 2024

Conversation

ruben-arts
Copy link
Contributor

@ruben-arts ruben-arts commented Dec 10, 2024

It worked 🎉 https://github.com/prefix-dev/pixi/releases/tag/v0.39.2-prerelease.2

Changes we had to make:

  • We now have a fork of cargo-dist at: WIP: Show fork changes ruben-arts/cargo-dist#1
    • This changes how the normal binaries are structured for tar.gz
    • It adds notarization for the macos binaries
  • We unpack the cargo-dist generated archives and re-upload the binaries in unpacked form, this is important for setup-pixi.
  • We don't announce fully be release as draft.

.github/workflows/release.yml Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
Copy link
Contributor

@nichmor nichmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my side

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.lock Outdated Show resolved Hide resolved
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get a working release again!

@ruben-arts ruben-arts merged commit 52e80bc into main Dec 11, 2024
22 of 23 checks passed
@ruben-arts ruben-arts deleted the fix/install_cargo-dist_fork branch December 11, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants