Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use toml-span for deserialization #2718

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

baszalmstra
Copy link
Contributor

@baszalmstra baszalmstra commented Dec 17, 2024

Fixes #2640

WIP refactor to use toml-span for parsing instead of serde. This gives us much more control over deserialization and the use of spans.

@bollwyvl
Copy link
Contributor

It looks like taplo uses toml-span, which is likely a good sign... though I still don't see a clear path to a "perfect" generated representation of the key structures as JSON schema, (a la #2057 where schemars is mentioned).

Indeed, using more of taplo (and even its semi-icky x-taplo schema stuff) might lead to some opportunities to support (not just) That Editor on #2444.

@Hofer-Julian
Copy link
Contributor

@baszalmstra The integration tests should be fine now with 62af58f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants