Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lightgbm demo #492

Merged
merged 7 commits into from
Nov 30, 2023
Merged

add lightgbm demo #492

merged 7 commits into from
Nov 30, 2023

Conversation

partrita
Copy link
Contributor

I just made simple code for ML.
Thanks in advance.

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @partrita Thank you!
Left a few small requests.

examples/lightgbm/pixi.toml Outdated Show resolved Hide resolved
examples/lightgbm/pixi.toml Show resolved Hide resolved
examples/lightgbm/README.md Outdated Show resolved Hide resolved
@ruben-arts
Copy link
Contributor

He @partrita This looks good, could you also commit the updated the pixi.lock. I you don't have it yet you can run pixi install and then push the changes!

@partrita
Copy link
Contributor Author

He @partrita This looks good, could you also commit the updated the pixi.lock. I you don't have it yet you can run pixi install and then push the changes!

Ok, I just commited. Thanks!

@ruben-arts
Copy link
Contributor

Sorry, I forgot to run start CI on your PR. You should be able to test this locally with pixi run lint.

@partrita
Copy link
Contributor Author

Sorry, I forgot to run start CI on your PR. You should be able to test this locally with pixi run lint.

pixi run lint command was not working, I do this.

pixi global install pre-commit
pre-commit install //in project folder
git add .
git commit -m ""
git push

Thanks!

@ruben-arts ruben-arts merged commit ddd03ac into prefix-dev:main Nov 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants